From: "Fu, Chao-Ying" <fu@mips.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>,
Richard Sandiford <rdsandiford@googlemail.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>,
"Fuhler, Rich" <rich@mips.com>,
"Lau, David" <davidlau@mips.com>,
"Mills, Kevin" <kevinm@mips.com>,
"Garbacea, Ilie" <ilie@mips.com>,
Catherine Moore <clm@codesourcery.com>,
Nathan Sidwell <nathan@codesourcery.com>,
Joseph Myers <joseph@codesourcery.com>,
Nathan Froyd <froydnj@codesourcery.com>
Subject: RE: [PATCH] MIPS: microMIPS ASE support
Date: Tue, 22 Feb 2011 20:19:00 -0000 [thread overview]
Message-ID: <7C6479EB2BF52547AC332FD6034646DA8495CBDC@exchdb01.mips.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1102111905400.20460@tp.orcam.me.uk>
>
> > > > + /* For microMIPS PC relative relocations, we cannot
> > convert it to
> > > > + against a section. If we do, it will mess up the
> > fixp->fx_offset. */
> > > > if (fixp->fx_r_type == BFD_RELOC_VTABLE_INHERIT
> > > > - || fixp->fx_r_type == BFD_RELOC_VTABLE_ENTRY)
> > > > + || fixp->fx_r_type == BFD_RELOC_VTABLE_ENTRY
> > > > + || fixp->fx_r_type == BFD_RELOC_MICROMIPS_7_PCREL_S1
> > > > + || fixp->fx_r_type == BFD_RELOC_MICROMIPS_10_PCREL_S1
> > > > + || fixp->fx_r_type == BFD_RELOC_MICROMIPS_16_PCREL_S1)
> > >
> > > "to be against a section". That's not a helpful comment though.
> > > _How_ will it mess up fixp->fx_offset? Give the reader a clue why
> > > the problem applies to BFD_RELOC_MICROMIPS_16_PCREL_S1 but not
> > > to something like BFD_RELOC_16_PCREL_S2.
GAS resolves all MIPS pc-relative relocation types inside assembling, so there are no issues for
BFD_RELOC_16_PCREL_S2. For microMIPS, GAS leaves them to the linker, so we hit new issues for
microMIPS pc-relative relocation types. Thanks!
Regards,
Chao-ying
next prev parent reply other threads:[~2011-02-22 20:19 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 18:19 [PATCH] MIPS: microMIPS and MCU ASE instruction set support Maciej W. Rozycki
2010-05-23 21:38 ` Richard Sandiford
2010-05-24 22:25 ` Fu, Chao-Ying
2010-05-26 19:47 ` Richard Sandiford
2010-06-01 14:21 ` Maciej W. Rozycki
2010-06-01 14:39 ` Catherine Moore
2010-06-01 22:04 ` Richard Sandiford
2010-06-01 22:47 ` Fu, Chao-Ying
2010-06-05 9:17 ` Richard Sandiford
2010-07-26 10:56 ` [PATCH] MIPS: microMIPS ASE support Maciej W. Rozycki
2010-07-26 13:25 ` Nathan Froyd
2010-07-26 13:53 ` Maciej W. Rozycki
2010-07-26 19:03 ` Richard Sandiford
2010-12-07 1:13 ` Maciej W. Rozycki
2010-12-12 14:59 ` Richard Sandiford
2010-12-14 13:30 ` Maciej W. Rozycki
2010-12-14 14:51 ` Richard Sandiford
2010-12-16 11:54 ` Maciej W. Rozycki
2010-12-18 10:26 ` Richard Sandiford
2010-12-14 17:56 ` Joseph S. Myers
2010-12-16 15:28 ` Maciej W. Rozycki
2010-12-17 20:56 ` Fu, Chao-Ying
2010-12-18 10:09 ` Richard Sandiford
2011-01-02 11:36 ` Richard Sandiford
2011-02-21 15:35 ` Maciej W. Rozycki
2011-02-22 20:12 ` Fu, Chao-Ying
2011-02-22 20:19 ` Fu, Chao-Ying [this message]
2011-02-24 10:46 ` Maciej W. Rozycki
2011-02-26 11:41 ` Richard Sandiford
2011-02-28 16:41 ` Maciej W. Rozycki
2011-02-26 0:00 ` Maciej W. Rozycki
2011-03-13 9:23 ` Richard Sandiford
2011-07-25 7:49 ` Richard Sandiford
2011-07-26 2:01 ` Maciej W. Rozycki
2011-07-29 0:58 ` Maciej W. Rozycki
2011-07-29 11:30 ` Richard Sandiford
2011-07-29 22:52 ` Maciej W. Rozycki
2011-02-26 11:36 ` Richard Sandiford
2011-07-26 14:00 ` Maciej W. Rozycki
2010-05-26 20:19 ` [PATCH] MIPS: microMIPS and MCU ASE instruction set support Richard Sandiford
2010-05-27 21:39 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7C6479EB2BF52547AC332FD6034646DA8495CBDC@exchdb01.mips.com \
--to=fu@mips.com \
--cc=binutils@sourceware.org \
--cc=clm@codesourcery.com \
--cc=davidlau@mips.com \
--cc=froydnj@codesourcery.com \
--cc=ilie@mips.com \
--cc=joseph@codesourcery.com \
--cc=kevinm@mips.com \
--cc=macro@codesourcery.com \
--cc=nathan@codesourcery.com \
--cc=rdsandiford@googlemail.com \
--cc=rich@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).