From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-70247-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 1484 invoked by alias); 22 Feb 2011 20:19:43 -0000
Received: (qmail 1471 invoked by uid 22791); 22 Feb 2011 20:19:39 -0000
X-SWARE-Spam-Status: No, hits=-0.4 required=5.0	tests=AWL,BAYES_50,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from dns1.mips.com (HELO dns1.mips.com) (12.201.5.69)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Feb 2011 20:19:35 +0000
Received: from exchdb01.mips.com (exchhub01.mips.com [192.168.36.84])	by dns1.mips.com (8.13.8/8.13.8) with ESMTP id p1MKJUMR026370;	Tue, 22 Feb 2011 12:19:30 -0800
Received: from EXCHDB01.MIPS.com ([fe80::2897:a30d:a923:303]) by exchhub01.mips.com ([::1]) with mapi; Tue, 22 Feb 2011 12:19:27 -0800
From: "Fu, Chao-Ying" <fu@mips.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>,        Richard Sandiford	<rdsandiford@googlemail.com>
CC: "binutils@sourceware.org" <binutils@sourceware.org>,        "Fuhler, Rich"	<rich@mips.com>, "Lau, David" <davidlau@mips.com>,        "Mills, Kevin"	<kevinm@mips.com>, "Garbacea, Ilie" <ilie@mips.com>,        Catherine Moore	<clm@codesourcery.com>,        Nathan Sidwell <nathan@codesourcery.com>,        Joseph Myers <joseph@codesourcery.com>,        Nathan Froyd <froydnj@codesourcery.com>
Subject: RE: [PATCH] MIPS: microMIPS ASE support
Date: Tue, 22 Feb 2011 20:19:00 -0000
Message-ID: <7C6479EB2BF52547AC332FD6034646DA8495CBDC@exchdb01.mips.com>
References: <alpine.DEB.1.10.1005181806590.4023@tp.orcam.me.uk> <87y6fa9u3t.fsf@firetop.home> <alpine.DEB.1.10.1007112325020.2824@tp.orcam.me.uk> <876302kqvu.fsf@firetop.home> <alpine.DEB.1.10.1012061924490.5345@tp.orcam.me.uk> <8739pb1qs5.fsf@firetop.home> <alpine.DEB.1.10.1102111905400.20460@tp.orcam.me.uk>
x-ems-proccessed: 6LP3oGfGVdcdb8o1aBnt6w==
x-ems-stamp: vuF0Js5gmMeomePfHHBMdA==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2011-02/txt/msg00278.txt.bz2

>=20
> > > > +  /* For microMIPS PC relative relocations, we cannot=20
> > convert it to
> > > > +     against a section.  If we do, it will mess up the=20
> > fixp->fx_offset.  */
> > > >    if (fixp->fx_r_type =3D=3D BFD_RELOC_VTABLE_INHERIT
> > > > -      || fixp->fx_r_type =3D=3D BFD_RELOC_VTABLE_ENTRY)
> > > > +      || fixp->fx_r_type =3D=3D BFD_RELOC_VTABLE_ENTRY
> > > > +      || fixp->fx_r_type =3D=3D BFD_RELOC_MICROMIPS_7_PCREL_S1
> > > > +      || fixp->fx_r_type =3D=3D BFD_RELOC_MICROMIPS_10_PCREL_S1
> > > > +      || fixp->fx_r_type =3D=3D BFD_RELOC_MICROMIPS_16_PCREL_S1)
> > >=20
> > > "to be against a section".  That's not a helpful comment though.
> > > _How_ will it mess up fixp->fx_offset?  Give the reader a clue why
> > > the problem applies to BFD_RELOC_MICROMIPS_16_PCREL_S1 but not
> > > to something like BFD_RELOC_16_PCREL_S2.

  GAS resolves all MIPS pc-relative relocation types inside assembling, so =
there are no issues for
BFD_RELOC_16_PCREL_S2.  For microMIPS, GAS leaves them to the linker, so we=
 hit new issues for
microMIPS pc-relative relocation types.  Thanks!

Regards,
Chao-ying