Re: [PATCH, V2 06/10] gas: scfidw2gen: new functionality to prepapre for SCFI

[Indu Bhagat <indu.bhagat@oracle.com>]

On 11/2/23 03:35, Jan Beulich wrote:
> On 31.10.2023 23:06, Indu Bhagat wrote:
>> On 10/31/23 04:28, Jan Beulich wrote:
>>> On 30.10.2023 17:51, Indu Bhagat wrote:
>>>> +void
>>>> +scfi_dot_cfi_startproc (symbolS *start_sym)
>>>
>>> This and the following two functions presently have no caller, and I
>>> also can't spot equivalents in dw2gencfi.c. How are they (going) to be
>>> used? This ...
>>>
>>>> +{
>>>> +  if (frchain_now->frch_cfi_data != NULL)
>>>> +    {
>>>> +      as_bad (_("previous CFI entry not closed (missing .cfi_endproc)"));
>>>
>>> ... for example suggests that the function here might really be the
>>> handler for .cfi_startproc, yet the table above says .cfi_startproc is
>>> ignored.
>>>
>>
>> The callers of scfi_dot_cfi_startproc (), scfi_dot_cfi_endproc () and
>> scfi_dot_cfi () are in scfi.c, when its time to emit DWARF CFI after
>> SCFI machinery has generated the SCFI Ops (See scfi_dot_cfi () and
>> scfi_emit_dw2cfi ()).  The callers are added in the next patch in the
>> series, "[PATCH, V2 07/10] gas: synthesize CFI for hand-written asm".
> 
> But that's not in the context of processing a .cfi_* directive. IOW the
> message is properly misleading.
> 

Makes sense. This will usually arise when something goes amiss with the 
SCFI machinery.

I will reword the message.

Indu