From: Nick Clifton <nickc@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Jan Beulich <jbeulich@suse.com>, Fangrui Song <i@maskray.me>,
binutils@sourceware.org
Subject: Re: [PATCH] ld: Improve --fatal-warnings for unknown command-line options
Date: Fri, 26 Jan 2024 10:24:46 +0000 [thread overview]
Message-ID: <7a9003a8-891b-465c-a38d-1160dd0a2f6e@redhat.com> (raw)
In-Reply-To: <CAMe9rOocc88E5fmhao13Yx7yys1ehafzRveJ0LH4x_yw+dsCDg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
Hi H.J.
I am applying the attached patch to fix a small problem with the
new fatal warnings 1a and 1b tests: they were failing on targets
which do not support the -pie command line option (eg RX and H8300).
Since -pie is not needed for the tests to work and other architectures
do not mind if it is absent, the patch just removes the option from
the command line.
Cheers
Nick
[-- Attachment #2: pr31289.supplimental.patch --]
[-- Type: text/x-patch, Size: 1134 bytes --]
diff --git a/ld/testsuite/ld-elf/fatal-warnings-1a.d b/ld/testsuite/ld-elf/fatal-warnings-1a.d
index d669392db88..7afee539a6a 100644
--- a/ld/testsuite/ld-elf/fatal-warnings-1a.d
+++ b/ld/testsuite/ld-elf/fatal-warnings-1a.d
@@ -1,6 +1,6 @@
#PR ld/31289
#source: pr22269.s
-#ld: -pie --no-dynamic-linker --fatal-warnings -z dynamic-undefined-weak
+#ld: --no-dynamic-linker --fatal-warnings -z dynamic-undefined-weak
#readelf: -r -x .data.rel.ro
#error: unsupported option: -z dynamic-undefined-weak
#target: *-*-linux* *-*-gnu* *-*-nacl* arm*-*-uclinuxfdpiceabi
diff --git a/ld/testsuite/ld-elf/fatal-warnings-1b.d b/ld/testsuite/ld-elf/fatal-warnings-1b.d
index 644e96b6707..70862b23287 100644
--- a/ld/testsuite/ld-elf/fatal-warnings-1b.d
+++ b/ld/testsuite/ld-elf/fatal-warnings-1b.d
@@ -1,6 +1,6 @@
#PR ld/31289
#source: pr22269.s
-#ld: -pie --no-dynamic-linker -z dynamic-undefined-weak --fatal-warnings
+#ld: --no-dynamic-linker -z dynamic-undefined-weak --fatal-warnings
#readelf: -r -x .data.rel.ro
#error: unsupported option: -z dynamic-undefined-weak
#target: *-*-linux* *-*-gnu* *-*-nacl* arm*-*-uclinuxfdpiceabi
next prev parent reply other threads:[~2024-01-26 10:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 22:51 H.J. Lu
2024-01-25 7:58 ` Fangrui Song
2024-01-25 8:24 ` Jan Beulich
2024-01-25 11:32 ` Nick Clifton
2024-01-25 13:41 ` H.J. Lu
2024-01-25 15:45 ` H.J. Lu
2024-01-25 16:12 ` H.J. Lu
2024-01-26 10:24 ` Nick Clifton [this message]
2024-01-26 14:11 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a9003a8-891b-465c-a38d-1160dd0a2f6e@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=i@maskray.me \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).