From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by sourceware.org (Postfix) with ESMTPS id 7AD883857C61 for ; Thu, 4 Jan 2024 09:01:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7AD883857C61 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7AD883857C61 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::235 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704358895; cv=none; b=o2IWtY+hpbIJ67CMiVabFupGuh0bmS2txpB+8j+1G/mt7mpseyyh/u+BYwH0einSP3NLvRzDeB0yB2z4cgbPOb6sq9exho2rZ3gP3C5aAJsg04z7rD9ZnyAk6Sr+QGDag6kruaS8e+YbanFyS8EFuDVppTGZUqO21VN+C2/kQvY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704358895; c=relaxed/simple; bh=qzQAUb2CTRhzmCw2s0SqwhOOdaHwGK2ZoKFKhR1tu/g=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=vGc03LRImxJ0VzsyMAECqeXtyVxjNxdTBWTuh63H7T+uyujwKgKvPwtWcKPlAkXXsD73shn0wjvZaVyzHHGx0ftFA4jkVN8QyZYgpSt12Ql8+1zztQygJJhJZuvJvH2rrQBPxnnaVLZzRB4Tb848V/EtQuLxNQgt4q2Dj6Igrl0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2cc7d2c1ff0so3389371fa.3 for ; Thu, 04 Jan 2024 01:01:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704358889; x=1704963689; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oQRpqvRTkchbmK46GFDE1VJTLXVMiQGbJVDjR2116rk=; b=GOXgPeKJ8x1oTUFQMLoleCHNwrObOB5pWte9MyRvyA5y5AHfY0vUCea+zLU03wiCX0 GE6CIyNjP3wZURXkNcHZsR/fLKuER0VeAdKrGs18bcznDJDI+JXYMcTy7dFOwBpxvXP5 eOf1ifq3cXWFH4oAXDDzMTD7jMdL36CIcGBsQlJW6LYyGOjJ5Pd8AJj7U5TrriBRdPGt DUbQqHj7/Ikwf1Fd/6bcz2dyiYW092+QVUzoMDkF4WNzY6PLZzJtm3rselC29F46bSsf D9hGb5f3pmJYOe+Xl9vspSpgXULd5toh4i+oUmMceqik7X4ixyLaTFWiOEdVYDspbZtp ZfMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704358889; x=1704963689; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oQRpqvRTkchbmK46GFDE1VJTLXVMiQGbJVDjR2116rk=; b=vk7caHanvgyHaV4XBohLUoOA6AwfeUuG0KiJBEpdu2+DxJ4C/w9OnFU7oghzhhJ4An IFDdZ8V8+ApdgaUk05UGOjj9mZEh+O7CbaW0u9WwMHqkmwLbBE8y82zpkD3w8BtPxuuQ LYZ442umlTZPW2lGMxNe+HIruzQQ1GEWCbXghGWA/HMl4QBmN5g3eh2vNo3eTKRTD0Jz y/U36t4spYD5ELQOYymJYkjBfhjmc2yEldbCwrZoC2tlfxMQgQgaxEu7oPl6eHYOddbz 5BW37BZn3XmSQJCveGVvER92wda9I/cdVrgCgf9QuqpgjvcMVqq0mv1Eb31sZw+4MHWX 6Nkw== X-Gm-Message-State: AOJu0YxgxEHMvkkcUYzlwrqh/VRGuKzaBZL3GFHijPapBis4pMiYSEv4 UFRIi5GF9/21NK1bwKxmKU0YAWMlRU/E X-Google-Smtp-Source: AGHT+IE+kBKY5oERnqK6Ti35z3Mf/r4sqrQrEhJ2vTXricCwx/8pP9iH6tusn6/vWDUkCyX9LfcPVw== X-Received: by 2002:a2e:92cb:0:b0:2cc:f5b6:91ef with SMTP id k11-20020a2e92cb000000b002ccf5b691efmr180150ljh.57.1704358889012; Thu, 04 Jan 2024 01:01:29 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id bw8-20020a056638460800b0046de81af653sm542258jab.21.2024.01.04.01.01.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jan 2024 01:01:28 -0800 (PST) Message-ID: <7a90372d-50a8-465e-9ad4-a7128f17cd5f@suse.com> Date: Thu, 4 Jan 2024 10:01:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/9] Support APX GPR32 with extend evex prefix Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" References: <20231219121218.974012-1-lili.cui@intel.com> <20231219121218.974012-4-lili.cui@intel.com> <4c64e863-22a3-43e4-a566-e05c7fb909bd@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26.12.2023 08:00, Cui, Lili wrote: >>> --- /dev/null >>> +++ b/opcodes/i386-dis-evex-x86-64.h >>> @@ -0,0 +1,50 @@ >>> + /* X86_64_EVEX_0F90 */ >>> + { >>> + { Bad_Opcode }, >>> + { VEX_W_TABLE (VEX_W_0F90_L_0) }, }, >>> + /* X86_64_EVEX_0F91 */ >>> + { >>> + { Bad_Opcode }, >>> + { VEX_W_TABLE (VEX_W_0F91_L_0) }, }, >>> + /* X86_64_EVEX_0F92 */ >>> + { >>> + { Bad_Opcode }, >>> + { VEX_W_TABLE (VEX_W_0F92_L_0) }, }, >>> + /* X86_64_EVEX_0F93 */ >>> + { >>> + { Bad_Opcode }, >>> + { VEX_W_TABLE (VEX_W_0F93_L_0) }, }, >>> + /* X86_64_EVEX_0F38F2 */ >>> + { >>> + { Bad_Opcode }, >>> + { PREFIX_TABLE (PREFIX_VEX_0F38F2_L_0) }, }, >>> + /* X86_64_EVEX_0F38F3 */ >>> + { >>> + { Bad_Opcode }, >>> + { PREFIX_TABLE (PREFIX_VEX_0F38F3_L_0) }, }, >>> + /* X86_64_EVEX_0F38F5 */ >>> + { >>> + { Bad_Opcode }, >>> + { PREFIX_TABLE (PREFIX_VEX_0F38F5_L_0) }, }, >>> + /* X86_64_EVEX_0F38F6 */ >>> + { >>> + { Bad_Opcode }, >>> + { PREFIX_TABLE(PREFIX_VEX_0F38F6_L_0) }, }, >>> + /* X86_64_EVEX_0F38F7 */ >>> + { >>> + { Bad_Opcode }, >>> + { PREFIX_TABLE(PREFIX_VEX_0F38F7_L_0) }, }, >>> + /* X86_64_EVEX_0F3AF0 */ >>> + { >>> + { Bad_Opcode }, >>> + { PREFIX_TABLE (PREFIX_VEX_0F3AF0_L_0) }, }, >> >> Am I misremembering that we had agreed that this new file isn't necessary, by >> having USE_X86_64_EVEX_FROM_VEX_TABLE handle the non-64-bit case? At >> least I couldn't find a mail from you saying this isn't possible (and why). >> > I Prefer not to change the current implement, we need a table that all instructions must go through, it can be x86-64 or len_table, > but I think x86-64 is better. It can reuse more old parts of x86-64 (for example X86_64_VEX_0F38E*) than len_table. If we use len_table instead, we need to let another 18 instructions through the len_table, this will also add the number of entries. > > 18 instructions are: > X86_64_VEX_0F38E0~ X86_64_VEX_0F38EF, X86_64_VEX_0F3849, and X86_64_VEX_0F384B. I don't see this as a (necessary) result. Since the patches were (imo prematurely) committed already, it'll now be (again) on me to see about cleaning up. Oh well. Jan