From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id 9B4773857836 for ; Fri, 18 Jun 2021 10:49:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9B4773857836 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2050.outbound.protection.outlook.com [104.47.9.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-32-WFQ5BTTAOzi-0p8PcDkPgQ-1; Fri, 18 Jun 2021 12:48:58 +0200 X-MC-Unique: WFQ5BTTAOzi-0p8PcDkPgQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FUG5eQEqEmIeUyIfcQO/IUBMHE2cSuwy74IKtbGRn1JJitDNFtFhWxpCykkLpjp2cXJTiKg+sNMjlTNW0N9XpTWIJYTfCTK0nnJZ+0cGCAJ+zaw7PbcbVYahwdQkpy63N0x1AlfJNSl/nUyiy7c7eBTFxG6J58VNlHbBLcPnD5E913/6eranIvqiBmCfPKG2UoqmWt1GQJ4H6pKDgPgiat22Om/Cd9B30udGcNPjyuj2s+kprdCjy4ohQ7L/5j2FkLpyANzohgfpRyQ8Hl0TjgN+E3/b2CE3ZFB0otPYsLfl8zHhoOBNjRhrrMiRJBNEGyAjTcl7M/VNGzM4YCqJcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wBjDcVvjiNh0r2KFpXBfvHaBrFLKoVPl6OeOmwHlPEk=; b=MSRhWtHhYvm3GAtzP4Y6ZI56pO0vU4Ms7KDTrsblbhWkIb42LXvqHVWIcZdAbNTIAHEYyotfyLGmRXsdYeRV8j7tybiu1+xcskJa0sJ63ZlktROM0DDiDp2yxW4lm39w+5Us3auMsaaUF2DaBYWOm6VsEVe3YjEJa7VnYg5yAt3gLhVyxUkkfP5qn/uR5TfCMHt7EY3GmZvQmguQ1dsebQCH10Y+MciOqBwnAKuGcQfjt7QABWAJ1Otocf2RolChAYH/mD5wLnkS73SX9OWn5deqSDXiAqfxlOsNkygqmR7tuRjshMEy4DHJxXNfzbPmXy5tme3s7afNZ5SlbjLQQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5741.eurprd04.prod.outlook.com (2603:10a6:803:df::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.19; Fri, 18 Jun 2021 10:48:56 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::f06c:6f5d:34d2:1c36%5]) with mapi id 15.20.4242.021; Fri, 18 Jun 2021 10:48:56 +0000 Subject: Re: [PATCH 1/6] x86: off-by-1 in offset_in_range() To: "H.J. Lu" Cc: Binutils References: <0babbec4-06ae-f980-18a9-20608046891b@suse.com> <7f92142e-e391-e1fe-c741-0d290f71da27@suse.com> From: Jan Beulich Message-ID: <7ad5d134-7378-b6ec-ba07-acb302ff914e@suse.com> Date: Fri, 18 Jun 2021 12:48:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [37.24.206.209] X-ClientProxiedBy: FR0P281CA0081.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::7) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.156.60.236] (37.24.206.209) by FR0P281CA0081.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.7 via Frontend Transport; Fri, 18 Jun 2021 10:48:56 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ed207b1e-ae82-4ea5-5a06-08d93246ac0f X-MS-TrafficTypeDiagnostic: VI1PR04MB5741: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2512; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GroRNQ+NzkTgzb1dwPYCbeP8Q8rrD53IswMntH0kPIyYQyCoWaWJFwLq9pVQ0dhk7+Fx/WywwhmwtQoVwRTf3aHwzZLwH/zSDMWtdUJcxHWhDzlaHt4IiuzhqKq1UDRWn2KVDuV4l6KEYer1tRFEiFDxCuWs2Gj1KHentli5z7EY7tR8fujYo9hWYqhYrlylfk2Zer3Aol6Z+itLqGHdkj/Ytt44yQDeKBK3lL6e9aOkSgZKhugD6zHH/bwrGOg1wK/fNMaYjFKkMx1sK+5NrKq1KxrlV2WvTYDpAZmifTkOoUVVcJLaztdgeFzSDPxisQN0jiXHDqUbBjKcxXKFoHhYpbSO+yd7pVuZCDvjsThyPMAGpyCVAcjesSOyAiaO5ZF+RFPyK1nwkEpbzOGwVPbcqdDLdPwMG4YXNExgZ5/OhJSnMiFpxuU3NRCim4l9WbAnGjqfqBjKDeQ/Naj3Zym47Bz+HthGqJkFCv0NXs8dkat7aWn0U3qH7LWvMfR6n9isyPhA2yhAJzG9zLCV0pzx58ioOvL1Fq7XaPlPy4OAiutq75Sbr7IOEIUkZOcfv5FCL4ZRP+ehfcCHLJZueAbJtC3fb6prNNRd3Ng0YlMc3GCS9yDGtCza8W8GbJeplJGE77eMhtclnDzMBz07qnpZehaCK0QpuHCTwOfhDcyDMbcuzrkvuxsuPTXnKAf8 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(376002)(366004)(346002)(136003)(396003)(26005)(16526019)(6486002)(53546011)(31696002)(478600001)(2616005)(8936002)(5660300002)(956004)(8676002)(31686004)(186003)(66946007)(36756003)(86362001)(16576012)(2906002)(4326008)(6916009)(83380400001)(38100700002)(316002)(66556008)(66476007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2s0T1NWRFl3V2drYlczamdtaDMzd1RlY0JQN3doRHltc1ZrMzlYUHZmd1FT?= =?utf-8?B?OWdkY0hUdi9keTNjRldqZDJWZWk1bTZadG10SGdmV2pHNlhRRXFuSzBFYll3?= =?utf-8?B?MmUzendLRnNGVDlqK2hNNDJ0Q0Rpajdyejd6MEtIRStLdG1rKzY1VVFPUTNS?= =?utf-8?B?WG1tcEVreUF3UFZvRzcvaEliWUtFcmh4T1BCd3M0MFVmRk1GbmlNS3RyTWdm?= =?utf-8?B?TVhkSmdRWktSb0FMRHlrM3RoRDVWM1ZVMk5kVThWUVdXckl0cWdWRHQ4RmQy?= =?utf-8?B?dG1yTkN2R0hhWjZtV2pJejRTMEI5cjN5TU9oc1NJN2RBdGgyYlFYUExPRFN4?= =?utf-8?B?NU03c2NLZW1GNG8zNkhsM3VKVWp6dWFVM3Jqak15U2FaTFA5d1BrUUZkLzQ1?= =?utf-8?B?QVRKaXM5VGZNR1NQWEtVTUp0RldpODJnbks4eEp2QnM1MkpocmdZQlNhTXdD?= =?utf-8?B?aWZ1VDFibUViem90TEhFRkZSWFA5dXFQU1l4VTVkeE81aEs2Mmd2dmViSEZz?= =?utf-8?B?b0kxTFh3VGIranAvQ3lGRmtjY1k4V3JmeUFnVE03Rk5Ya3dYL3FiaGFRNFJq?= =?utf-8?B?c1d0OHdGSS9pN0pJRXJxWUNVaHd5OUYzMWJCbUVmbjFjMHNqVUtZdjZjcWR3?= =?utf-8?B?UDlJdXNiYXRnWHZXWkhnMXNDTXNIOW9TV1JIRzF3a0tmdi9PZnRVR2pEUmI4?= =?utf-8?B?ZGNRbFdvVXk0RGhmQ25QVjFncU1QVGFWTVpCYnAvclNyVTZYN2ZncVFFaGtZ?= =?utf-8?B?UVF6TUhtMDdLZmQ2MzhDK2hwcnFURFo5eER5ZSs0d3IvY3FsYU0xTjB6bzN4?= =?utf-8?B?Q0RCMHJSaGxQUGdoSGVzK2xVMkpkTVNwVzkrKy82MnZDVkJIS3dRdUdTVEFQ?= =?utf-8?B?MEw0cTkxcGFjZkE0MkVLRGVQakxqWnR0VkhtVWdoUWxvTEtPaFUvOGUydTFG?= =?utf-8?B?bytzZHdwY0VrU3NhYm5NeEUzOEpjMzdQdFZJNlk0d0hFdkRNSWVoQWRCY0RP?= =?utf-8?B?a3dvWG8xNG5hVjBLWXdTZWpmYWpBcjM2SE5WQmo5dnllSVNxc3NtMTdJZ3Iz?= =?utf-8?B?WXFNcUkxazZuNGdjb29kTHdqMG16M0NucmppNHhxYnlWOG9iSldKSk5zdk9r?= =?utf-8?B?WUkvdE1KNC9heEJ2UXlyYmlaaWh1SGt0cFFJMXplUmR5VnIwOGgwTVpZVmNs?= =?utf-8?B?YzVudmFtZXREb3NBMkVZWTZMNHhWQWYzeXd6eEkzWHQwaHJWQ2Y5dFNYVitI?= =?utf-8?B?UmVDQzNkRXZaV1B6OS9pSjJ0Um5hRVFDREVSbWdjODFHalQ1eE91MGJ3MWUy?= =?utf-8?B?RU9Mc25LYmlKVzFPeDY0Y3hwbXdCMTRFbitQYUR2cE5waXlNdm85WFZ0Q29w?= =?utf-8?B?NU1lNkhQc2VhVW1YVXJzdEJ6YUd3Y2xabW42Q0UzcXBGeU1hQnMvMzFUczhB?= =?utf-8?B?V1haeHhRaXJwK0JZMXpMajkyeXBtM1JEdm9naGx6c2VxT3BZOWFENS9UaTl2?= =?utf-8?B?SS8rSUR5UDUySy8rV1ZTRCtQakprcVU3YWNlYkI3ZVplVzRMS0NHUmZmb3dw?= =?utf-8?B?dG9sY2luR3hUUVRjQ3VPeitIVmxvOERxd09kYUVlbDhJMENGRitvVFFPYTlv?= =?utf-8?B?TTRJK2d1VHNUaGJrcURvSEp1RkFGS01Qd1l6cHZFSllESGowK2wyV00zRlVW?= =?utf-8?B?bHpyVnJGY1l2VlNzanFGajdpVVU3MTZ0Q3dZdS9tRzAzQU9LcXJGVGhrTmV3?= =?utf-8?Q?YGWJBFI9z5r7wiAel7MyxGvnKYNrP7NSUM5Ak/W?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed207b1e-ae82-4ea5-5a06-08d93246ac0f X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2021 10:48:56.8360 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bDQUsXxFiX55yE2JCc3ogAZ153z61IS5zwI7YLaJnmCBIMFKXq3R9rohjxB7UakEjjYHE1xXTpKQ25r5k1L+FQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5741 X-Spam-Status: No, score=-3126.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 10:49:02 -0000 On 17.06.2021 16:40, H.J. Lu wrote: > On Mon, Jun 14, 2021 at 3:24 AM Jan Beulich wrote: >> >> Just like e.g. 0x10000 triggers a warning for size 2, -0x10000 ought to >> as well. >> >> Note that some of the encodings produced aren't ones one would expect, >> and hence the generated code is not being checked for in the new >> testcases. >> >> gas/ >> 2021-06-XX Jan Beulich >> >> * config/tc-i386.c (offset_in_range): Adjust conditional. >> * testsuite/gas/i386/disp-imm-16.s, >> testsuite/gas/i386/disp-imm-16.l, >> testsuite/gas/i386/disp-imm-64.s, >> testsuite/gas/i386/disp-imm-64.l: New. >> * testsuite/gas/i386/i386.exp: Run new tests. >> --- >> As for the new 16-bit test, see also the subsequent "x86: harmonize disp >> with imm handling" - it's at least debatable whether wrapping (in 16 >> bits) wouldn't better match 32-bit code's wrapping in 32-bits, as (to >> some degree at least, gets put in place there), in which case this >> testcase may better not be added here, as it would then "document" wrong >> behavior. > > > OK. Thanks, but did you perhaps miss that you had given your okay for the entire series already on the 14th? Jan