Re: [PATCH v1 7/7] ChangeLog: Add ASCII command

[Jan Beulich <jbeulich@suse.com>]

On 02.07.2024 00:26, Ulf Samuelsson wrote:
> I think it is better to keep them as separate commits while the patch is being reviewed and to create a single commit once each part is OK.
> Would that be OK with you guys?

That'll be a little strange, but may work. It'll want making clear though
what exactly is intended to be folded for committing.

Jan

>> 1 juli 2024 kl. 08:38 skrev Jan Beulich <jbeulich@suse.com>:
>>
>> On 28.06.2024 23:46, binutils@emagii.com wrote:
>>> --- a/ld/ChangeLog
>>> +++ b/ld/ChangeLog
>>> @@ -1,3 +1,18 @@
>>> +2024-06-28  Ulf Samuelsson <binutils@emagii.com>
>>> +        Nick Clifton  <nickc@redhat.com>
>>> +
>>> +    * ldlex.l: Add ASCII token.
>>> +    * ldgram.y: Add parsing of the ASCII command.
>>> +    * ldlang.c (lang_add_string): Add maximum size parameter.  Move
>>> +    escape character handling code into separate function.
>>> +    * ldlang.h (lang_add_string): Update prototype.
>>> +    * NEWS: Mention the new feature.
>>> +    * ld.texi (Output Section Data): Document the new directives.
>>> +    * testsuite/ld-scripts/ascii.d: New test driver.
>>> +    * testsuite/ld-scripts/ascii.s: New test assembler source.
>>> +    * testsuite/ld-scripts/ascii.t: New test script.
>>> +    * testsuite/ld-scripts/script.exp: Run the new test.
>>
>> The latest here it is clear: No, this can't be all separate commits.
>> ChangeLog entries, if any, should be added by the commit with the
>> changes actually being described. Separation of testcases and doc
>> additions is questionable, too. Perhaps all of this series really
>> would best be a single commit?
>>
>> Jan