From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id 4FE9B3858CDA for ; Tue, 2 Jul 2024 08:37:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4FE9B3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4FE9B3858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719909431; cv=none; b=ug6NM9Me5UcOp62oHnTvXhyKpzpRmYljuPy0ItLwZpyyQXWxsHRFfjiRl74CjsijH/96LYCXptEBy03g5p+0GmhJRpiQUFBocy+mKtOUR73ztft0O1p8+Am9q3zD40Wf8WpYTdhglMW9ldi5M2CVxqYBJ1mqbFbxC5NRzQWoCj4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719909431; c=relaxed/simple; bh=hCRe2R+miCZI2gx3p9vkk1nEIrRmKgGVQXRQcu3HLl4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=vDHx16fZ4AlRho4kFV1EvOXW74uY/9G9n9nSBg5oOvBMqBYu+xDt6huhVXRTCL/NT1jRX3Ok/W6zH15qHdIlv+PUpnwy+jV9rhv0nmS33VpwzVSYZCaJ2DyK8bR+/Muamw2NN0QZWm8tTjHJQTrR7RMprI+4/TMl8uYHPmLl7YY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2ec5fad1984so54474421fa.0 for ; Tue, 02 Jul 2024 01:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1719909426; x=1720514226; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=uN3G4ZFT87AhO9mAiddY1sbd2VRupPqqnLcVfh2RgsQ=; b=ROI+uI4CPbz1qSBjusBe8QZ/v0Qa5bvK7e5MH+xjT2XkdKQgjKA/mZIWHBd1aEv1u7 vNox590N36qyuVMlMmPQ7+glHx24uLkOTQvBJZrEVKLemrL5z/hN7Vh1R/+zigvDJZmu I3A0QYVQewNU7MpHVOEQRFlaRzIVY5PBjjcWg8usgtbzHVU+9jcltqrtGNR8NQQ1WS0T +ByVOLYcLr3hELHa2Pp7kSGYZG8rRZ24rVdMA1GHwVrwydNnGEsbqxMYseriwje1/Qr6 RBnBYBsIr2sqZ8PvQu90GCmP83sFsXAUQmwDVDixd6VPGvGg+58ynCHr/BAm5mQzxiJ9 qP1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719909426; x=1720514226; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uN3G4ZFT87AhO9mAiddY1sbd2VRupPqqnLcVfh2RgsQ=; b=RZBqDCdxRrTI8uvzeINyiBztsHUkPU/4rHcjLeb8gClevle2SgFJHbEPpkAj/RPeal j1xiBGXwOFFgndAN9JQ1rIVdCUF+04+Aeoa42RCvlsa8/nMQdK7t2Mc86X9TOJZMm3x+ GlHKjoDOqlL/YyKN/4dVFtkCoHjiil9HfhIuz/YJZ+8G1mTCaWT7OHsWfOcrkpOjLr7V o3sBMpXkHS7avY0fEpnH6eedfQfy9Fr+KDCR1pwjNH7FSDNXhG9vUSqKUMB4oMOhSWVQ TDJK7SwgsyKR8n+ruSqLjP5VFUA9c/vH0eOEY9sykqjR4vgTdNT3epm/5me82HDkUogq lHGg== X-Gm-Message-State: AOJu0YwHPPwWtB4YZwyaL+kW2KdsMYPHu0yCHtQwPP3SJN9V3fI8q+Cx em5Ro4ICJ31MjAiqLq6iiQJKcvOhN4mmR88DTa+GhETwTNjym0bnFiOuB6p0dE1Rg+CjDkSzaKk = X-Google-Smtp-Source: AGHT+IHyj/crIgrwPAa2hovI+iHdVqIsON0ozvHtSsDXsUwmZjJp9qP0EZIYYN3CqoQMUSO1gy1Pog== X-Received: by 2002:a05:651c:b0a:b0:2ec:52da:6070 with SMTP id 38308e7fff4ca-2ee5e6f6af5mr69139861fa.42.1719909426542; Tue, 02 Jul 2024 01:37:06 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7080205a19fsm7893130b3a.20.2024.07.02.01.37.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jul 2024 01:37:06 -0700 (PDT) Message-ID: <7b97fe41-8d67-4049-8572-436cb47f8844@suse.com> Date: Tue, 2 Jul 2024 10:37:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 7/7] ChangeLog: Add ASCII command To: Ulf Samuelsson References: <05771b75-d964-4df3-81b7-e890a1d91b12@suse.com> <094CF629-FDF8-436D-8B5B-62D35C3EA396@emagii.com> Content-Language: en-US Cc: Binutils , Nick Clifton From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <094CF629-FDF8-436D-8B5B-62D35C3EA396@emagii.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3024.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 02.07.2024 00:26, Ulf Samuelsson wrote: > I think it is better to keep them as separate commits while the patch is being reviewed and to create a single commit once each part is OK. > Would that be OK with you guys? That'll be a little strange, but may work. It'll want making clear though what exactly is intended to be folded for committing. Jan >> 1 juli 2024 kl. 08:38 skrev Jan Beulich : >> >> On 28.06.2024 23:46, binutils@emagii.com wrote: >>> --- a/ld/ChangeLog >>> +++ b/ld/ChangeLog >>> @@ -1,3 +1,18 @@ >>> +2024-06-28 Ulf Samuelsson >>> + Nick Clifton >>> + >>> + * ldlex.l: Add ASCII token. >>> + * ldgram.y: Add parsing of the ASCII command. >>> + * ldlang.c (lang_add_string): Add maximum size parameter. Move >>> + escape character handling code into separate function. >>> + * ldlang.h (lang_add_string): Update prototype. >>> + * NEWS: Mention the new feature. >>> + * ld.texi (Output Section Data): Document the new directives. >>> + * testsuite/ld-scripts/ascii.d: New test driver. >>> + * testsuite/ld-scripts/ascii.s: New test assembler source. >>> + * testsuite/ld-scripts/ascii.t: New test script. >>> + * testsuite/ld-scripts/script.exp: Run the new test. >> >> The latest here it is clear: No, this can't be all separate commits. >> ChangeLog entries, if any, should be added by the commit with the >> changes actually being described. Separation of testcases and doc >> additions is questionable, too. Perhaps all of this series really >> would best be a single commit? >> >> Jan