From: Nick Clifton <nickc@redhat.com>
To: Andrew Carlotti <andrew.carlotti@arm.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] aarch64: Eliminate unused variable warnings with -DNDEBUG
Date: Wed, 24 Jan 2024 11:47:11 +0000 [thread overview]
Message-ID: <7d231338-2a03-47da-82fe-a9bc24cb008f@redhat.com> (raw)
In-Reply-To: <bb1e06e9-e1e6-6f74-c888-b11e8387e1d5@e124511.cambridge.arm.com>
Hi Andrew,
> Ok for master and 2.42 branch?
Approved - please apply to master and branch.
> Incidentally, while two of these sections of code were added recently, the
> issue in aarch64-dis.c has been present since July 2022.
Yes - I only recently decided to add a build to my build farm that was configured
with -DNDEBUG. The idea being to catch problems exactly like this...
Cheers
Nick
prev parent reply other threads:[~2024-01-24 11:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 17:08 Unable to build the AArch64 binutils sources with NDEBUG defined Nick Clifton
2024-01-23 18:30 ` [PATCH] aarch64: Eliminate unused variable warnings with -DNDEBUG Andrew Carlotti
2024-01-24 11:47 ` Nick Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d231338-2a03-47da-82fe-a9bc24cb008f@redhat.com \
--to=nickc@redhat.com \
--cc=andrew.carlotti@arm.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).