public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Srinath Parvathaneni <srinath.parvathaneni@arm.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Binutils <binutils@sourceware.org>,
	Richard Earnshaw <rearnsha@arm.com>,
	Marcus Shawcroft <marcus.shawcroft@arm.com>,
	Nick Clifton <nickc@redhat.com>
Subject: Re: your patch enabling Arm64's GCS extension
Date: Mon, 12 Feb 2024 23:42:11 +0000	[thread overview]
Message-ID: <7d26c9ec-8816-4643-a5e8-8162803971d9@arm.com> (raw)
In-Reply-To: <671d046a-5592-4099-bf2f-5ccb08d166d6@suse.com>

Hi Jan,

On 2/12/2024 7:39 AM, Jan Beulich wrote:
> Srinath,
>
> may I ask against what specification this was written? There are two
> aspects I can't bring in line with what DDI0596 from December has, i.e.
> even newer than the patch (dating back to October):
>
> 1) gcspopcx, gcspopx, and gcspushx supposedly all have an optional
>     register operand, which gas 2.42 doesn't accept.

My understanding from the following specs is that the above mentioned

instructions does not take any optional arguments and this is aligned with

LLVM compiler behaviour.

https://developer.arm.com/documentation/ddi0601/2023-12/AArch64-Instructions/GCSPUSHX--Guarded-Control-Stack-Push-exception-return-record?lang=en

However, I am unsure about the statement "The value in the register by 
<Xt> is ignored" in the

specs and need further clarification. I will discuss this internally and 
get back to you with an update.

> 2) gcsstr and gcssttr supposedly have a memory-form 2nd operand, i.e.
>     a register name enclosed in square brackets. Gas 2.42 expects a
>     plain register name instead.

I agree this is a coding bug, I will create a bugzilla ticket and work 
on fixing this issue.

Thank You.

Regards,

Srinath

> Despite being newer it's of course possible that documentation is what
> actually needs fixing. Can you please clarify which way it is?
>
> Thanks, Jan

  reply	other threads:[~2024-02-12 23:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12  7:39 Jan Beulich
2024-02-12 23:42 ` Srinath Parvathaneni [this message]
2024-02-29 21:44   ` Srinath Parvathaneni
2024-03-01  6:48     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d26c9ec-8816-4643-a5e8-8162803971d9@arm.com \
    --to=srinath.parvathaneni@arm.com \
    --cc=binutils@sourceware.org \
    --cc=jbeulich@suse.com \
    --cc=marcus.shawcroft@arm.com \
    --cc=nickc@redhat.com \
    --cc=rearnsha@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).