From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id A9F373857C48 for ; Fri, 4 Mar 2022 12:41:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A9F373857C48 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2055.outbound.protection.outlook.com [104.47.9.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-12-C2v39LsnNjyfWMG7JJY4fg-1; Fri, 04 Mar 2022 13:41:24 +0100 X-MC-Unique: C2v39LsnNjyfWMG7JJY4fg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pr7UDih5I9AB6/SqyKoDutum8lrfJsIOBc01567T/uK5gl74PGlHXieOXd0Mxa3oZY7I5CQ22U8z76CpNrt8FLgF1wZynGJUsnOlOti8yw9IoZgbdeZiMWM8wOw7/jGhkbHHGAtmU1NuLuVG5/BTEz6vM1hmuSA5HAt4gcKRWkV60ogsJIvH/EbatIRqKQtVF5IfjBn4qMuF1v2xn42GehejFKbSOg2g36bkhiCOPcQZxkFau5hIgPqULZg/c6RA5KqoImQ1mmhOdxwAguSotX+QNrk4P7xlhx/uqMdqu6A+ZLe7SpUKzLXAmh/umlyPLN8aBiLGqFXngbhtkxVzsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AvEInP1qWlTWDixvN3x0bDPEB2HDcfKQI4etj65YzL0=; b=gZzD+4pSkgthh3GuoyJ+ciEbsFrHuVVrYZ/3OtUHczOOATVqbP+0VsKU5lXwdzBXehNVVtwsxUnLNksZzOH/4vkgwYitlXz02qWLBJOk1IXSRi9MmXxiiLR00mena+qBQTJ1iHbhqLA+s8n2l+JxSzN30WpEAL0pgP8KUqfXAnEZt+gtN5f5Gj1hSgMbzKqhMKQEOD+1u4y85GB+ZhX+5yCB9rIeYeC3rY2VLYlB5iOGSuav2vJPRPXnPzrL2/QuXxtXejuts0PHnddhmHUUuNA8BFjjO6mir/mAaJrnZE6zmS+5OkTad3CGcplDQ/mA8Ktx387V5S57joaFi6lcAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM0PR04MB5426.eurprd04.prod.outlook.com (2603:10a6:208:120::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Fri, 4 Mar 2022 12:41:23 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5038.017; Fri, 4 Mar 2022 12:41:23 +0000 Message-ID: <7d633e34-657c-539e-7df9-146c4dd649f2@suse.com> Date: Fri, 4 Mar 2022 13:41:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 From: Jan Beulich Subject: [PATCH v2] RISC-V: correct FCVT.Q.L[U] To: Binutils Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM7PR04CA0002.eurprd04.prod.outlook.com (2603:10a6:20b:110::12) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8eefe78a-8af9-4a26-9bbb-08d9fddc4a3d X-MS-TrafficTypeDiagnostic: AM0PR04MB5426:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q33f9OOLawg+UZgHmoRJA6a90mksX81sCLM4GVBsVuKJ3f9sxDf0ozFOJ+c2D090V+dqKkP1nTCX2kGH+w5OwhAzKoOsrPAEtbRf1DGjUi40il6CwC7doXqpqZRTMgTJEhYv+aYpOUd+qaZ5o8t2htwlKqSFsa34idv9tplOw1cPswXyLWr/E/4C5x1jFr4mbLAilQzB5dh1y1+kZqsoH3bpSpD2fHj4RCHqY3jBsBbQNppYpUKy7xtH4SIA5KGqPOAbXn+CI4iKPn+K5vIHoGqBbS7tm2p9wyLbZw+HwEAuv3Z5MvIWcPdQ6eCBTmtyiH7XDhWtx32W7RHncVhiSJ7TGtSZsUsLSrLhGBZrYoUpGWK54jeH/dw+g9Hoo145dbbhuUsLYBc+ukDEzMXP9VM3XMlERHZMJkrghA0PITGRWphPiuPOR6JBoaKWG0xIQOXfGQaQrF2tPABFVroSZp8HlJlC8n0auANShHnIpIMMSTxs1i29bTcFcflpoIRMhFdej1ZqGjXz0bBSrX9SB+nOPMOIiam2J6zwWWxFZbBgjMj0RnsjvBlx+UsM7iggZ1RFYVvOroJmRL5/lNwt9MnnAU6U73SjPLt5EFG5Au0Y720S07pO7+n00fElpQPKYjx0wymx7Ze+FnWF5NcFf3LIBCIPhq13qdl3QWZgsXPTLSH1+2nPl5muU5rJ+V6Yn1tautQNYg1KbddpFShqScKoTNkEM8iAINcQpeq/xiQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2616005)(31696002)(6916009)(316002)(54906003)(508600001)(83380400001)(31686004)(5660300002)(26005)(66476007)(6486002)(66556008)(8676002)(186003)(66946007)(4326008)(86362001)(6512007)(6506007)(36756003)(38100700002)(2906002)(8936002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGQ0bjZjaHllYlFyU3F6aDJPYWo0ZllIdC9LN3V5SWFleGl0N1ZBbDNnMjE5?= =?utf-8?B?YU9BUWF0L29nSHNHRzAvMU5IdklGSDJ6bUpqS2FGaFM3NVgwWFF6ekdPNkRk?= =?utf-8?B?Q3VWcGdJSHhwS1NJOTVQV1R5OFJmNmV4ZmVTSWxMT09PTW1oN3hBSjYwbGVR?= =?utf-8?B?T2huSkNjUmtuUVdvelEvMjFld0szV0sxbVM2b3VmeThmcDZIeDRRYVhFWFA0?= =?utf-8?B?K25CTkxnckY0L2ZDRVBGblgwZFA2bi9IejRUeXlJN1lYT3ZpUTZCRStCR2dD?= =?utf-8?B?RUtYZDFCWHVKajF1eWtIL2hnZm1LZjlyNFVJRllPRzVxelZMS0lPNHNHYTVW?= =?utf-8?B?bWVMWVBiLzRvVkVYV2w4NzVWZHZrZWRQdTY3OEhWR3QwTnVyRzVZb0J2bHZP?= =?utf-8?B?Rllja2NXL0svUWYraDRBbU92elp5ZUVHbUN6c0xvR3RIZ0gxV1RnMkw4anAy?= =?utf-8?B?MXhQcUlCMU85c0g2dDhXZDcyVk1kaVZ3aTBYQkxHOTBKV2xaQUxESXpYUWxZ?= =?utf-8?B?ZzZxejBNcDRmTlh2L09aRGZZaklWK0I2S205VXQ2RWc2YUlXWVVIbEExYjFN?= =?utf-8?B?bVNZRFIyNGMzVmc4Y1BsQWxiVGtKaU15UjRqT2tET1g1V0NqTk1TUjVRbkRj?= =?utf-8?B?WU5lc1g3YkZFd0k3YVZ1cWVUcHNNN3lpZnBtN1ZtWEVxVmh4RnhJUnoyazJt?= =?utf-8?B?S2puNk9LNnJBMkptajlvZ2ovOVhkRjd4UitMRzJ3Zzd3RE5TZmNnUVd4Z1Vl?= =?utf-8?B?Z3FDSU0wSGZXVlRMTFpRSWJxcW9Jb1RTaVdIczU3UG5HQ3hxQjk4d0dLdmpi?= =?utf-8?B?UlIvZ25yamdTM2R1a0o3cGM4ZWR6c2t3YlNwekxlOXR1Q0hJTEJpdzNDai9t?= =?utf-8?B?eFRuQXF1SUZldXZNcCtZUWtGbUJhQVVaM1hMU2NidW9VRUgyR0Q2c2hzQzFi?= =?utf-8?B?aHZpc3Y1N1JTUHB5NUJxblZYMlIzYVRHckZSOElFZmlpdWh6eWVESFA4V0dM?= =?utf-8?B?em01b2lBWFZIYXVSQXZpM2hSYm1xZkhEVWhBRHpkdlJIN3pPL3BaSTllOWYz?= =?utf-8?B?QUdXY3hMMEJXek1RVzU0czVaYmdKWXdkeEJ3dHZrWFA2TjMwR2plOHVyQ2V3?= =?utf-8?B?TEtRaVNOSnFZWmhFb1hWRW9jazg1MlZoVENVdENRRU02NEkzdnlHczVnejNi?= =?utf-8?B?a0x2dmNZOW9Ubi9VUytlVFF2Ly9HRFkzdmwzWTBXREZvY2l0S3BTZW1IUDJq?= =?utf-8?B?UlJqajZiMmkzQ05wQmo2ODRpT1QzcTlJSDNuL2txMGxjRW5aTWdJQkoyNzN4?= =?utf-8?B?Y2lFUlhVdzRKdnpIc20xamMzM2hPYmYvVEhKTFJ6c2kwczc5MVNzR0hybWVR?= =?utf-8?B?RXFxR3BEL2IrekU0MENWa0Vvemo1UHhhd0JmUWtPdGlYUFpXcEM5UXlkZG9m?= =?utf-8?B?SnJQbWF4bHpPV1JDanJjNzJ2amIyMWUwOXJTenlUU1paOHkvc05WYWRyMjRD?= =?utf-8?B?Vk14WFVXeXlpY1c5WGNTdktyaWRkT0lmVldMYTVjWnNuTjMzR1R2dVFWU0t3?= =?utf-8?B?STc4cEcxSVI2RzdMZnZlc00xWWdsRW5seDNmQ094WFFWVnNydDBRdG5OUUNi?= =?utf-8?B?eEdnOWN6cHZxanFGWGNtNVVyVExZNE4zTkt6QkhiR3FPdnFXNmpIY3ZPdHZO?= =?utf-8?B?bU4yWll4U0xheFZmQ3FxZHJRdkxOZlNTQjJVeHVjSTA5WGpGK1JtS1ozaHpv?= =?utf-8?B?TEtkUmJmd2U2Q3ZqTW9rRG1EaHQ3cW9MbHVDZEhpUk9Lekl1SC9JWDBjVDA5?= =?utf-8?B?dFdyT3AxV0pNNG5UMXNydUZsUndqK0VOQms2bGpVNThHVVhoa2twazVNUXF3?= =?utf-8?B?d2k2bDFTdlJJdTJvcFFMVU1saEZCajhpbDU0ZktoWnNtcGlyM2ZlUmRVNEVJ?= =?utf-8?B?bmsydzZNUnNYYXZVeWpXWGk0bnlLRlVpRVpTeklsK25OL1NqWXZVUWVIenN1?= =?utf-8?B?aU9CVXFqclpLT0orYyt0bHhZdndPVzhpZUNmVjVMajhhTkxIcUdBMnR6WGR2?= =?utf-8?B?cnlwdGZRR0FMV0VweFZwdEhwQkoxR1pVWncrcVVaR0VJYWpGK1BVTUFyVEdl?= =?utf-8?B?NmxJVU5DWFBoaG5SQllHOHFFNWEzekxRNVplbXRKUGEvQ1FzUHBRWUFWYWx3?= =?utf-8?Q?FPk4mYYTXncF7nMp301VOoM=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8eefe78a-8af9-4a26-9bbb-08d9fddc4a3d X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 12:41:23.1694 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZL50qCekUc4CWZsfHSuUHuxNNW8BBntuUHFVRPHhias2MQhDiJawS8/kW1Su42JYR5ix2Da5LKxN+elmbct8GQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5426 X-Spam-Status: No, score=-3032.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2022 12:41:31 -0000 While the spec isn't explicit about this, it pointing out the similarity with the D extension ought to extend to the ignoring of a meaningless rounding mode: "Note FCVT.D.W[U] always produces an exact result and is unaffected by rounding mode." Hence the chosen encodings also ought to match. Note that to avoid breaking existing code the forms with a 3rd operand are not removed, which means there continues to be a difference to FCVT.D.W[U]. --- Oddly enough there's looks to be no testing of the Q (or D/F) extension beyond what was recently added for Zqinx (Zdinx/Zfinx). --- v2: Re-base. --- a/gas/testsuite/gas/riscv/zqinx.d +++ b/gas/testsuite/gas/riscv/zqinx.d @@ -28,8 +28,8 @@ Disassembly of section .text: [ ]+[0-9a-f]+:[ ]+46158553[ ]+fcvt.q.d[ ]+a0,a1 [ ]+[0-9a-f]+:[ ]+d6058553[ ]+fcvt.q.w[ ]+a0,a1 [ ]+[0-9a-f]+:[ ]+d6158553[ ]+fcvt.q.wu[ ]+a0,a1 -[ ]+[0-9a-f]+:[ ]+d625f553[ ]+fcvt.q.l[ ]+a0,a1 -[ ]+[0-9a-f]+:[ ]+d635f553[ ]+fcvt.q.lu[ ]+a0,a1 +[ ]+[0-9a-f]+:[ ]+d6258553[ ]+fcvt.q.l[ ]+a0,a1 +[ ]+[0-9a-f]+:[ ]+d6358553[ ]+fcvt.q.lu[ ]+a0,a1 [ ]+[0-9a-f]+:[ ]+26c58553[ ]+fsgnj.q[ ]+a0,a1,a2 [ ]+[0-9a-f]+:[ ]+26c59553[ ]+fsgnjn.q[ ]+a0,a1,a2 [ ]+[0-9a-f]+:[ ]+26c5a553[ ]+fsgnjx.q[ ]+a0,a1,a2 --- a/opcodes/riscv-opc.c +++ b/opcodes/riscv-opc.c @@ -763,9 +763,9 @@ const struct riscv_opcode riscv_opcodes[ {"fcvt.l.q", 64, INSN_CLASS_Q_OR_ZQINX, "d,S,m", MATCH_FCVT_L_Q, MASK_FCVT_L_Q, match_opcode, 0 }, {"fcvt.lu.q", 64, INSN_CLASS_Q_OR_ZQINX, "d,S", MATCH_FCVT_LU_Q|MASK_RM, MASK_FCVT_LU_Q|MASK_RM, match_opcode, 0 }, {"fcvt.lu.q", 64, INSN_CLASS_Q_OR_ZQINX, "d,S,m", MATCH_FCVT_LU_Q, MASK_FCVT_LU_Q, match_opcode, 0 }, -{"fcvt.q.l", 64, INSN_CLASS_Q_OR_ZQINX, "D,s", MATCH_FCVT_Q_L|MASK_RM, MASK_FCVT_Q_L|MASK_RM, match_opcode, 0 }, +{"fcvt.q.l", 64, INSN_CLASS_Q_OR_ZQINX, "D,s", MATCH_FCVT_Q_L, MASK_FCVT_Q_L|MASK_RM, match_opcode, 0 }, {"fcvt.q.l", 64, INSN_CLASS_Q_OR_ZQINX, "D,s,m", MATCH_FCVT_Q_L, MASK_FCVT_Q_L, match_opcode, 0 }, -{"fcvt.q.lu", 64, INSN_CLASS_Q_OR_ZQINX, "D,s", MATCH_FCVT_Q_LU|MASK_RM, MASK_FCVT_Q_LU|MASK_RM, match_opcode, 0 }, +{"fcvt.q.lu", 64, INSN_CLASS_Q_OR_ZQINX, "D,s", MATCH_FCVT_Q_LU, MASK_FCVT_Q_LU|MASK_RM, match_opcode, 0 }, {"fcvt.q.lu", 64, INSN_CLASS_Q_OR_ZQINX, "D,s,m", MATCH_FCVT_Q_LU, MASK_FCVT_Q_LU, match_opcode, 0 }, /* Compressed instructions. */