From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by sourceware.org (Postfix) with ESMTPS id 24508387689F for ; Fri, 30 Jun 2023 20:57:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 24508387689F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-262e04a6f66so1239677a91.0 for ; Fri, 30 Jun 2023 13:57:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688158669; x=1690750669; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HOiKEbsX3W7Wn6rrUabgXgSl/FH8a4bpyVPanvkXTAM=; b=guCOOPQ5OUS3BbmIFG84n/5vFa4WxXJ6qu3Kc9iJOokZaEw06R5oouJd4Sk4P5cUeW Gjd+KbWCe1CAKplCRy0YfM9cgaxfd6FHcZUKXhMc3ymJTO7+S2zUOwv5l3Cnvt23TBNx IH+otjLF4aM8+2Jkss5YZYcQz2UMx/sJdXrwe179rhxQ/FuLNbYtnNWeZ89IhKUeBeFH p3ezi8OruDouP9Mep7k53L/eAdCqQU1g5zjBZx6115sFH3oDcLMBGD8J1SHx0vN/3E2k fAaAkmxwRNiNWYQZ481QwU6y3ooySfGPNiNyVovksLmkf5nLV8EN17NhFM0pi0TG+QF0 bUsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688158669; x=1690750669; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HOiKEbsX3W7Wn6rrUabgXgSl/FH8a4bpyVPanvkXTAM=; b=OofwqKu5iLeE7vR1Yw8NDQ5b5K5WBTgOJl5AgmtTqjVIYkHcUCc4h2q3f+c3jxSFfu Vcdz7gG6OWPaW0hqJtBspQrshJ35nfO9Ge8icwpVYGl8jvsmxVx/+Jubzano4aai7MID N8ZdvS2g/q1TmWuivYjWTCWrW+CkiWAuj95I6tLUvqlAZtK4oxp3tqT3ChybkZV7pNLU vCecm5qNk2otikykZcG96Mp0kDIsjRkTEqSPMCtzzBm3J7VwkYcPvIpNFcA2FE+36xHq 5Ij2V16CcDqDjSomqI7suuTGuEgNieheEDAHFkDof/92kyjtCmXZLosRQ7yq+tbbj9Xp wung== X-Gm-Message-State: ABy/qLaBGEsJd8q3ws9dakvnXweficoYhzmH/gj6zK2ZrdN5udbTbnkc LMB/c40Hjx19nnftTdg7UqTxfEzPgFw= X-Google-Smtp-Source: APBJJlGQeZpIX9hpoxLE0IZHuNTh3epkkD8+vsxunLptfVmutp5sjH8HmX0qxd/WsyLLYKa/oKNnwg== X-Received: by 2002:a17:90b:3e86:b0:256:807e:6bd with SMTP id rj6-20020a17090b3e8600b00256807e06bdmr3032528pjb.28.1688158668873; Fri, 30 Jun 2023 13:57:48 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id q9-20020a17090a2e0900b00261139fd67asm12881626pjd.36.2023.06.30.13.57.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jun 2023 13:57:48 -0700 (PDT) Message-ID: <7dddc670-0eb4-7a20-5c80-eefc3741ea45@gmail.com> Date: Fri, 30 Jun 2023 14:57:46 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 01/14] Add support for the Zvbb ISA extension. Content-Language: en-US To: =?UTF-8?Q?Christoph_M=c3=bcllner?= Cc: Nathan Huckleberry , binutils@sourceware.org, nhuck@pmull.org References: <20230629171839.573187-1-nhuck@google.com> <20230629171839.573187-2-nhuck@google.com> <66c6fcc9-95f0-fce4-75c9-68d746aede50@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/30/23 14:29, Christoph Müllner wrote: > On Fri, Jun 30, 2023 at 7:51 PM Jeff Law wrote: >> >> >> >> On 6/29/23 11:18, Nathan Huckleberry via Binutils wrote: >>> From: Christoph Müllner >>> >>> Zvbb is part of the vector crypto extensions. >>> >>> This extension adds the following instructions: >>> - vandn.[vv,vx] >>> - vbrev.v >>> - vbrev8.v >>> - vrev8.v >>> - vclz.v >>> - vctz.v >>> - vcpop.v >>> - vrol.[vv,vx] >>> - vror.[vv,vx,vi] >>> - vwsll.[vv,vx,vi] >>> >>> Signed-off-by: Christoph Müllner >>> [Updated to newest version of RISC-V spec] >>> Signed-off-by: Nathan Huckleberry >>> --- >>> bfd/elfxx-riscv.c | 5 ++++ >>> gas/config/tc-riscv.c | 13 +++++++++ >>> gas/testsuite/gas/riscv/zvbb.d | 43 +++++++++++++++++++++++++++++ >>> gas/testsuite/gas/riscv/zvbb.s | 34 +++++++++++++++++++++++ >>> include/opcode/riscv-opc.h | 50 ++++++++++++++++++++++++++++++++++ >>> include/opcode/riscv.h | 5 ++++ >>> opcodes/riscv-dis.c | 4 +++ >>> opcodes/riscv-opc.c | 18 ++++++++++++ >>> 8 files changed, 172 insertions(+) >>> create mode 100644 gas/testsuite/gas/riscv/zvbb.d >>> create mode 100644 gas/testsuite/gas/riscv/zvbb.s >> This needs appropriate ChangeLog entries as well as an update to the >> binutils/NEWS file. With those missing pieces this will be OK for the >> trunk. > > I will provide that: > * Adding ChangLog entries to the commit messages > * Adding a commit that updates binutils/NEWS > > I will send a new version on the list within the next hour. Sounds good. Feel free to push them yourself. Or if you don't have time, I'll get to them at some point before Nick branches on Sunday :-) jeff