Re: [PATCH] RISC-V: remove indirection from register tables

[Jan Beulich <jbeulich@suse.com>]

On 12.08.2023 04:00, Tsukasa OI wrote:
> On 2023/08/11 22:18, Jan Beulich via Binutils wrote:
>> @@ -575,14 +575,16 @@ enum riscv_seg_mstate
>>    MAP_INSN,		/* Instructions.  */
>>  };
>>  
>> -extern const char * const riscv_gpr_names_numeric[NGPR];
>> -extern const char * const riscv_gpr_names_abi[NGPR];
>> -extern const char * const riscv_fpr_names_numeric[NFPR];
>> -extern const char * const riscv_fpr_names_abi[NFPR];
>> +#define NRC 5           /* Max characters in register names, incl nul.  */
> 
> I'd prefer (4+1).  Otherwise, it looks okay.

I certainly don't mind switching.

> I also would like to hear others about the naming of this constant
> "NRC".  It's short and not bad (even if unchanged, it's okay for me)...
> but I feel there's a better one exists (even if it's longer).

I'm certainly also up for naming improvement suggestions, but to be
honest the longer the name would get, the less likely I would be
willing to agree to switch. Of course in the end it's the maintainers
who have the final say.

Jan