public inbox for
 help / color / mirror / Atom feed
From: "Martin Storsjö" <>
To: Mark Harmstone <>
Subject: Re: [PATCH 1/2] ld: Add --pdb option
Date: Mon, 3 Oct 2022 21:58:19 +0300 (EEST)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, 3 Oct 2022, Mark Harmstone wrote:

> Hi Martin,
>> As I assume you're aware, lld's mingw port also supports PDB generation - 
>> and the description of this option also sounds like it's chosen to match 
>> lld's option for outputting PDB files - that's good!
> Yes, that's right. One notable difference is that the parameter here is 
> optional, unlike with lld, making it a lot easier to fit this into e.g. CMake 
> toolchain files or LDFLAGS.

LLD also has got that behaviour, since 
in 2019. That's in particular why I wanted to make sure that this case 
works the same in binutils too.

> It looks like the equals sign is mandatory when providing optional 
> parameters, otherwise it interprets the filename as another parameter.

Yep, that's the case in LLD too.

Unfortunately I didn't think of this behaviour initially when I first 
added this option - otherwise we could have had e.g. --pdb as a boolean 
option to just output to the default name, and e.g. --output-pdb=<name> if 
you wanted to specify the name. But oh well, "-pdb=" works, and I guess it 
isn't the worst thing in the world.

> But it does mean that the form "-pdb=out.pdb" will work on both ld and 
> lld, which I think is the most important thing.

TBH, I consider the "-pdb=" case equally important too - that's what most 
people would use in the end.

// Martin

  reply	other threads:[~2022-10-03 18:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-03  1:43 Mark Harmstone
2022-10-03  1:43 ` [PATCH 2/2] ld: Add minimal pdb generation Mark Harmstone
2022-10-03  5:12 ` [PATCH 1/2] ld: Add --pdb option Martin Storsjö
2022-10-03 16:57   ` Mark Harmstone
2022-10-03 18:58     ` Martin Storsjö [this message]
2022-10-07 12:16       ` Martin Storsjö
2022-10-09 23:46         ` Mark Harmstone
2022-10-10 10:27           ` Martin Storsjö
2022-10-10 16:55             ` Mark Harmstone
2022-10-10 20:58               ` Martin Storsjö
2022-10-05  4:20 ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).