From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5B4EA3858D37 for ; Mon, 15 Aug 2022 12:22:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5B4EA3858D37 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-336-GaKiqJqpOsieCfmoxwZ8Ug-1; Mon, 15 Aug 2022 08:22:06 -0400 X-MC-Unique: GaKiqJqpOsieCfmoxwZ8Ug-1 Received: by mail-wm1-f72.google.com with SMTP id j36-20020a05600c1c2400b003a540d88677so3622153wms.1 for ; Mon, 15 Aug 2022 05:22:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=DNbOc1DTU+AzPZ+SPcZjh+0L//rdBo1aVlOPNYEUtLs=; b=gGRoiCdVpH78lIdFD7DWv0IYKqJyrxMNu0ZEtzdxdO2XojMsay4CyQ5e7vUqeITABT TlOlh/2jdL8OxuSmnftc2VMEvMo5I505MgECtSBr3IaCWqkSPZXu6PiTHqwbYimY8W7j cAK3VRhGmdora+r0FBkVQnRnODpq+P95mtGJs+Prh03FjRH49nbE3iVPKdWi3RhL7q3P cCHf1CZNWz4QtuKpS/OSlk6tH8EVE6hQ+gav+H9yZnBu/XofmUqxn6aQ4nzD2RnvU3wI D+GFhiGkm6YEtM1/+pXMArXkqXNH7QQISyTHuDyzmj9Nmnuia2bO0Jx1+yoff5WDDeSm AS5w== X-Gm-Message-State: ACgBeo1RTho1v3nmJFQRmFsb1m1TfwrPO5eRknErYMcSNfvYAO0NvMBQ oJ6uyAFJQJs4iMnFf6SB41OArftM1Nx87K2MgFHgKqMeXbGIT2k5a690XjL5cbkxppuCWDVk40n gmztE/BPOgElEvbetLA== X-Received: by 2002:a05:6000:15c5:b0:220:727a:24bf with SMTP id y5-20020a05600015c500b00220727a24bfmr9014959wry.621.1660566124475; Mon, 15 Aug 2022 05:22:04 -0700 (PDT) X-Google-Smtp-Source: AA6agR6odH9BmfX/BVYUgXAseOD74H9aPA9YqOUQFoRii8R0YzDxMypHP1XwAPEG3/khQm/lhoQzZQ== X-Received: by 2002:a05:6000:15c5:b0:220:727a:24bf with SMTP id y5-20020a05600015c500b00220727a24bfmr9014951wry.621.1660566124333; Mon, 15 Aug 2022 05:22:04 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-236-177.claranet.co.uk. [80.168.236.177]) by smtp.gmail.com with ESMTPSA id cl5-20020a5d5f05000000b00224f7c1328dsm5586699wrb.67.2022.08.15.05.22.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Aug 2022 05:22:03 -0700 (PDT) Message-ID: <7ea8e16b-ec41-37d2-f684-3760e43f415e@redhat.com> Date: Mon, 15 Aug 2022 13:22:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 To: Indu Bhagat , binutils@sourceware.org References: <20220802080452.1143351-1-indu.bhagat@oracle.com> <20220802080452.1143351-4-indu.bhagat@oracle.com> From: Nick Clifton Subject: Re: [PATCH,V6 03/10] gas: generate .ctf_frame In-Reply-To: <20220802080452.1143351-4-indu.bhagat@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 12:22:09 -0000 Hi Indu, > +bool > +aarch64_support_ctf_frame_p (void) > +{ > + if (aarch64_abi == AARCH64_ABI_LP64) > + return 1; > + return 0; > +} Given that this is a bool function, it really ought to return a bool value. Either that or just return the equality: return (aarch64_abi == AARCh64_ABI_LP64); > +bool > +aarch64_ctf_frame_ra_tracking_p (void) > +{ > + return 1; > +} Likewise: return true; One other thing that I found was that with this patch applied (and the 01 and 02 patches) but no others, there were several new failures in the gas testsuite. This is not really an issue as the problem is obviously that objdump has not yet been patched to support the --ctf-frame option. But it does mean that I cannot perform incremental testing. ie apply one patch, build, test, apply the next patch, and so on. Cheers Nick