From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2062.outbound.protection.outlook.com [40.107.6.62]) by sourceware.org (Postfix) with ESMTPS id 6A8943889E06 for ; Mon, 5 Dec 2022 14:09:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6A8943889E06 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fY/MBYtSYMOaz1c5gm/oiCGhe/cZy78LfqDA35jPzSkZK+Y8fmWoXs3MLH7WCvzR/sd6R1G+djq+a2UGxze3Rf8K1IOP8r+Q9OHkHrG6vfXpfVaAM6J219N08T30C+IrW4pBfn6rtfNLqSRbUsgbREoIrchvTzRcz0LO4tG0l62OBPd60G5caeyqFivSGCHkHm2PzyK761EMMkEWCXlqr/kmkp7jZlxkkrSe9TVlcIQVeKtfviwwOMIo18Hre+9uy3VrwqWLaHlTjNY5uRcb9spntAqLdk9IBv9OaYh6bH3v2ksq4qWnuYrP35gwqrrdfwNIm3abT68GdzE7h8pxzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6vr+MO5/TA3IBMHN8MZGQ0kB7wBw8LQOcAbDHuod5UY=; b=FGDCtbI1Nz/7XRK76DlmV6c9hUcd9+dWeudwYcEui6bK9AC3n+Lpr0F9xgM6BgVKQ9LRC9plnePPr1BxU7RT9kbKxe6r5ywQeqatTDAh0n35P1AXCQuoFwCzS7MbpHto08oDlMcDCscGSozJw22bvfnTAeWk0up7GpUzLwOnzH8U/AkV7Fjv05Z1zJtJJ30/iyaQJqs5Q+YqKKdyPF9b/X5u/gzt9TodbeehGs8ukzS/jGa0AI4qYdNZoP9Wx3MRjFTfdbay9Jue0XvqxUH41VtcGTVF9zkRYLd9Mi2efYrosbIWn6TFB7ULMGOF3+l5Ao9Ybp/2igBanSOzSuQtIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6vr+MO5/TA3IBMHN8MZGQ0kB7wBw8LQOcAbDHuod5UY=; b=5P8T0g1S80uJd2gC63FwoNXPtqJZEpCtzTls1gTgLMl9iZD3whLxml2w+shWkDco3AEZfPO0sv8OD2G6Qc0X1KW31Nff/TOCa9fmJtUhRuJaLhzx/CVC07tif2/LIzddAlIx+odMrn+eUw6FatDextVW3DfyL+4cYGSivdSzhEUCUj16qrgTt8/kIhWPQdgQBhWLpft61uh3l6uGPJbAqlgAWV92jXO8mk6lhdXqbxtMeSuY8R5x7iUEoNr6+usdef2utjz7XzWLpXHRpsZvZYnBc1Q5rrKLqRnbKpzAWu0XDLjDIVMMi6PJmZ7iGXRbsnXNMPHzK6wymKwcE3CBTA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8309.eurprd04.prod.outlook.com (2603:10a6:20b:3fe::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.11; Mon, 5 Dec 2022 14:08:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5880.014; Mon, 5 Dec 2022 14:08:59 +0000 Message-ID: <7ed64ac6-3719-eded-bfb2-59fa794e7ade@suse.com> Date: Mon, 5 Dec 2022 15:08:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH V2] testsuite: support mold linker Content-Language: en-US To: =?UTF-8?Q?Martin_Li=c5=a1ka?= References: <83618407-1683-8805-58d9-c7ac27263ddc@suse.cz> Cc: binutils@sourceware.org, Jakub Jelinek From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0185.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8309:EE_ X-MS-Office365-Filtering-Correlation-Id: 63d6cf1f-60e8-496f-542a-08dad6ca4161 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DQhzIBRnTvM1e9bcF5w/NNA8h5IE+ramWB5r6RaE7veEr/zweu5G4dTlHMp9jv6ZJ/gjYASHEhRui3OFd0dngKfY83qDCKeQ2dQO6gBSWisXhZhzreal+X6sBWmUu22pxOOapn4sCH3WaJgd+vmDkY8K3oXiujDWzuGJNiZ128KV6D/BLGD0hlPJHsUhi61DSeQ8rbKay+TvLg3Xfjk/qQJ+Fl4Sjkpte28pupsmb10SpA3S7tb0iCdOa/FOWmfopOgCs8yPfVOuRNY5Zhp5VjBW6B45pwkZaRsAMTydP6UOTnVJQIJBB1Colk7uusw+AuBo+1jSVJnZmizan4R/C3+97TBfdUYZ8zo4yDdnbjlFQ/vXRZ2oEWPGfPsIn/Qo9feG1HMGtQpzRRpPEQTa3u/CdP0ND/PikomW4j7t7UH0zudau04nHMbT3LRB6ouH7r16VDTiCc3CkplyHG6XRoqj2BCiXyn5xNoNnc4r4x4FhjoXom3TZPeK5OHpFf6dBFHXEL9r77B2t5DOa9fF1Kj5poD+D1M+nCaB87G0+KwgQEY5G+whdCYCar12Wut5JM4+NwY8Kp9p1EKifEWQ96xvIdKh2weLLF7WTdSG9YYmmJUYzBi+Das3CgYK3RJ9CrQAOaLyZy2rFY9dJ3VE2IR8WTX5XjO2yuRaMGYvOFh3izuVAdkiJhxjsRjdyera7RE0CSR+8SGkzfn6Ghyn2mQLofWI2F+z2NrIfQCGlbc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39850400004)(136003)(366004)(376002)(346002)(396003)(451199015)(36756003)(31686004)(86362001)(31696002)(4326008)(66946007)(8936002)(2906002)(66476007)(8676002)(41300700001)(66556008)(38100700002)(478600001)(2616005)(6916009)(316002)(6486002)(5660300002)(186003)(26005)(53546011)(6506007)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGxrRStqdTNlSjhPdmU4QUtQZ0VwNXZIYWp5R0k4ZVpPYzF5em12dzdqUTlp?= =?utf-8?B?VnZxMzBkdHVuYXBWT2lMZWtsZ2pXZElPNUwvVWJlb3p4MTFibzRLU0k0Q0pI?= =?utf-8?B?ZXZKMWdQWXF4L1Q0bXZqL3lBV3pzOURIQ0w1VUxyWVY0d0VOVG5CenBETXBn?= =?utf-8?B?MGMyVmxKK2tubnowZVlxREdyMm1rL29iZmFNSnhjR0h3OXpnV25WNHV6UzlD?= =?utf-8?B?U3lwSmtsZHo0ZUR1TjE1V3Q4WkZySFRvWlFTVnZjNVQ3S1BzaHU0R0ZYNkFi?= =?utf-8?B?VVk2QkNYZmpIOEQ2S0pmRm1ZazBZMmw3UDdkbEFSTkhBYzB3WldCeU4wcGxn?= =?utf-8?B?VlQzaXdPTXdiYkpaL2svR1NXRzhhaGcrdVpBSkhFV3hsWXVPSnJtYkxDN3M1?= =?utf-8?B?U3JpUHJxODBzaG1jd21pZmdaUUJYTWhxbVJLTUJSZ05zelhKMnBlS1JBNFVG?= =?utf-8?B?VElXbFd0MHB1TzhEOHRNQTdSNEgyRVJsSDN6RzJISnhHVnN6d2MrTkR6OElH?= =?utf-8?B?T1FpTkdEQmlHZ3lNMzUxYUFzVHk4NVVHTys3SmhTUnVDMmdYazM2dnhYd0VQ?= =?utf-8?B?Z1dRWUFxK0ZwemNtYzlvV1gwSFQzV09xSSt6RFpkL3JZZGI5L0NRUEhyZzVB?= =?utf-8?B?SzVJcVpZNWRRTnI2TXBlV2ovRkdVRGZxSCtZT3NzV0VuRDM5R0xTeG1zK3hL?= =?utf-8?B?Ty8vN0xCYXdVbXhDK0VjYlpwRC9OSHNmM2VHaEJDeERjeERueDk0YURMMXg1?= =?utf-8?B?WGdIdm1ueUFBekF2TFU5NHZ3V1VPZ21kcnZDVlE1cml6cmNnb3J5bnhUY01w?= =?utf-8?B?elRpZ05lNUpmU2Z6djhIWUNRamFRNEFJRFRRdnZvdlZKSmJyUlV0c3h1YVc4?= =?utf-8?B?MW90UzMzbzZqdjgyUHROK3dwZXg0NDJrR2d5VWVFQkhSN3VWbS9EcXU0K1lw?= =?utf-8?B?MDhiMWhBL0pSbjBrSnVjMzFheW90aXkzcExxRjFkWVBDKzc4Q0IzRS95K2dy?= =?utf-8?B?cFV4WDBJL0NreXFsVzdSTU13VE12SEZTclRMY29ySEl5UnB3MFFrS2hpQlI5?= =?utf-8?B?dy94SDM5anhpQzR4aDk3QVJSVllBQkMvNXNYYTVmY1d2K1k0OGFqRnFkOXda?= =?utf-8?B?Nm9RRU9Wc1NGZk1aWmxHeFF4RlY5ZENmK2dDY2pGK0pkL1BDNllCVGZ5U2lj?= =?utf-8?B?bEZ0UjQvTjVEdmFSTHdUL1RhOURvZENweUE1bUV5ODh2aWxIT2NkT3MyUHRQ?= =?utf-8?B?Y2drS0RLbW12RldVZmtjWFArYzVta0h5cUxPNHpiQnFRSEhRR3ZiTHFMNGl0?= =?utf-8?B?dEVsTG00cnJ3cFJiRlNDY2NiOHkrMmNaZlJBdTF4dGFUOVJnb2IrMzhsSCtE?= =?utf-8?B?cUplaXBjQlRUL1N3a1FpN0dhMVhzZXVlVDArejJFVUh6YXlzcU1Hc0tIS2xx?= =?utf-8?B?ZlAxYmVLZ2lJUGVSOFNmSXN6VHIydFFFUkFDZ20rQm52VHZTeWZtV1RKTTFB?= =?utf-8?B?L3J0WnR6ZkJYYlhxbzJROTFkeHhWdkR4TjdHNjVaNmpVTWVxNUZDQlQ3dG02?= =?utf-8?B?cTlIZm1Gd2JnTzR5Wk90RzQ1VkZXbERjbEhOYzV0NWRuR2k3dTIyOHVZTWRy?= =?utf-8?B?MW9ubEdKYm5zRVJGUVBNeWNsRmdqWWIvOW9qMTNwWXJubDdIdWxyWDRMdmI1?= =?utf-8?B?M1hXdThzTE9BYUwzZFVZQytOcmphMzVGTE1GTGVHQzV2WE1vSGJ4anVhMHFK?= =?utf-8?B?TUFlNnBRZG9kbms4eS9xNkpScHBoL2t1eGFSYUwyaDhlOUdoZDBYcGE5ZmI4?= =?utf-8?B?akY2b2lxVDFaSk05TFdaWk43S1hlc0I2WERYVG9GQlRxS2EzbHBEMnBXMDJj?= =?utf-8?B?MkpFU1NzUGY2bEFFa1FDSFB6cEpKQks1SWRDMkRVV3o3WWFIL1lSWk13NVNY?= =?utf-8?B?OXB2ZDEvbVpOdmpLdzcrTFhLcitEYXlIcS8vQ1RTaTU0YnVtTm9EVEZrL2to?= =?utf-8?B?cUpqczBzRWFaaHc3MUgzWmlYbUxyOXlUV0dNckgvWW1TaU1GZVhta0VTMTJl?= =?utf-8?B?enZkZzFmYlFoVXNPS1NTYi81eVB1bEU4NDI5Uzh6dUxWa3lYOFFUbGtuUzF0?= =?utf-8?Q?bnixS8aSTj/vXq5e4+ajpaLly?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63d6cf1f-60e8-496f-542a-08dad6ca4161 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2022 14:08:59.6388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pfdlAG+1ALHdLWRPMN0pV2eLqDoKPyV9WlVYrkjZNPyIJTqARMmxCZGDjyGe2Dw6MkqMMOklBHbGJ6DNcEHuYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8309 X-Spam-Status: No, score=-3029.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05.12.2022 14:48, Martin Liška wrote: > Mold linker demotes symbols like main to be local and the patch > adjusts expected output from nm. > > Moreover, simplify the patterns and remove accidental type 'D' that > is supported value for _?main functions. Hmm, in my v1 comment I've said "accidental" to the difference, not to the presence of D. In fact I was expecting you to uniformly use [TtDd] everywhere. See also adacfc818440 (sadly without any real description). (That commit is also where [some of] the odd ([...]+)? regexp constructs were introduced.) Cc-ing Jakub in case he recalls background. Furthermore I now even less understand ... > --- a/libbacktrace/Makefile.am > +++ b/libbacktrace/Makefile.am > @@ -498,7 +498,7 @@ TESTS += mtest_minidebug > > %_minidebug: % > $(NM) -D $< -P --defined-only | $(AWK) '{ print $$1 }' | sort > $<.dsyms > - $(NM) $< -P --defined-only | $(AWK) '{ if ($$2 == "T" || $$2 == "t" || $$2 == "D") print $$1 }' | sort > $<.fsyms > + $(NM) $< -P --defined-only | $(AWK) '{ if ($$2 == "T" || $$2 == "t" || $$2 == "D" || $$2 == "d") print $$1 }' | sort > $<.fsyms ... this part of the change, where - as in v1 - you add a check for 'd', while a check for 't' (which supposedly is what you're after) was already there. Jan