From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2049.outbound.protection.outlook.com [40.107.247.49]) by sourceware.org (Postfix) with ESMTPS id 9C074385841F for ; Tue, 25 Oct 2022 06:44:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9C074385841F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T4LyDo1+JzfkUpLylLd0DeceuOB7mmQV8o87yZNLCCQk0aX5AKhzZpFBVYLMMKaM2junb1WuCm9l8mYz1d0ZfPLIsdlQwoR8NRQL8C9zQXcTSkU67tKlVhS9Q+gZu7RFFbHVn5vyKwVkdGypHlhOzZbEeLvlbtXRdvfCkU4McIb/d+DSjNZ4x9ScOHIKeT3Xjyst435qg5OTZWIVP4DpBOHngoi/McS/sgSJkE2oNLGg6iX5yaQfIT1enmt+YVr4kgmixFZLMWDnGZ8BoC0WxyQA0NEXf11kIvQm3/UBNi8yWajHo1eGJqRCeTUa5QAh+wnu1rBGxGjt+9Pi1pMaZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sHmFK/Km7vR2C1FmwPyPnLaWhzxD3VDrUiTsQfVEsuc=; b=bthqNYT3a1YZap82L2Adtz99tixLC2IOye2wU4pidgop1X7Z9rmAJUCbG47V0CrP9bExmsnYuN0OaOztEoG8jwU6Xq2QaiJENfLo1RhfE54/cAHH/DAvsalYRB0VQy76IyWgSnZULMtnyCkShd+N9waMYDiXlJ7Nso5jLSITzB9UdkQkEvYdwi6Pz+KcXKSp4cYVi5qmlVgAIZROVkEVlEIvcTXHm7+gWnaPiWqsau4gFrEaFgc87UGH/QfyHzNoeQE+X2XuLmWf0YLo9pGVS16pLfMxGtRss45HeVODs3vZjPitUoW9OkEtjUQjORk7X7MaCoj5mQmYsNXf6TmGog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sHmFK/Km7vR2C1FmwPyPnLaWhzxD3VDrUiTsQfVEsuc=; b=I1KL9m6K/oN6M6BytiMLQwQTVDyxzX0q+Vtx17YFLmJht5B3flL4fkyP7wyHaXrrazf6dAfdVlLCOYlZNB4gK5GomDJMOCwrZRs6iNnGNJofHJEIpbwQj5LMs5WtnUsMUY6ZyZKwV5vPHguqB/hGt22L4avO7haEwuoyl41G1O5Zb5LXhYwC4JpomZA4OdNFuDyYJxQb5/tyn0GkKOoquV7mfZeY+r9fuIQh7s/ZhBMTj2uPkRLvBvY7Mdy3U+rA2pNb/gmSkHUVlZHnKjbICNOfLHNxNQlUwyKDvz0ZpOZT90USKHz12rc+jLj9BVULcI9yJRkC82huBTue6yoQhg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6826.eurprd04.prod.outlook.com (2603:10a6:10:11d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Tue, 25 Oct 2022 06:44:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Tue, 25 Oct 2022 06:44:33 +0000 Message-ID: <7f283304-7953-3b37-d36c-a90643dfc146@suse.com> Date: Tue, 25 Oct 2022 08:44:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 03/10] Support Intel AVX-NE-CONVERT Content-Language: en-US To: "Kong, Lingling" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" , "Jiang, Haochen" References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-4-haochen.jiang@intel.com> <29239b15-58d7-c57d-caf6-a23c40814f3e@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0085.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6826:EE_ X-MS-Office365-Filtering-Correlation-Id: 03867458-225f-4988-1834-08dab654601a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ls0XBzYv2i+vTBYMM4RNzwMbdgvB1LN6mCGKVcZ45DGg0b1ci7PerNS+0CGkx18LyQIxzzBhqBakzc937mYIaUnBy+QT6+ymVFqgsovpLGWge2VGyyOKbTuWw3fCQNFs7HZ3Vd3mWfoxf2fqKpuYmk+rr0e7tCxt6ZTpus1RSCe8wI/60+9F0dtrtHoabdCjiFSOt/TMhgNue5O1up4cAjIrpxJl4AuduTH7aZe0CASyjcOcNu8+1c0mE/plDp5pqk3A0dJe6tDEzJhZHmVigcsz9CenpSfPuoAhgUo9bhOMi8SsZwtXN+KynwdfmkWigRNJpVayuA7diyh8plAVac4lYa7pyj0C+GeCCW7dybAGuiX/rVdPjowv8P8qyuuIUECX9uaI+lIyKzHVsiq0EgW5KmfDC5I+If5iK9zQxJ8fzFYS8GT2VuVimt0xDHKannQpRGjEUJ6pYQfxXbCSitikHoumEF9PResxydFLoXPB5RfZfcBECdQ8DAyGQZxrZ7lAQA3aYoMbUh7vOKfZp+qSXsiszd3gdAeBEA9YoVdTp4UWC2vTuI24xYJaYVWtRwLu9dUhRB2+zsOabtzGWP2aaQ8mEwERGigZHlc62H3Bhd2V0zllu+7XfU21Eu6TR6nSAmd8REdMwDWpjnVHRPUEfIUkKFNaXSYcCvj9lEzReFzdcWjxKsD6K/KGMw0UzdFijWj42d+xJ6sA8g5g8ibC9hPecnLeElNU80MZTHaNLXzAYGJFDiX676Vo34F2Rz2TbwLLm/WMd9iGwNYAytsh/sNIcEiHXtlSUeIs9ZQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(346002)(366004)(39860400002)(396003)(451199015)(186003)(2906002)(36756003)(31686004)(86362001)(38100700002)(31696002)(83380400001)(4744005)(54906003)(6486002)(6916009)(6512007)(6506007)(41300700001)(316002)(5660300002)(53546011)(66476007)(4326008)(8676002)(26005)(2616005)(8936002)(66946007)(66556008)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2FXMldHZ1R4aHo4TEhMNk1jMnk3WGx3RlB0Vmw3cCtoeUYwK0ZZaE5IZkpa?= =?utf-8?B?VWhNandTLzY1UmU4ZHo4SzczV0VMN1prOFdyQ2IxTW05R2dvRC96d09KWEJv?= =?utf-8?B?bktoS21SQU5GWkcvVEpSejd3SG5hNGUyYzlwTnJoR3pxSlo1b1RZRWNoR1Nl?= =?utf-8?B?N2RwdFZYbWNSMGtJLy9qZXV5OUJ5OXNrVUFzNThSYmVwaFhXa1g5cVhCdjh4?= =?utf-8?B?ODduNmVjSmlCOHVqMXA5WWFldmEwRVVvVnVwWkdJZ1g1VkxXK20xUmFJQnJ1?= =?utf-8?B?SDlJV3RCc1lYZWd0K0hsZmtTdFpVZUI5WlkwSWFNclJnYkNGcUsySDFpMjhK?= =?utf-8?B?dWFyNjhSVkFycjUrY29Qc0IxNzMyTVlITitSc3hKa1lxN2lFRWNTY043V25z?= =?utf-8?B?aSs5SXk0SEpsNGg3WnZ0ZU5QVzZGejUwdHJ6WEcrZzJEd3psc1JTNXFMczhG?= =?utf-8?B?MVh0Y0phNGt3OU85NHAvUy9kbmFmSk5pbjJxTi9QSDlkRVI2OWprM0N3RG83?= =?utf-8?B?b3NEMm44amNNOUV1c2toUm5nYTRZZ0tGdXZFWGJSaDZldUJuc280VFNJa1F0?= =?utf-8?B?VVBreFA3VkNyeXJKVGp0b0JucGZuU0FTaHluUmVVdUc1TDlvMlVrdVliWk5r?= =?utf-8?B?UEZZdElHb1JaMFFJdjZnRHA2dDBLNmlKcnp5T1FwMmpQVm5HN2NqTWk0cmo1?= =?utf-8?B?NkR0OTI4VDJPaXRTaktjdjg1VDVHaEFiK05keDhQL1NSMXY5anltczJkVmQ2?= =?utf-8?B?VmdIei9jQ1Z4a2hBa0NDOUtaV0VpcnBTTGF1QWEwVEk0RCszViswQkovcUxw?= =?utf-8?B?U2Z1aTZUS0RVVVdYK3h1a1o5TjNSY3FBR3Z0SU9DbWdidmw5L3dKZnhiOHJj?= =?utf-8?B?WnJMcUNEdGMvbHdlTHJiNVNkRlJZRWJ1RXlPN1Y0Q1B1NjBJcnU5QnRoQnVJ?= =?utf-8?B?dFdoWG0vZm1RMU1lL1ZvVWZDTHlOajFjUko0ZmE4MWdaNTViRTRKZEFHMWhq?= =?utf-8?B?K0I2ZFFGdmdwQ3JreUtKamZnNmhlN1lySGxDUzQwRlluSVRvUkRlNzRXbXpN?= =?utf-8?B?RkV5b2hvSk1hcW5pZjhzTWJtb1VoTjVLSXYyM1hQVmZVSGNNTWo3QW1TaDk1?= =?utf-8?B?SVBVeEhtVkJnenZkTEtVa1orcW5lZzYwRUtMdTNZRmI1Lzc1MXc0L0pDejg4?= =?utf-8?B?ZUVDK3U4Ym44UWhNejdSYnBzdHZsMnZpdndOang1bldFc3AwRmJrQ1g5bXRE?= =?utf-8?B?Uk90aENxMVZnWE82OEVac3V6K1Z5UW5pb2xGZjFNM1cyWjJUOG5OUTBPY2pO?= =?utf-8?B?dWJPRDRXekVQeGZCeS9jY0JYK1BJaU92dlErTW1KQjZpNFVVQWx1RHBTUEZu?= =?utf-8?B?TGxyODFSdUZISjBjWllva1BUc2hhODFRQjZFRVBIUmdIN1JMVzR4dTBVOGc3?= =?utf-8?B?N01BeDFpTG9EWkxuNDlKMDhpM2RlNm9uQVloWS90djdCT1dUOXlPVnBmWEEw?= =?utf-8?B?elhqdUptbzNnWFdIaDNoNTE5Z1VxNWZRWDZwRGF2MGdIb0d0NUg4NFRSK2lv?= =?utf-8?B?SUloTjRMb0ZaeXprUSsxUStydWZEZVYyN0MzRldkZzVnYThlWDhJejFHWGRm?= =?utf-8?B?S0dKd0QzWDhoVEJYV3ROQ3o5WlZTNkdQQVhTTHZFNkIrb0VIZnRTWkpNNkJN?= =?utf-8?B?QjM5S1lzT2M3YVdQZmsrMjRKeWJZbk0rdVpLTVhlNlJFNkpFT3VKTWxSUjY1?= =?utf-8?B?VTI5ZitWTjRydHRVTFo2YS9pL3ZuWXRPNENmNUtORkU2bjFGbmZlMGpvTjJV?= =?utf-8?B?TlZmTzdJOWFOK01nMlRpNCtyZkpnYkZhSFRGbVJndFJNWXdUR3RsSXpVdmlm?= =?utf-8?B?OGNPMHRoSVRXRElaakNmeitTWm1oSm42RUxocFF4TzBwMkZtVy8zRWNzb3dh?= =?utf-8?B?VUZwVlhpVjBnYTRQYUxzNm9CN296aVlUVXJrdE91dE43YlgxVjFDVEY2MHVP?= =?utf-8?B?bTdHL09ZNVdSSklSdnFUN2l6Tkc0N2IyOU16WmNwZ0x4a0VRV2lrbUs0Nkp4?= =?utf-8?B?VWVPTDBwMjlpOFRzY3VYVURob1ZYalk3MHlDSkNLQStVTWlKa1VnQzh4aGgr?= =?utf-8?Q?ddVjlCgz8E0n2mmDlQpjvBF2x?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03867458-225f-4988-1834-08dab654601a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 06:44:33.3739 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cZ3pqgud9HLd0A1UfJsmULr7gzERWPhYbwZAeTkhmE3G3COpAtmZs50rE2ILvjlsOVx1VDBZv1TGWLWyraC5IA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6826 X-Spam-Status: No, score=-3029.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24.10.2022 07:59, Kong, Lingling wrote: > Thanks you so much for reviewing this patch. I really appreciate it. For these review comments, I have made some changes. I guess the conversion to Vxy / Exy would better have been a separate, prereq patch. Like for the earlier patches - maybe better move the insertion in opcodes/i386-opc.tbl to immediately after the related, pre-existing templates? Plus vcvtne*2ps are all still lacking CheckRegSize afaict. And then within a group we usually strive to sort alphabetically when no other, more relevant ordering criteria exist (here putting the two BF16 and the two PH ones each next to one another might be another option, to make it easier to see their similarity). Also like said for an earlier patch - please send new versions as new mails and please avoid sending patches as (only) attachments. See my earlier reply for why that is. Jan