From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2069.outbound.protection.outlook.com [40.107.21.69]) by sourceware.org (Postfix) with ESMTPS id 98DF6385828B for ; Tue, 25 Oct 2022 08:31:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 98DF6385828B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ea/FxOeazMqFsTma52qV/gKJqiMGqn5w1DPQU8rqGknJNC/pXJEnhaPagZCleb7qsUWuml9Wlr3O9vxbuiiC3466N+v24sf+cJx4dX9xveQIWJHozE+Iz8K/gjRLKxJNbfBDYNeiFoUq5K91+s/Ol6Bj5ZfXU9en0v8gXrphhbOEwfPTaSu6Tu1vNQ86bZb3a6UluEilnZXjS269Wn0/bhD27/Or3IIuGLGiOMH/8LYgIPvcvEYaGnR7GeNTGZi27jDZ1mLVdBLD387XqIzlo8c45YegL8Q0nKI34bzJ1dpEjluS1yZCU2dkWUhKhOmE8IcISXMA8e4aXVyMjpYlSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KpZGJvgL97Hh7uCyQCUi22ooNPUJkesYNeYkyyDXWHI=; b=lFVXxlYwYV+SqaX7tV/5LzUPWbMtteJA7CZ2eYpz9YlM5ugG0voy19+XfrhSklPgwQNSrTQerFsdVsnIwHlV+ZRL2/DjKliLpsNmC4nSPlTyVDx8lia8tdC4UJ5jE2XYBq40mdWnmCFy7dVNu5eAWcWk2gJxzXxqZtco0l4b85yicLJrLQc+zoQMUufgx+JVk0V8UzgDMujLMp/VSRICOQQqhKsR1ly7kTgCjGFvwd7s1SfqJebjAcNajE8Ahfi/aX873SY/V4tQ2k6J3LqmgGnz11WuEMSuBkyzn1KxCb37Ly+o8nnyHhw+61qt0Kuw+S8QzTzTuGeJf3CN7i75Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KpZGJvgL97Hh7uCyQCUi22ooNPUJkesYNeYkyyDXWHI=; b=oGaPjGl8ImqRaQU8K4uiBesmI8KzrZ00BDG8uf/JXRFnUx/gBPk8UyNJHFGFcBw8pvBlfNJM3EurCw8P81xm7GMGssjmmip5Rch2TbM/Wa4qRu99A0LvMrAei3LMyAF7XCIohqS9fvjQ6VFkkK4DTTwBQdGMw8B4JPXS+TNDG+TioV+9rnX5syI4HH6fUHZVnwNtzFX3Q5Z1yD69/WmZrgky6prC/hQF7DyY415a0OvJV2WgHJpxbiKu3YXooPrem+LvlNH56A3dLOfxHJgou5OZOJCs4FX4NyPlyPPGpYqK7KZY09CA26nhVnaKJaDgdXG12sPC04iZk3sqmqQLzg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7554.eurprd04.prod.outlook.com (2603:10a6:20b:2da::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct 2022 08:31:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Tue, 25 Oct 2022 08:31:09 +0000 Message-ID: <803f4fde-5e50-1ff9-7dfd-f3009bef33d6@suse.com> Date: Tue, 25 Oct 2022 10:31:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 10/10] Support Intel PREFETCHI Content-Language: en-US To: "Cui, Lili" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" , "Jiang, Haochen" References: <20221019151534.45521-1-haochen.jiang@intel.com> <20221019151534.45521-11-haochen.jiang@intel.com> <0559bce1-34ea-bdbf-9711-f94ae5f6490d@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0108.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7554:EE_ X-MS-Office365-Filtering-Correlation-Id: 42c2abd2-7a65-478b-f109-08dab663444f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kq7E/UDie9UOxMV0bMKIBO6U0j0PmNkXjUnMrxRbwg6zfu11H2uDiNfW9GXEGBo5EBo/Gi3UX+YNE/EX1vLpcpXV13qGmSOCyLUs35+o85JiUz/fg8nWSmbyRAF6ANL395FbQW4d9HyGI7eAVkD7xpdtf99tgyVo9Cu8RPjS54cfu2O829+o3X8f3ccJ3CUY1PbB2doFuQ5X6vv7nq2sHbGDczOkgMzffwbbaeuvyS6/r+FzozNzH0pOzFl4khjCEwX0NIwgTGoCqNreQuGFr+NkM982b0VoPVn9rgKAPLcZS/7eXHfvXBXRfgfAsIPvb0GMmXMzyhE/+j/x8NunlGBCIvK/iqzWxUExbXLTN7C6Lg239WVMU2iNlBU29LBycYWpjlM67RdgCHMYfJkTm6ECuq9qGVLz9gt++jU2LM7UaIp5yoLxe/96IdpuXHI6pWHrLkVS7lJYmUEWzURQ6N8yTKDzu2MjRF6xrlmkz5r38gIBeL/RMhCNoqKEJOUDR0Nl8OH5r4nJIrtb2MN0iWVf0rmBtYVjD9Ai2X19ZkTFOB67BkFEpyfJjyBp3os+UpXRzeJ2DnPeFakyzv3/9nKnv303DstC1ladYAASS/C8dbleq6JSLUghVzjqwo6reE5jOiOxMUjYN4NAzlgDj/iuDTDiZGC7qVz+vQ0/Ud7twt4jsWiq5Gp7szGfOPYQxvBCp3S6ZIwSkkY1zUqECUveovKewvOfT0sDw8kzPsg0/mH5gTD7Hp7hOB0da4n6TbNS/W+mZqedTtCd8Ld0EjXfWnj9sKQUGnMxWupK6oQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(136003)(346002)(39860400002)(366004)(451199015)(6512007)(26005)(6506007)(53546011)(83380400001)(186003)(478600001)(2616005)(2906002)(54906003)(316002)(6916009)(8936002)(5660300002)(4326008)(8676002)(66476007)(66556008)(66946007)(41300700001)(6486002)(86362001)(31696002)(36756003)(38100700002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bk9pRVd1QkVJbHZmZis5SmVYYmZpQnRFZEQwUW9ZMXkzNytYZE5hZ1FUNHFs?= =?utf-8?B?OHh1eDVGU29hU1VPS1JjRks4NTJuTk1QdFcxVDdjZ2crWUJ4TmVNS1hGS0JR?= =?utf-8?B?Mkw4bkoyaFg3S2ZyZlR0dk1XME4yaExzOXk2OWFxM3J1WTBJQ3NTK29VTGxH?= =?utf-8?B?MHNVMEhhRlRWQ2JIRVFoTmthdE80K3dKQklFMFduMTk3TitITUMvOTFld2hi?= =?utf-8?B?U3hwOUtvUEw5QlBPckpKV04rY29rZ1U0Z3hFRStrL3EvdlF0RmtyKzA3a1lP?= =?utf-8?B?ZnVnZ0dDbmc1UWQ2TzBtNGR0Q2dsMC9aZ0Q3bDRvbkIvc3BNZXVEd0krYWxX?= =?utf-8?B?cmFyb2J6WUFKZFl2OVBOcUZ1bU44SWNiZDh5cFVCRTRubTVoL1o5MjdNOS9N?= =?utf-8?B?QUZvVVAzckFsUlpOMGxIdlRmTXlXMTVhWkRTcW1jaElzT25Wc2lLMzJ4akN5?= =?utf-8?B?NERxZDJkMGt2RGJCMFc5NTN4Wk1nRjN1aU5mR1ZRbTRpeWIrZWl1UGg5UjAr?= =?utf-8?B?Tkg1L1FiTUlEdjUyYnk5V1l6c2ZzNll3SFJmUE5OaTUwQ0ZQcWh3bmQ3bjlM?= =?utf-8?B?NElhaGNlY0hEZUtMWDR2Vk4xNzZWMjE0RmRzeC9ZN1FhOHNiT1YvenljOE84?= =?utf-8?B?RnNRUWVydEFraEx3R1haK3lKNURqMDRWWnpVOVh6RS9QRUhqeUdkZWR3WHNX?= =?utf-8?B?Njh4ZytyQXFlZXZ3cVlHZlZBK2tBcyt5cFM1Zm40ZENqVlVLbGNYUFZ3a0JI?= =?utf-8?B?TEI2TDBpY1pCNVZGSkcwcGlCMCtxaExweTl5cEtsdmYraGo0R24yNWlzb04w?= =?utf-8?B?RDNzY1dLcXlzZFlzbVd3WGhBVm5zd0hWM0ZNMENhUWxmS2hLZTliak5qTWVQ?= =?utf-8?B?OTZEekQyTkNpcUt0YlVBbll1OWhYNm9JNmpYeW9GS28yRTF5RWN0VzFpZVN3?= =?utf-8?B?UVo3YVZtVGcyNGYxODRpQnpXTVQzMlFXSkl3VWpnclJKSVM5Rk8wa0NvV2ox?= =?utf-8?B?U2NtdzltVTB2d2pDS3BDRjRwWC80dlJNSE44R3dMSEVsNGdNSjN6Tys2a2Vn?= =?utf-8?B?WDlGRjU0VmlMWGxITjY1UFV4aS9iSjdBSmxoWTM4KzBaZEFMb3l0cGRMMkNY?= =?utf-8?B?M0tGQ3VBUWNhQytLK3k2QU1iWFBaMGxOYnhYdFBIejVGMWJTTnZEVFZQTlpU?= =?utf-8?B?bW9QcGU3M3ZsbG9reHdsUXptRk5vVEhUMlZkTGc4aVdVTW01cytPbmo0TlNX?= =?utf-8?B?TTMzU25ZZWxMZzQ3bExucGxUbEpkRGc1REh3Slc4S3I1SFFJTnAwTDJJK2R3?= =?utf-8?B?c0tOOXE3UVNxWmZqSHo4alhlTmljNDBWUCthYkdQNkRVWHFoOE9aekdzYm5N?= =?utf-8?B?Y2FIWXhkeUl0TWxoOGYvazlhdm53SllsWUEwMXZoMkx1L005RDhyRzJEd2VK?= =?utf-8?B?S2t6SVMzTWYvMktzQXZEYUZoY3RqOWhROTBTU3pvRnFhZmZTZnNESGlLbUc2?= =?utf-8?B?QkllVnZXa3dGdGpqZi9VSGx4U0xDMU5lY1hBTXFRUTVQbk1DMHlPSS9PQ00z?= =?utf-8?B?NzF0d0FWYzVsbmg5RkpoTlNoQ01yZnhSb25PeVlVM3lkUUpXdkR5UFFab2J6?= =?utf-8?B?MXlqeHZBSGc2STFORlNZb2Jodzczb1BYeEhVdzJnQkVZOTdjZEwwZnk0cHlQ?= =?utf-8?B?QVJGejMwaFVnV1hxRXRjaXNTZWtqVWcyUzYvV1N3aVF5RnpMcC80dEdxMCta?= =?utf-8?B?OXlvZ0h5TnJxaGtlOXdMMTUxVEErZnYrOGFzUHdvamJiWC9kZjFmTkovNGEz?= =?utf-8?B?NHVYMURKNm9OTVM2Qit2WUJXQVpEYklET3hVdHByU0VRcm11aDM3TFo1Z2w1?= =?utf-8?B?OGRMT2pCR2Q0MHBIdGg1RHJzOUJ5VzVFZDd4N29CL0MvNU9oNk4wZnd4cUpR?= =?utf-8?B?WkExaC9Gd1p4RDBQbGcrNkpNMFUwTThLMGlPdnlvQThJTnUzdHJPQUZHQ0Fw?= =?utf-8?B?dlpPeGZLanpEeEx3N2ZTaDF5ZzJ4VHZJYk1sQzVIc2YrRWwwNlpodC9SUG5v?= =?utf-8?B?cndqZG9HMHBweGtOZW1QSUtKVE5ESDgxbUx3eHUxSmtSRTdsZllnYmxrbXRL?= =?utf-8?Q?MfGyQQ+HYmKB/2HFeLUVj/7Qe?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42c2abd2-7a65-478b-f109-08dab663444f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 08:31:09.2641 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2UuDMlH6FylVbqR9lHK2zX+hBTLiDXCFSlaCIFPPBh5jJTt5UGVl+VVLkxj8ICjd76E4OwsRAkCaj29CKNHz0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7554 X-Spam-Status: No, score=-3029.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25.10.2022 09:49, Cui, Lili wrote: >> On 19.10.2022 17:15, Haochen Jiang wrote: >>> --- a/gas/config/tc-i386.c >>> +++ b/gas/config/tc-i386.c >>> @@ -1102,6 +1102,7 @@ static const arch_entry cpu_arch[] = >>> SUBARCH (raoint, RAOINT, ANY_RAOINT, false), >>> SUBARCH (wrmsrns, WRMSRNS, WRMSRNS, false), >>> SUBARCH (msrlist, MSRLIST, MSRLIST, false), >>> + SUBARCH (prefetchi, PREFETCHI, ANY_PREFETCHI, false), >>> }; >>> >>> #undef SUBARCH >>> @@ -4522,7 +4523,8 @@ load_insn_p (void) >>> { >>> /* Anysize insns: lea, invlpg, clflush, prefetchnta, prefetcht0, >>> prefetcht1, prefetcht2, prefetchtw, bndmk, bndcl, bndcu, bndcn, >>> - bndstx, bndldx, prefetchwt1, clflushopt, clwb, cldemote. */ >>> + bndstx, bndldx, prefetchwt1, clflushopt, clwb, cldemote, prefetchit0 >>> + prefetchit1. */ >>> if (i.tm.opcode_modifier.anysize) >>> return 0; >>> >> >> There's still no change in this file making sure that the new insns are _only_ >> accepted with RIP-relative addressing. See my earlier comments. >> > I'll modify the patch based on your previous comments, do you agree with adding a warning instead of an error for illegal input for assembler. Because it doesn't cause hardware errors. Personally I think a warning is too little, but if H.J. agrees with you, then so be it. Jan