From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 52CE83858D1E for ; Tue, 29 Nov 2022 17:47:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 52CE83858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=harmstone.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x32c.google.com with SMTP id j5-20020a05600c410500b003cfa9c0ea76so11397061wmi.3 for ; Tue, 29 Nov 2022 09:47:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=gobaXBXUZdfCgdwzEe9ZcYNQOQwY9dT1/rTJ6IrLGG4=; b=jYEz9gP+11mARkGtvZLvQOl0jyA/rBdLnc5VlovAIqR8NupEmckiz/XCyOwbkxjF4L svM19votHtT3IEKzsZevx7aK71V3Fl97Cj8c9c9fC/buNFAqaVSZll2ReNWx0LC/Exgr /ycix+TX1r5ZIyhw267rMJW1KgBRopUsIHedggES1O7L789YJd2Z+79lCyqgX4x4mUDr fLeRnBjvs7T6GkiM2Chhb7tdKn28Eg1D6V8/DTRzBVEVh2JiiRYsW/Jv9gpMK9+tM5/m VQ5C4ytWaPw335D1fhPK2nXeCxI7tKzs3bCIYXaXtn8Gj6oJ2Rs6BeV0csu3L3tS+ZR5 sJbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gobaXBXUZdfCgdwzEe9ZcYNQOQwY9dT1/rTJ6IrLGG4=; b=HsW7KQa/IvCceirgDreskEaGlxFlGo4ZyWEUobFX27pLs910mt6h2byeJCoS4iigIW 1co1TCPE0jGo6CWkUqx/DdjZRVvnYMtMlRNpXC29fRJd8TEIvfYRyXzJoMR+B5epnESP XK36UP7uyU1ye8JqHcNCy4hbT/XlbhmAq3DYBt6H0BxiazSi+2NmQ/iLh6fzXLwrwHhm ARqgUgXa3Kuvqm0axyvS8Pp0ibbA36dWtFWIBfhzMYdfKeihB3u1MzAPr5mf5XQrOAlE QElSVFT495dBIKKbpDleQ1Jz0Z/zt3Wx6wEeQKRBA1MZxtsZTabVmmq08O5gpZdM+2ht JMLg== X-Gm-Message-State: ANoB5pkj7JALply/+UBurtO5XAk4EyOniz8nzRyTRbliBrYMifh22q/X oVgD3ks+OpJ6rm+mRQSIygFRaKEvDxA= X-Google-Smtp-Source: AA0mqf4bgAzMxJiGMYKYXCc5rLp1fh+5XQCaMDXw7wz6pMTicGE/xXehtnTW+rX2xXl0s1HlyX4lgg== X-Received: by 2002:a05:600c:4f82:b0:3cf:aa11:9394 with SMTP id n2-20020a05600c4f8200b003cfaa119394mr30249159wmq.183.1669744067009; Tue, 29 Nov 2022 09:47:47 -0800 (PST) Received: from ?IPV6:2a02:8010:64ea:0:8eb8:7eff:fe53:9d5f? ([2a02:8010:64ea:0:8eb8:7eff:fe53:9d5f]) by smtp.googlemail.com with ESMTPSA id o15-20020a5d474f000000b002421a8f4fa6sm5328670wrs.92.2022.11.29.09.47.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 09:47:46 -0800 (PST) Sender: Mark Harmstone Message-ID: <8082e0e2-5c01-8ce6-e447-3dce8e689c66@harmstone.com> Date: Tue, 29 Nov 2022 17:47:44 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] ld: Fix segfault in populate_publics_stream To: Jan Beulich Cc: binutils@sourceware.org References: <20221125025433.26818-1-mark@harmstone.com> <20221127023840.32080-1-mark@harmstone.com> <992f7462-5544-39fd-507c-bfeabf708db8@suse.com> <09f9d8ae-4dee-e056-6f7b-e70542097ffd@harmstone.com> <388cf207-6b32-0e7a-d857-c037e346ce3a@suse.com> Content-Language: en-US From: Mark Harmstone In-Reply-To: <388cf207-6b32-0e7a-d857-c037e346ce3a@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > it ... should actually be accompanied by a code comment. Not really, as it was a straightforward mistake in my original patch. If I'd included a NULL check to begin with, I doubt anyone would have batted an eyelid. I could have easily worked around this in my test, either by adding in a dummy section or by using the preprocessor rather than .equ, but figured that any way of causing a segfault is a bug that needs to be fixed. Mark