From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id 4B2FE385780F for ; Mon, 28 Mar 2022 08:52:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4B2FE385780F Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-19-fRZF6Lf3OT-z0j6XKMFG8A-1; Mon, 28 Mar 2022 10:52:46 +0200 X-MC-Unique: fRZF6Lf3OT-z0j6XKMFG8A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=md+cEZIZoZaCBJF41wTSWmekBz230JJ9Aj304tWB6WIsuJOd6nNJ1l//QgPMoQTsXTCB81JEtdTH2FWjIlcP79OSd8faMepsYZSBcHQ4mLLJAMPhHnFA/QAEQBwt8UoIHj8IWciijsvuNAgpw6n08NyTsXdQoQVohPFysOwjl4AekufDtnR0FmvY6A00FGC2/jkEnNjsomJovcYi8DBwMfG2yyCd2MfyF0O7jrues4MoqM30L5XN0K27EetqiuGy1WOloplBLOIFve87YJ2F/YTTMMnUrE0DkaikDlyUQX2gs7I5DJimsCKctyloWvweWz/p7DSYAL68Gf0bNehOBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dw8krPjKiUPVeFG5P1oU5CDgHdZjW125u23yAzKkZHs=; b=d/2Z+pLGQSPsZRK39P8/H7zgriJaJxRchQb0DgrTRPKmXar07pRX/dMp/uB7fcOLyekqfMv8ThEEKt86uEGksWm/au94KfBSiJvyE5bd8iGsie/fdet0C4qSOgFo5zwi61iO+3PrvnDY4yfZjQhZEFZZgMODxLUY2k9l2TXIusUDZNhG0byroI/2FY7AMWs6CHlwQTlfnZCFcRZKJk0Dts4goZe1ZKk2xN66+hdoL46P61Qrz2u/DrXVNvjT+EK0mu54Lkrg2TKeliYdTuPK+D42Rif7d8+qaSBU+4/OeR6pKDPLYIg971WDxgksOyd43wuVSjH74oKvQmU34eetow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by PR3PR04MB7308.eurprd04.prod.outlook.com (2603:10a6:102:80::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.22; Mon, 28 Mar 2022 08:52:44 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5102.022; Mon, 28 Mar 2022 08:52:44 +0000 Message-ID: <808fd1e0-8993-66d9-e5aa-129e7916790a@suse.com> Date: Mon, 28 Mar 2022 10:52:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Ping: [PATCH v2] RISC-V: correct FCVT.Q.L[U] Content-Language: en-US To: Palmer Dabbelt , Andrew Waterman , Nelson Chu , Jim Wilson References: <7d633e34-657c-539e-7df9-146c4dd649f2@suse.com> Cc: Binutils From: Jan Beulich In-Reply-To: <7d633e34-657c-539e-7df9-146c4dd649f2@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0775.eurprd06.prod.outlook.com (2603:10a6:20b:484::30) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bb45f22b-5a66-4d14-327e-08da1098534b X-MS-TrafficTypeDiagnostic: PR3PR04MB7308:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MgO1rN2L6STld0GTyb/y2FgKLAC4A37QUzhOaD7QssFAm4/o93wZEKx9PeMmflbq8l8v4US0SHM6rDlcIE9WoqvCBTEOIdMeiylfDc+Y8/X56afoY0RYQXAo3ca89lkHOjxY2V9mMCut31amxk3xVfZ0IpkQG82r348Bs+aIOZh8J4A/IG+S67ieU899Tyys5vTCMyZzMTtAVKQxt7nte1G90sR71DYsOMxSBUUsH58urBWuT7EfEkVZU7fwwNzW4uNaaXVLs7n/M8RMevf47pfgEBXIF8+9z8kTzQkUxYSsiN3RFkeWSOrt+7ZyBUnmdlFBQb7yvNG9NCR1ciVP4cRSzoRBSsCKZeaxangCbBebk5wssrHmKxokNdsDEYJX38mEq4i6RywSIcBgBzWR5e0sV3r9NIp+0Up5L1GAPny3gsZS32ZmXgefLx7THmgQoeT/0pll4gheBCKS5eOj2ZDCVeTboN/4GU7v9vP9KDp/OjKJzeZsduAjmL46hF4iw+oHcw+QkIoe0S5yzvHtcnpoJvunEkUSj5dD7aY+dxBz43pYleRl4v+lR2OY5NoGDPHr52+rmnf72UoJLoqUj4AQ4mD4uYsRhC/niGgmnNSE0BKWVT9pQn9p/0qWkpUCLvCJ8SV8X7sCim7nHJ1BpWy6XGEmSBOnhIHzf/yKL6slgwwiRcHbVslSVQ8x4n5WtOjxb3x0uyYj+LoKiaomN78p7Dq16fxpcTcEZjBXru6ypYO1BIytT5uJK+SjhKvp X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8616.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(36756003)(66476007)(66556008)(53546011)(2906002)(6512007)(31686004)(86362001)(316002)(508600001)(186003)(8676002)(31696002)(38100700002)(26005)(6486002)(4326008)(5660300002)(8936002)(83380400001)(2616005)(66946007)(6506007)(110136005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWJXZXRUMUNheWNKUG9ZbEJKSHFzZm5iT1U1bURFTDBCUldGSi82cE5oL2dR?= =?utf-8?B?K0JYckRKbDBXQU9ENHZ1Uy90WVhzOXdKSHVkS2ZZb3V0QTJqb0wxRGFjQjhi?= =?utf-8?B?VXljRklPZVhKenZBMDdRVVdmUFRIZFVFTWdFUmZkYkNFdWszcENOQVlRd0F2?= =?utf-8?B?TnAwSjlPTXNmMGhPMWdJejByR0s1aXBjejNWQ2J5b1BrblBGU2FmRnVjL2FF?= =?utf-8?B?RjRrN0xPcGNIQ3owanVZL25Jc3UyZ2I0ejQ3ZXF6cWFjM2lDWDY0WkZqdmtu?= =?utf-8?B?elh0dFlmTmR1WE9KMzBMYUZiUEZXNlRncXJ0aFdISUdEYWVtcmpOR1dtakV4?= =?utf-8?B?UFhmcDkvV2dOY2l6TUNvTzRhUloyeEF5N2wxVWY0NENrQjhDMUs4SE1lZzdR?= =?utf-8?B?QU01Q1RWM253ek94S2FiRzNzTW84ZnYwUU1kdHcrRU9LWnh1V0hCVUxOc3E1?= =?utf-8?B?SFo5UkR3cndUdDZLZGhwK3lmYnV3NEl0S1M4QlY0QUhxU3l0bVBDOWNzbmQx?= =?utf-8?B?K0pHWVkzaGh5T0NLU2JLZS90RlVCQlh5YWtGNTAvcEFoaDBENW56a1NSbEVU?= =?utf-8?B?WGVjeDY5MWFzR0ZRRzRnMnJxbUY2bm9uSVBWbmlpWWxUb04xY2I0ZmJjbDBU?= =?utf-8?B?UTRGeWlaaXU0SFk2SnZxc0tUbnQwbkhaSmFFaUMzT0tubUZRZmxkaDNTdGg4?= =?utf-8?B?T1AvdXZuZDBXaUswSW4xaXZaL3JUdFpteTQwV0xiY1ZtdHdmblBTVnQramd3?= =?utf-8?B?VWJDVVNIM1JvV1gyclJvOEU5b1NTUURMNUd1eTloYjVjT2p5VlZPTUdHY2hI?= =?utf-8?B?VGxOU0s5RW4zR0M3bjNvUDJNUnplT3piSzNSNDNibWl5NkhLT3ZmbXV1MW9i?= =?utf-8?B?amd1SElGS1lkTzJIdHdIYnZuWDRXc3B2SEhmSjZMSDlxdDZDS1V6TklkTDJD?= =?utf-8?B?K1NqemxIbC9keFhqVDBGUTBXcnd3cTg1SDNjNnFtc2xSS2FSUEtEZkJFSStD?= =?utf-8?B?b2lzKzZ0bDI2TDZ1TmRHSS92OWVoYmJ6cVkzN0c4cjgzQlFsU01jMXJZTmhI?= =?utf-8?B?YmE0YVNoNWdLNVdWalc1YW1rTGF4UkMxd1VYSk9naHhYR2lyQnkzKzMyZ3NR?= =?utf-8?B?NVk2K0ZURUdZSUFrbm94Q3VFcHZ0bU52VWgrSW5pSERIb2t1Y1VnbkVvWXpG?= =?utf-8?B?MWRYc2lyRmxZcEN2eWlvMGRIWWpCdlNPYmVsb0tHazYyelFpQklLZHRWaGxW?= =?utf-8?B?VXNkMkVQZGFDUHkwY2luOENkUUhIUnY3YzNUL2JrLzh4QWFlOG51SUdPc2FS?= =?utf-8?B?cDc0VXdqeUF0eStqdWFlc21tQjlJNFdGcFlibXQ5TXJldjhmZDhYcW5ocjVK?= =?utf-8?B?c0I2SlhGSFMwSi90K20ydzBPMkFNYVdyREJTTFRWYnV3amxrRG9YWE1acVk3?= =?utf-8?B?K211T0lSc3hQeG5WWXZRM2NqMUtmVGxMNVhyeENLbzRHSDdpRldBdUF0ZDY2?= =?utf-8?B?TFUvVDQ3bHlEc3p0Y1ZpV2ZOV0dNU0UwNkxYbG5aT0hoRjB6VkJTWndUZTl5?= =?utf-8?B?ODFkMzdpaHE2RGJMUkhxT21ieUF6RDBtcERtaDJ5U0EzVDlFZ1VwSnR4TE9K?= =?utf-8?B?Rk9DU3VoNklyRlBPTzQvV0lnaWdYNDhIbENpblNhM3BFMnNPVnNNKzAzaG0w?= =?utf-8?B?RlpVSzlremtNdGxjck96ZHMwcnlyTXl6Vno0WmYrUUEvTXRnN3dkU1cyVFVu?= =?utf-8?B?YXhBNWVlU05SMDVTZ0hUQ2Z6aTcvOFlaTndUbDNmbXFvQnhDaVFXNWRWTWsv?= =?utf-8?B?NFNHb1FLb1YvSHVjVVFxK0hMbTZnSGN5emplUVRUamYyak5qVG9PZE44TExl?= =?utf-8?B?TVdINllvMksvMHRVUjVLb0lOcUZLcXFOcXVvUUp3eGhMVUd2RERwTnkya0hk?= =?utf-8?B?bGg1NVRIdnB3U2Nqck5sNEJHRWZuSGtRbnNYZzFPUjRLR3lMeURZWnd4Q3po?= =?utf-8?B?aFBQSGk2NzVCS0Y5TmxzSTNNdXNYRkpiTEhxT3lpcjJ6Nlhjd0hrbnJLNFZQ?= =?utf-8?B?b1ZxbExlYzVzQnFTdWsyN0Zob3pyT3FPZ3RuTkRMRi81UzU0NVlYWWVrL1FI?= =?utf-8?B?bVh0NjU5TzdaZzJLN2x2QkpYQkVCcFFZRVY1U3QveE5MTFI4QjBRNTUzMzdh?= =?utf-8?B?S2tFRkNQdjB4bUR4aFM2V2pNVjQzTHcwYy9OaGJCcWZ0ZGxQK1RwUWIzYUph?= =?utf-8?B?RkJ1WTI0UXFnS3k5eWxOMVdrVkNoODRmeDJuTkd6UkhwWWx5bUpzNjZCMFlD?= =?utf-8?B?WnUxSW1DV0UxNTVBcUpaekI2bTNhMWU5WjV4NlFSWDBBaHpsUTk2UT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb45f22b-5a66-4d14-327e-08da1098534b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2022 08:52:44.6419 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5VFCn62FoTWPfw0VKwf4GfQVPMFaHiGY4fgd2AbJEowPoY95a6+4jjRSoytzQNYdB+miBP/Ry07oZNRI7fhixw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7308 X-Spam-Status: No, score=-3031.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Mar 2022 08:52:50 -0000 On 04.03.2022 13:41, Jan Beulich via Binutils wrote: > While the spec isn't explicit about this, it pointing out the similarity > with the D extension ought to extend to the ignoring of a meaningless > rounding mode: "Note FCVT.D.W[U] always produces an exact result and is > unaffected by rounding mode." Hence the chosen encodings also ought to > match. > > Note that to avoid breaking existing code the forms with a 3rd operand > are not removed, which means there continues to be a difference to > FCVT.D.W[U]. I'd prefer to not commit such without arch maintainer approval; I guess I'll give it another week and the will assume the absence of comments to mean consent. Thanks, Jan > --- > Oddly enough there's looks to be no testing of the Q (or D/F) extension > beyond what was recently added for Zqinx (Zdinx/Zfinx). > --- > v2: Re-base. > > --- a/gas/testsuite/gas/riscv/zqinx.d > +++ b/gas/testsuite/gas/riscv/zqinx.d > @@ -28,8 +28,8 @@ Disassembly of section .text: > [ ]+[0-9a-f]+:[ ]+46158553[ ]+fcvt.q.d[ ]+a0,a1 > [ ]+[0-9a-f]+:[ ]+d6058553[ ]+fcvt.q.w[ ]+a0,a1 > [ ]+[0-9a-f]+:[ ]+d6158553[ ]+fcvt.q.wu[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+d625f553[ ]+fcvt.q.l[ ]+a0,a1 > -[ ]+[0-9a-f]+:[ ]+d635f553[ ]+fcvt.q.lu[ ]+a0,a1 > +[ ]+[0-9a-f]+:[ ]+d6258553[ ]+fcvt.q.l[ ]+a0,a1 > +[ ]+[0-9a-f]+:[ ]+d6358553[ ]+fcvt.q.lu[ ]+a0,a1 > [ ]+[0-9a-f]+:[ ]+26c58553[ ]+fsgnj.q[ ]+a0,a1,a2 > [ ]+[0-9a-f]+:[ ]+26c59553[ ]+fsgnjn.q[ ]+a0,a1,a2 > [ ]+[0-9a-f]+:[ ]+26c5a553[ ]+fsgnjx.q[ ]+a0,a1,a2 > --- a/opcodes/riscv-opc.c > +++ b/opcodes/riscv-opc.c > @@ -763,9 +763,9 @@ const struct riscv_opcode riscv_opcodes[ > {"fcvt.l.q", 64, INSN_CLASS_Q_OR_ZQINX, "d,S,m", MATCH_FCVT_L_Q, MASK_FCVT_L_Q, match_opcode, 0 }, > {"fcvt.lu.q", 64, INSN_CLASS_Q_OR_ZQINX, "d,S", MATCH_FCVT_LU_Q|MASK_RM, MASK_FCVT_LU_Q|MASK_RM, match_opcode, 0 }, > {"fcvt.lu.q", 64, INSN_CLASS_Q_OR_ZQINX, "d,S,m", MATCH_FCVT_LU_Q, MASK_FCVT_LU_Q, match_opcode, 0 }, > -{"fcvt.q.l", 64, INSN_CLASS_Q_OR_ZQINX, "D,s", MATCH_FCVT_Q_L|MASK_RM, MASK_FCVT_Q_L|MASK_RM, match_opcode, 0 }, > +{"fcvt.q.l", 64, INSN_CLASS_Q_OR_ZQINX, "D,s", MATCH_FCVT_Q_L, MASK_FCVT_Q_L|MASK_RM, match_opcode, 0 }, > {"fcvt.q.l", 64, INSN_CLASS_Q_OR_ZQINX, "D,s,m", MATCH_FCVT_Q_L, MASK_FCVT_Q_L, match_opcode, 0 }, > -{"fcvt.q.lu", 64, INSN_CLASS_Q_OR_ZQINX, "D,s", MATCH_FCVT_Q_LU|MASK_RM, MASK_FCVT_Q_LU|MASK_RM, match_opcode, 0 }, > +{"fcvt.q.lu", 64, INSN_CLASS_Q_OR_ZQINX, "D,s", MATCH_FCVT_Q_LU, MASK_FCVT_Q_LU|MASK_RM, match_opcode, 0 }, > {"fcvt.q.lu", 64, INSN_CLASS_Q_OR_ZQINX, "D,s,m", MATCH_FCVT_Q_LU, MASK_FCVT_Q_LU, match_opcode, 0 }, > > /* Compressed instructions. */ >