[Patch]: som.c: do not free relocations

[Patch]: som.c: do not free relocations

[Tristan Gingold]

Hi,

there is a subtile bug in som.c:som_bfd_free_cached_info:  relocations were freed, which is
wrong as they are allocated in som_slurp_reloc_table using bfd_zalloc.

Ok to commit ?

Tristan.

bfd/
2010-05-28  Tristan Gingold  <gingold@adacore.com>

	* som.c (som_bfd_free_cached_info): Do not free relocations as
	they were allocated with bfd_zalloc.



index fbdc2b4..c793cb9 100644
--- a/bfd/som.c
+++ b/bfd/som.c
@@ -6304,8 +6304,7 @@ som_bfd_free_cached_info (bfd *abfd)
       /* Free the native relocations.  */
       o->reloc_count = (unsigned) -1;
       FREE (som_section_data (o)->reloc_stream);
-      /* Free the generic relocations.  */
-      FREE (o->relocation);
+      /* Do not free the generic relocations as they are objalloc'ed.  */
     }
 #undef FREE

Ping [Patch]: som.c: do not free relocations

[Tristan Gingold]

Hi,

ping for the whole SOM patch set.

Tristan.

On May 28, 2010, at 10:30 AM, Tristan Gingold wrote:

> Hi,
> 
> there is a subtile bug in som.c:som_bfd_free_cached_info:  relocations were freed, which is
> wrong as they are allocated in som_slurp_reloc_table using bfd_zalloc.
> 
> Ok to commit ?
> 
> Tristan.
> 
> bfd/
> 2010-05-28  Tristan Gingold  <gingold@adacore.com>
> 
> 	* som.c (som_bfd_free_cached_info): Do not free relocations as
> 	they were allocated with bfd_zalloc.
> 
> 
> 
> index fbdc2b4..c793cb9 100644
> --- a/bfd/som.c
> +++ b/bfd/som.c
> @@ -6304,8 +6304,7 @@ som_bfd_free_cached_info (bfd *abfd)
>       /* Free the native relocations.  */
>       o->reloc_count = (unsigned) -1;
>       FREE (som_section_data (o)->reloc_stream);
> -      /* Free the generic relocations.  */
> -      FREE (o->relocation);
> +      /* Do not free the generic relocations as they are objalloc'ed.  */
>     }
> #undef FREE
> 

Re: [Patch]: som.c: do not free relocations

[Nick Clifton]

Hi Tristan,

> bfd/
> 2010-05-28  Tristan Gingold<gingold@adacore.com>
>
> 	* som.c (som_bfd_free_cached_info): Do not free relocations as
> 	they were allocated with bfd_zalloc.

Approved - please apply.

Cheers
   Nick

Re: [Patch]: som.c: do not free relocations

[Tristan Gingold]

On Jun 8, 2010, at 11:59 AM, Nick Clifton wrote:

> Hi Tristan,
> 
>> bfd/
>> 2010-05-28  Tristan Gingold<gingold@adacore.com>
>> 
>> 	* som.c (som_bfd_free_cached_info): Do not free relocations as
>> 	they were allocated with bfd_zalloc.
> 
> Approved - please apply.

Thanks, committed.

There are other patches for som that haven't been reviewed yet:

http://sourceware.org/ml/binutils/2010-05/msg00393.html
http://sourceware.org/ml/binutils/2010-05/msg00394.html
http://sourceware.org/ml/binutils/2010-05/msg00395.html
http://sourceware.org/ml/binutils/2010-05/msg00396.html

Tristan.