public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Binutils <binutils@sourceware.org>, Fangrui Song <i@maskray.me>
Subject: Re: [PATCH] elf: Also check linked-to section for SHT_NOTE section
Date: Wed, 30 Sep 2020 15:01:18 +0100	[thread overview]
Message-ID: <8176aa1f-3c9b-45ec-b1a3-8e7cf19de47c@redhat.com> (raw)
In-Reply-To: <CAMe9rOpZKx2tygA6_HTrcb44H=92mPNuuaq=6pBjRHBx3NHcZQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

Hi H.J.

  Thanks for taking an interest in this.

> Please try this patch.
  It did not appear to make a difference. :-(

  I am using an extended test case (attached) but the results are the
  same as before:

  % as eliminate.s -o eliminate.o
  % ld -e 0 --gc-sections --print-gc-sections eliminate.o 
  ld: removing unused section '.group' in file 'eliminate.o'
  ld: removing unused section '.group' in file 'eliminate.o'
  ld: removing unused section '.text' in file 'eliminate.o'
  ld: removing unused section '.unused1' in file 'eliminate.o'
  ld: removing unused section '.unused2[unused_group]' in file 'eliminate.o'
  ld: removing unused section '.unused3[unused_group2]' in file 'eliminate.o'
  ld: removing unused section '.gnu.note2[unused_group]' in file 'eliminate.o'
  ld: removing unused section '.gnu.note3[unused_group2]' in file 'eliminate.o'
  ld: a.out: sh_link of section `.gnu.note1' points to discarded section `.unused1' of `eliminate.o'
  ld: final link failed: bad value

Cheers
  Nick

[-- Attachment #2: eliminate.s --]
[-- Type: text/plain, Size: 401 bytes --]

	.text
	.nop
	
	.section .unused1, "ax", %progbits
	.nop
	
	.section .unused2, "axG", %progbits, unused_group
	.nop

	.section .unused3, "axG", %progbits, unused_group2
	.nop
	
	.section .gnu.note.text, "", %note
	.word 1

	.section .gnu.note1, "o", %note, .unused1
	.word 2

	.section .gnu.note2, "G", %note, unused_group
	.word 3

	.section .gnu.note3, "oG", %note, .unused3, unused_group2
	.word 4

  reply	other threads:[~2020-09-30 14:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-29 15:12 RFC: New gas directive: .attach_to_group Nick Clifton
2020-09-29 16:53 ` Fangrui Song
2020-09-30  9:33   ` Nick Clifton
     [not found]   ` <3609c590-8750-a021-92fb-05ff0ba7ca7d@redhat.com>
2020-09-30 13:43     ` [PATCH] elf: Also check linked-to section for SHT_NOTE section H.J. Lu
2020-09-30 14:01       ` Nick Clifton [this message]
2020-09-30 14:03         ` H.J. Lu
2020-10-01  3:41           ` Fangrui Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8176aa1f-3c9b-45ec-b1a3-8e7cf19de47c@redhat.com \
    --to=nickc@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=hjl.tools@gmail.com \
    --cc=i@maskray.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).