From: Mike Stump <mikestump@comcast.net>
To: binutils@sourceware.org
Subject: as error output not -j64 safe
Date: Thu, 15 May 2014 22:48:00 -0000 [thread overview]
Message-ID: <819223B1-7BDF-46C0-80CE-EF49878BA3C8@comcast.net> (raw)
So when dealing with error messages, it is important that they be one per line and -j safe. This fixes intermingled output when -j64 is used on linux:
diff --git a/binutils/gas/messages.c b/binutils/gas/messages.c
index e1734f2..c3a551b 100644
--- a/binutils/gas/messages.c
+++ b/binutils/gas/messages.c
@@ -219,13 +219,10 @@ as_bad_internal (char *file, unsigned int line, char *buffer)
if (file)
{
if (line != 0)
- fprintf (stderr, "%s:%u: ", file, line);
+ fprintf (stderr, "%s:%u: %s %s\n", file, line, _("Error:"), buffer);
else
- fprintf (stderr, "%s: ", file);
+ fprintf (stderr, "%s: %s %s\n", file, _("Error:"), buffer);
}
- fprintf (stderr, _("Error: "));
- fputs (buffer, stderr);
- (void) putc ('\n', stderr);
#ifndef NO_LISTING
listing_error (buffer);
#endif
next reply other threads:[~2014-05-15 22:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 22:48 Mike Stump [this message]
2014-05-15 22:52 ` Andrew Pinski
2014-05-15 23:13 ` Mike Stump
2014-05-16 8:51 ` Alan Modra
2014-05-20 20:28 ` Mike Stump
2014-05-20 22:01 ` Matthew Fortune
2014-05-20 22:49 ` Matthew Fortune
2014-05-20 22:57 ` Mike Stump
2014-05-22 7:22 ` Alan Modra
2014-05-22 8:10 ` Mike Stump
2014-05-22 8:40 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=819223B1-7BDF-46C0-80CE-EF49878BA3C8@comcast.net \
--to=mikestump@comcast.net \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).