From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2061.outbound.protection.outlook.com [40.107.6.61]) by sourceware.org (Postfix) with ESMTPS id 43DE93858D3C for ; Tue, 21 Feb 2023 09:25:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43DE93858D3C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d13gbMaDOUXdutYJsXreM3x08+uEm3v76s2trtBfyd0430zpyVpEXn6el5jGJtoEAIM3XnbaQ8bcN2YfU4Z0EQd/zv1NILibHje6DxcW1EVGq6KZfYGcGuuqlweOGugY7XAkt0RxcdfXSQae50MJET3MffF14iVVoOO+CIKZw4LdHcwshYn2nJsCbyI7nlsg8kZoWDiqqlfuGksJxORigDrMDJBl4VepHau7YdCWnJS4U/PrSOB4Klx1IlSBzKy3IIvKcUGx/oHzvdcV6XIQPpYCA1JxVCqt/vka0GUyn4AT7GErU4Nwo2ujUY/1ovTE0q39Cnz/bpZnX91XjQRLMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fwZiextVNkR3zXyOza3I1Xyp4qYZ3xS8FI23YKlW7PY=; b=EsXZ1tldjgMoDaq2kkKai8ya5LVeUMR87LaMdj+fWb7W3CU5uA/ERvqYgCzbyQoPBdyrylLPcDJgL7PNWd3faInG0nXbasOy/1n8nGjHkaHsb+pa+xzItDpEEG769xn4sUNQNuGoDHBNdkYRnosDhtqw3xnwqJx81zIzD3ws/OR/tvxH7jnxfhSoEk3HyPzTw4WPUWncXElXDclAMvm0N4iAD4eZCmEA2EU9Upd8C3LihlSSeVYHgAe7ba+f8dsNcg0kFwa2ya4moNm4J5mldODUohJpoCYniVbgA0Y6QFK0VuvUOTWQtkFYSMhC4+8O9kg7oBGvKmOh1lnPuRx24g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fwZiextVNkR3zXyOza3I1Xyp4qYZ3xS8FI23YKlW7PY=; b=TmzvcgJ3I+8q6bv5eFGSrG6KkroVR8e0y78F/zVSAdpBNPOoEDU3F3yM+f1sioMv9x1aaOzTdVxnKaa+1IpQgoiJBT7QgfO82KiNU8M8X2qHQFM0LGYj5ae3V3gGTJ07BA//V+lGlbC22coeKUpH8y2L8pQOTFZnJcfOrYgM/zyhR6yfcNYiCK+H/4v6/hJwrHeCiCN6uVl9zIJPuqHh14BjPOVe5WT+iiKuUwfWUJIc4GDhkRuwVI6+5X4tQDT0ohShaU6zmhC/PlMVhGM+OHr+ISd57eKbYzqNz7t/QzHeYGykJwcY5+eHlfzAPDd5tclWTPIUOLr14/6ktAqg0w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8706.eurprd04.prod.outlook.com (2603:10a6:20b:429::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 09:25:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 09:25:01 +0000 Message-ID: <824ba77c-a471-6bbb-b77e-fd77eb2dd5a8@suse.com> Date: Tue, 21 Feb 2023 10:25:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] ld/testsuite: handle Windows drive letter in persistent section Content-Language: en-US To: =?UTF-8?Q?Cl=c3=a9ment_Chigot?= Cc: amodra@gmail.com, binutils@sourceware.org References: <20230221090331.559683-1-chigot@adacore.com> From: Jan Beulich In-Reply-To: <20230221090331.559683-1-chigot@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0050.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8706:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f6ff6f0-8892-42c2-01c5-08db13ed820c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l8pPgCHPL+YSVRJkbwP8TII1UITrwawqisx7CMAlocaveVAYpCzKSZxkbC2FB+2zebFr0YSA0ntPECfs924kRz2IvqqLujKHQzdAFeOIbqL1TBPj/zKq+tteFxw8q/X78RTQRTlgP5z2ZLVimbMp4VACn5VM4tpN/daE0JkgDOgEf45JkMwYXbsYRLUmPuG2cJmOLcxC9JLpXkGwe22XfLC3/GMkYuSvwBmGwxl8cOMZ/pjVq+kNKPq9MidF+qoChvkMUcSX0sQP/YkSQn+dLSVTtk/OWoILuhU8ucCA1AO/Dcs2ayooNN4uRNknE5FxpavEyLe8qnB4CNz9lRuAtcKIA1YcXlRzvzI2sy5Z+RV6PbMC3F26Fyjyxz7rh3iKTXH41DoY6v3RNbSovpSXjaIepPrtnZP+YKQrKO5aFw4ttw5D3njMNyZ3dF4Pgu+znbSJghIanZoIV4eHIa+WeI7+zOyPTr2Cjkb2qz3c/0YZYsGvn/MUMepdonQAlFf9gktpSWyewzagOOx9IpuPEBI2EtS51Pgh45XP455DSE+WS9dU7+QfcZetlqLfhj5F1I4Kyi41CQfFMvKCLZfpEmFNdPzU/GfuErDaMAkwgsB6Z+QlvtZP0nQnUGwEDEIprWxLO9RfTzA+46MqouyLJtKWv9hJNuZd7UHBeZSpba2MQbEQa+WuCgLZpdUtJyRUXXkN09qhjsGhU0+rpHOWQ1tby370R0oE9i1eoQHRkfw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(346002)(136003)(366004)(376002)(39860400002)(451199018)(38100700002)(83380400001)(31696002)(86362001)(36756003)(2906002)(8936002)(41300700001)(5660300002)(6512007)(26005)(53546011)(186003)(6506007)(66574015)(2616005)(4326008)(316002)(6916009)(66556008)(6486002)(66946007)(8676002)(66476007)(478600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmNQL2xzTkF1eUtrVFJJakd4dlQ5S3NpdSszK2d4MER6b1dzZ1JiZHA5T0NK?= =?utf-8?B?RURJMWJtTjZXaEc5ZlU0M1hlMlZSeUtkbmd6V0dWUm1nQ3RBeWYyWWQ0UnIv?= =?utf-8?B?MHZiVlp3d0xXNm1ldkpEN0h1VHlCeVFPSThFNmQ0MVRTVElrOFRkMmVjWnFz?= =?utf-8?B?YWdNZVR4QW0zZjUrY2d1bndlc20vemlQbGpJR2UzanVyV013ZDQrUWM2Q2Vs?= =?utf-8?B?SUsyak8yUEtOT1JoTjY0NHlNdXVBYVk0Z3Y4emtZdHRrWGlDZ09pWThLQ21U?= =?utf-8?B?Z3Q0R0pxaGttZHp6RlhMMFZlWDJGL2FBZlZlMkJLdHgyQUExYlRZajVtN3Y4?= =?utf-8?B?RVV5NEduQ25lUjF4QUYwTWNOck5ZNktEMDMzSC9yc0huMUtPZnlwVmN1Mnhk?= =?utf-8?B?aXBKQjAyanVOWHV3YXlGVDRoLzdzRW5ubVJMTXVKc3VWbERhYS9NV0hpZndM?= =?utf-8?B?Q0c2NjJmUS82RUNkVkYxUmhSMkt4RHhPRVJzaW5yd3I1YW9BRW9nTE9iUnlN?= =?utf-8?B?cHdHQ0hTTDNucXFEY1lybE5qZnB3U1A4SUt3YzlZRjFoOTQ4Rmh5di9FWWZ1?= =?utf-8?B?TDNkQUdqQUsxUXdubzZoNDQ5cU5uaTdkZWtwdk9wMkY0S2Y5bG1idzAvRjFM?= =?utf-8?B?WU5PcnBUSW9JcHdqbXVlZmZBTWJ3NW5adGc0TFZzcVRMLzVEZUtOQm9QMFBH?= =?utf-8?B?aGlhVmJPWHN3RExBbFhXZkZiYWlLN0JHVUR0R1p4akphWmFLVDQzeTdVSEJt?= =?utf-8?B?Q25ndDNYcDZCUjJjdTkzYVdFSUMwM0JzaG03Lzc5THdWQWtpVFZ1TlJnclkr?= =?utf-8?B?NTBlR1M5aFFFSTJGRWIyNW5DMXQ3UFk1bGJxVGVtTjJUZDRXS0MzajhveERL?= =?utf-8?B?MTY0WTJVYWpkNDBCeTdMUGFWNUhXQ2g0ZUhMaHVMeG5IQUJHTC9jL0RnS2F6?= =?utf-8?B?c0c3UnBETkxtbEVTR29yY3NjQjlyVVNoaVVicUJwVUY3ZzE5aW4zTXUzb2JR?= =?utf-8?B?dzVYVHVuR09NVU5Zd0pTbE1UWWtXMlpKYTMzVTUvTGc3amlKcCswaHllSWFR?= =?utf-8?B?OURlV1pWNlg4VEE5VFdENGRQOEltT1dydGhpSUFRb0JKaWxUb2JRU2hpb3VK?= =?utf-8?B?c2UwSFlDWEw4WGpBWkdLa0JnWVBZeG9YQkJBWUhJUFFvZ0wzNDI0QzZNWWJP?= =?utf-8?B?YjZGeVg1K3RZdkZNOWRoclo0Uk45UWpKWUNDUFp1RXJ0MWZWcXFGUWpvY3Qy?= =?utf-8?B?dDRyUTFCak1KUTUwS1I4cG5TTE5KRGQxQmhQaUtYcFcrUWZpaUNxbTZkY1Jz?= =?utf-8?B?ZXV4bGRZUCtTYitKRTA3eXUwTklwL1l0MXRrQmgxTmtGYS9SQ2lBTnFCUFo4?= =?utf-8?B?Zng3Q01sNjdlTk9ZQVBmYXJ6RURhWDNjV281WEVQd2RDOEhMU2ZNWlRFWWJC?= =?utf-8?B?NjhFV0owUXFxTkR1NXExSEpZUVpFLzNoVzJjU0dYMEpjVEZGZ0J5SHdGeC9M?= =?utf-8?B?UWd6bU5GOUlFZjhNb2hHbDFGT2hzMk1EQXZNNGV5S1hMdTRHd2NiRVNsMDdE?= =?utf-8?B?Q1BzYWNlR0lGL0xPZEFhWCt1L2k2RUloclFsayszVXE0Q3ZjMm1jeCs3dzZw?= =?utf-8?B?dUlHQWVHWit5YmNJSVQwWEExQi8yTEdDNnA1UkhYQlVZMk1JcWppRHlUZy9G?= =?utf-8?B?Tjd3UW9INDNuYm1Wcis0VTBzNjJYcHBEcFFSMnZtS2dYbzdCWUVVbk91SVpL?= =?utf-8?B?UmNhcmM4Uy93WDFVMFNhcURaU3YzbkltZTA2T2hCaUdVNXBCTVFuZUQ3WHFJ?= =?utf-8?B?SW1VT0xQaWQ5NzVpREd3U3daa0Vvemo2L3ZSWjdUSmxQYW5pSExRcWp3WkY4?= =?utf-8?B?T0cvZUNpN0kwcENJZk5rWTlsMHdNRHdxZ1QzZ2V4ZC80VS93S1RIR1J1ZEEz?= =?utf-8?B?OEt6ZmZ3WmlOWlU0ZEppTE1WTk5BUTFPcmZtWGhoQmZUUHhaZ243Vlc4a3Jl?= =?utf-8?B?OWxCMC83aUFwbHhoek1qQXg0MC83L1loYmFlWDdoeUt4cEJvcE1mTkhIN2JF?= =?utf-8?B?T0l2cWR0NG41NXQ0cG0wZyt2djBhdDErWlVpMFZIWlc0ZEtBdFJjOCtKbks5?= =?utf-8?Q?Sb4H3zq12hbvuyR883rOInZjU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f6ff6f0-8892-42c2-01c5-08db13ed820c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 09:25:01.4465 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JjsV3cpZEX4HwMj8HJaQcJMgNxsEFyYSqitm1NPdwoMw5XT8lFqj2S/05/YCXlzTaFhqIwM30jBi+MVA0sN/nA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8706 X-Spam-Status: No, score=-3028.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21.02.2023 10:03, Clément Chigot via Binutils wrote: > --- a/ld/testsuite/ld-elf/persistent-sections-2.l > +++ b/ld/testsuite/ld-elf/persistent-sections-2.l > @@ -1,5 +1,5 @@ > #... > -[^:]*: warning: orphan section `.persistent.var_persistent' from \S+ being placed in section `.persistent.var_persistent' > +(|.:)[^:]*: warning: orphan section `.persistent.var_persistent' from \S+ being placed in section `.persistent.var_persistent' > #... > -[^:]*: warning: orphan section `.gnu.linkonce.p.var_persistent2' from \S+ being placed in section `.gnu.linkonce.p.var_persistent2' > +(|.:)[^:]*: warning: orphan section `.gnu.linkonce.p.var_persistent2' from \S+ being placed in section `.gnu.linkonce.p.var_persistent2' Personally I find "(|.:)" slightly less intuitive than "(.:)?", so could I maybe talk you into using the alternative form? However, seeing your further reply (mainly targeted at Alan) I also wonder whether the issue can't be addressed in a more general manner, by pruning drive letters from diagnostics before actually doing any regexp matching. Such pruning could then also be limited to actually running on Windows, whereas changing expectations in test cases would affect all targets. Jan