From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 60D7E3858D20 for ; Thu, 16 Nov 2023 23:36:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 60D7E3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 60D7E3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.129.153 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700177764; cv=none; b=TDo6w9kYNiTq+ywZCKomARbC07M8xBfkt+ottMRLoLl390WGzNCDFeroulFywUSUmqiG4lAi591Y2iGuEDQQOXFYd55M3GQJA7tzsogr2TYRpAmA7vADreY22j3cE+Z/CuJPH56cbibl9aQIKT9GX10T74A+LVYq5IkAHU7DySc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700177764; c=relaxed/simple; bh=U6TYll7ep9x16QnsUz2eq8S8HLY+E3/0fLWT0JyRH00=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=Yucgue0Kuiwvy/UuYI+eu53t+2O6DPx18EYefmPPSDNORYWyPwHQQeRV3UIeuRD3SSquC/0IaaW6o9XGGErF/hJUH3LUJ8jEZXgphfh4DxHwRh3xjNvhwmgsPfFdqWg2yrznQ+pENwqu5G8SpU6bAABw1+IpwmIKY4p9UPWD26A= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: MgZ/T1/bR8KHNKzyxW382w== X-CSE-MsgGUID: XI8oiBcvR5GjPvZDMo1skg== X-IronPort-AV: E=Sophos;i="6.04,205,1695715200"; d="scan'208";a="25981345" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 16 Nov 2023 15:36:01 -0800 IronPort-SDR: v5sb9AGQcXGspLHOJ18DZOXXPMN1lkf3ye/fslEh/YoOEQjTfUjgSBkX2hBlrVCx9gMY+cfGhI ocTvZLNaTm0y8KYMmG1PDJUyxS4gcPCGfcF0JAaJvgBzvda+LenazkdVVgX0qFBOIrvGsznbeJ MHFUBVEK3QXtli2SFZmpumNKz3PVseG5wyChCnOKWvwpuCGctvZ36NJkD3rtdgbXYFvjPBSc1F NYjsIuSp9I//po7gqD9NJxFAyGmn578ZBwIo79NxCAeEKLMDrCeME/0Ll/Bm0Es7pEs5VwbM3M FQE= Date: Thu, 16 Nov 2023 23:35:57 +0000 From: Joseph Myers To: Subject: Fix read_ranges for 32-bit long Message-ID: <82567b93-7ea5-bdbf-2940-59ad7c658f61@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3109.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: bfd/dwarf2.c:read_ranges compares bfd_vma values against -1UL, which doesn't work correctly when long is 32-bit and bfd_vma is 64-bit (observed as "nm -l" being very slow for mingw64 host; probably causes issues on 32-bit hosts as well as IL32LLP64 cases such as mingw64). Fix by using (bfd_vma) -1 in place of -1UL, as done elsewhere. --- OK to commit? diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c index b135ef09120..22e6b467598 100644 --- a/bfd/dwarf2.c +++ b/bfd/dwarf2.c @@ -3688,7 +3688,7 @@ read_ranges (struct comp_unit *unit, struct arange *arange, if (low_pc == 0 && high_pc == 0) break; - if (low_pc == -1UL && high_pc != -1UL) + if (low_pc == (bfd_vma) -1 && high_pc != (bfd_vma) -1) base_address = high_pc; else { -- Joseph S. Myers joseph@codesourcery.com