From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id D45943858C98 for ; Sat, 2 Dec 2023 07:14:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D45943858C98 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D45943858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701501287; cv=none; b=D7KYjrk6zLkiDzT9D559xpp/c/HfEwwkrkqmEt4oTA4Qd9VpcuZPewtdjWvGDqfocpKcBYA4AKJ8iZh/nscbViOo+QNWcB1pduo9jFk8f3p6ltT+gTwuQUCCCjOoF10v2yl4EPCHG4yXFEpGGvYuenskvp+4ffMjDAWnPPfsRkw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701501287; c=relaxed/simple; bh=53PsZwouPy2/0t9zwr2lyQas7d34gfMdmLVf8qy7zQ8=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=gZpri2LkYcE+T9SgHp3pj6KOQa7ke5iwnBEr28PyGoA76lFT5mpHWrni0dh4kpsOwxIQATffFFdd6cnhZ2LKCuT+ck9fQh4E/VyZI8N/V7xFQwesYNgWMt1T0K9QayZmYhefe8sD+t8BhNCLnRxVYB3f3tSNCVh6XnX3jCgBgZY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1701501282; bh=53PsZwouPy2/0t9zwr2lyQas7d34gfMdmLVf8qy7zQ8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Gg5LuWTNj5gM+WzCN5F1UUaY1PgDVnF6uIQ7FZZEDN/m9nnRgm6cXP9BcfDJTDhRW mt50lrQ9gpmdJSeWJfujrb/wWbgmeqyNdvFhxDiQEn/fOOwMF+cvfzr6XMoSozYXZB tI/px/XC4NXBsekEJHM8xcayYT9hbUuPLo1/jUgM= Received: from [IPv6:240e:358:11d6:3d00:dc73:854d:832e:3] (unknown [IPv6:240e:358:11d6:3d00:dc73:854d:832e:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id C59DD668F9; Sat, 2 Dec 2023 02:14:35 -0500 (EST) Message-ID: <8295edb277bbeae2e5a7e12e1ffb09e33898ba58.camel@xry111.site> Subject: Re: [PATCH v2 3/5] LoongArch: opcodes: Add support for tls le relax. From: Xi Ruoyao To: changjiachen , binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, i.swmail@xen0n.name, maskray@google.com, cailulu@loongson.cn, luweining@loongson.cn, wanglei@loongson.cn, hejinyang@loongson.cn, Lazy_Linux@126.com, mengqinggang@loongson.cn Date: Sat, 02 Dec 2023 15:14:28 +0800 In-Reply-To: <20231202065334.25904-4-changjiachen@stu.xupt.edu.cn> References: <20231202065334.25904-1-changjiachen@stu.xupt.edu.cn> <20231202065334.25904-4-changjiachen@stu.xupt.edu.cn> Autocrypt: addr=xry111@xry111.site; prefer-encrypt=mutual; keydata=mDMEYnkdPhYJKwYBBAHaRw8BAQdAsY+HvJs3EVKpwIu2gN89cQT/pnrbQtlvd6Yfq7egugi0HlhpIFJ1b3lhbyA8eHJ5MTExQHhyeTExMS5zaXRlPoiTBBMWCgA7FiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQrKrSDhnnEOPHFgD8D9vUToTd1MF5bng9uPJq5y3DfpcxDp+LD3joA3U2TmwA/jZtN9xLH7CGDHeClKZK/ZYELotWfJsqRcthOIGjsdAPuDgEYnkdPhIKKwYBBAGXVQEFAQEHQG+HnNiPZseiBkzYBHwq/nN638o0NPwgYwH70wlKMZhRAwEIB4h4BBgWCgAgFiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwwACgkQrKrSDhnnEOPjXgD/euD64cxwqDIqckUaisT3VCst11RcnO5iRHm6meNIwj0BALLmWplyi7beKrOlqKfuZtCLbiAPywGfCNg8LOTt4iMD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 MIME-Version: 1.0 X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, 2023-12-02 at 14:53 +0800, changjiachen wrote: > Add new opcode for tls le relax. >=20 > opcode/ChangeLog: >=20 > * loongarch-opc.c: Add new loongarch opcode. > --- > =C2=A0opcodes/loongarch-opc.c | 1 + > =C2=A01 file changed, 1 insertion(+) >=20 > diff --git a/opcodes/loongarch-opc.c b/opcodes/loongarch-opc.c > index 82b88bdad2a..e9ced5383e5 100644 > --- a/opcodes/loongarch-opc.c > +++ b/opcodes/loongarch-opc.c > @@ -399,6 +399,7 @@ static struct loongarch_opcode loongarch_fix_opcodes[= ] =3D > =C2=A0=C2=A0 { 0x000c0000, 0xfffc0000, "bytepick.d", "r0:5,r5:5,r10:5,u15= :3", 0, 0, 0, 0 }, > =C2=A0=C2=A0 { 0x00100000, 0xffff8000, "add.w", "r0:5,r5:5,r10:5", 0, = 0, 0, 0 }, > =C2=A0=C2=A0 { 0x00108000, 0xffff8000, "add.d", "r0:5,r5:5,r10:5", 0, = 0, 0, 0 }, > +=C2=A0 { 0x00108000, 0xffff8000, "add.d", "r0:5,r5:5,r10:5,s10:5", 0, = 0, 0, 0 }, This is just wrong, as I've pointed out in v1. You can always write .reloc 0, R_LARCH_LE_ADD_R, a add.d $t0, $t0, $tp If you think it looks nasty you can add a new pseudo instruction for this. Anyway there is not an "add.d" instruction accepting an immediate. Try not to puzzle people. (The trailing ",0" in the sc instructions is already much annoying to me. Do not make things even worse.) And please make the technical discussion public, instead of sending a private reply (unless you have a good reason). > =C2=A0=C2=A0 { 0x00110000, 0xffff8000, "sub.w", "r0:5,r5:5,r10:5", 0, = 0, 0, 0 }, > =C2=A0=C2=A0 { 0x00118000, 0xffff8000, "sub.d", "r0:5,r5:5,r10:5", 0, = 0, 0, 0 }, > =C2=A0=C2=A0 { 0x00120000, 0xffff8000, "slt", "r0:5,r5:5,r10:5", 0, 0= , 0, 0 }, --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University