From: Jan Beulich <jbeulich@suse.com>
To: Xi Ruoyao <xry111@mengyan1223.wang>
Cc: Cary Coutant <ccoutant@gmail.com>, binutils@sourceware.org
Subject: Re: [PING^3 PATCH] gold: don't invoke IA32 syscall in x86_64 assembly testcase
Date: Wed, 18 May 2022 09:40:52 +0200 [thread overview]
Message-ID: <8310f18d-a0db-f880-3ab2-4ef6bd1d9b3e@suse.com> (raw)
In-Reply-To: <7520a336117da569ff4924bc129d2310081812e4.camel@mengyan1223.wang>
On 06.05.2022 17:03, Xi Ruoyao wrote:
> On Fri, 2022-04-29 at 00:15 +0800, Xi Ruoyao wrote:
>> On Sat, 2022-04-09 at 07:25 +0800, Xi Ruoyao wrote:
>>> On Thu, 2022-03-31 at 09:05 -0700, Cary Coutant wrote:
>>>>> On Thu, 2022-03-31 at 12:41 +0200, Jan Beulich wrote:
>>>>>> On 12.03.2022 15:21, Xi Ruoyao via Binutils wrote:
>>>>>>> pr17704a_test.s is a x86_64 assembly file, but it invokes
>>>>>>> IA32
>>>>>>> exit
>>>>>>> syscall with "int 0x80". This causes a segfault on kernels
>>>>>>> with
>>>>>>> CONFIG_IA32_EMULATION disabled.
>>>>>>>
>>>>>>> gold/
>>>>>>>
>>>>>>> * testsuite/pr17704a_test.s (_start): Invoke x86_64
>>>>>>> exit
>>>>>>> syscall
>>>>>>> instead of its IA32 counterpart.
>>>>>>
>>>>>> Okay.
>>>>>
>>>>> I don't have write access to binutils-gdb.git, please help me to
>>>>> push
>>>>> it.
>>>>
>>>> Sorry, yes, this is OK. I'll apply it.
>>>>
>>>> -cary
>>>
>>> Gentle ping again, in case it's forgotten :).
>>
>> Ping? :(
>
> Ping.
I've committed this, seeing that it was still pending. While doing so
I took the liberty to slightly change the new assembly (using %eax
instead of %rax in two places).
Jan
prev parent reply other threads:[~2022-05-18 7:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-12 14:21 [PATCH] " Xi Ruoyao
2022-03-31 10:21 ` Xi Ruoyao
2022-03-31 10:41 ` Jan Beulich
2022-03-31 15:03 ` Xi Ruoyao
2022-03-31 16:05 ` Cary Coutant
2022-04-08 23:25 ` Xi Ruoyao
2022-04-28 16:15 ` [PING^2 PATCH] " Xi Ruoyao
2022-05-06 15:03 ` [PING^3 " Xi Ruoyao
2022-05-18 7:40 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8310f18d-a0db-f880-3ab2-4ef6bd1d9b3e@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=ccoutant@gmail.com \
--cc=xry111@mengyan1223.wang \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).