From: Andrew Carlotti <andrew.carlotti@arm.com>
To: binutils@sourceware.org
Subject: [PATCH] aarch64: Add sysreg features to +d128 dependencies
Date: Mon, 15 Jan 2024 11:16:53 +0000 [thread overview]
Message-ID: <8335f876-e09e-b977-beb1-77800f1b1a80@e124511.cambridge.arm.com> (raw)
We should revisit sysreg feature enablement and dependencies in future, but
this change should help until then.
OK for master?
diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
index 77467e20ba32ca40e4aaf71c427aab76ceb3b273..b77bb8b77c15317bedfcd5899f3db5457ddaf34c 100644
--- a/gas/config/tc-aarch64.c
+++ b/gas/config/tc-aarch64.c
@@ -10265,6 +10265,10 @@ struct aarch64_option_cpu_value_table
const aarch64_feature_set require; /* Feature dependencies. */
};
+/* There are currently many feature bits with no corresponding flag for features implied by FEAT_D128. We should combine or remove most of these in the future, but for now just make +d128 enable these dependencies as well. */
+#define D128_FEATURE_DEPS AARCH64_FEATURES (8, LSE128, SCTLR2, FGT2, ATS1A, \
+ AIE, S1PIE, S2PIE, TCR2)
+
static const struct aarch64_option_cpu_value_table aarch64_features[] = {
{"crc", AARCH64_FEATURE (CRC), AARCH64_NO_FEATURES},
{"crypto", AARCH64_FEATURES (2, AES, SHA2),
@@ -10336,8 +10340,7 @@ static const struct aarch64_option_cpu_value_table aarch64_features[] = {
{"the", AARCH64_FEATURE (THE), AARCH64_NO_FEATURES},
{"rasv2", AARCH64_FEATURE (RASv2), AARCH64_FEATURE (RAS)},
{"ite", AARCH64_FEATURE (ITE), AARCH64_NO_FEATURES},
- {"d128", AARCH64_FEATURE (D128),
- AARCH64_FEATURE (LSE128)},
+ {"d128", AARCH64_FEATURE (D128), D128_FEATURE_DEPS},
{NULL, AARCH64_NO_FEATURES, AARCH64_NO_FEATURES},
};
next reply other threads:[~2024-01-15 11:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 11:16 Andrew Carlotti [this message]
2024-01-15 11:25 ` Nick Clifton
2024-05-15 11:38 ` Andrew Carlotti
2024-05-15 22:08 ` Fangrui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8335f876-e09e-b977-beb1-77800f1b1a80@e124511.cambridge.arm.com \
--to=andrew.carlotti@arm.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).