From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 5B6C73858D38 for ; Tue, 26 Mar 2024 07:06:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5B6C73858D38 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5B6C73858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711436789; cv=none; b=HWv3Pi7Wnm5oTMe0vbHP3aJ67yvku/lmq+1vi2AsJfo/iaz9Fj3jBfI6LZFSFegpSbfS4iG47a655HT5xY/DFw1Rb5gSrRZqdS6xSC/6o79HeswWBW3fEW473P3jJbpwevCaW5+RPGCEb6kSpGPQnMCfKfU0iEodwJzyWHowGjs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711436789; c=relaxed/simple; bh=dG31JAtGQ8LQKR7dPY+X3K9X2RCdY4zBFPRCmA/IE5A=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=lVOSAA0qIlohn+X7GMfxTGF1yb8mYMthwyVHR+0jHEv2Rj+qvVNJb4AGi37II9ZexDgyk0OOWWZVqVQ3dHlhGujp83wp0SoD22fP5A7D007usEuAk8t7XIh682OwfGaDznhkFclV1gy57vMue3Mxl50A6bv1qk4NQuMYyFvHjJ0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a46dd7b4bcbso626124866b.3 for ; Tue, 26 Mar 2024 00:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1711436784; x=1712041584; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DNigJVMEM/G32eNpTO/zjZwr8b6nrSX1V3Mhhj6KXeE=; b=JRoBxEfv/zcNUiiXFO7g+bZcSkqNx5cszCZPaADw/es5/I3PCDWze1uGv8OViM6J42 1j6OEklRpSoH2EEZVh5E0Q8bSL/6Icm6tnZDR01wtNfKxNGPXTbixgZzLMAEK9O7J8B8 cn8qXjtRAro3zXaEKoUAb8Kr+R2Hj0qtlI7UplUDNjYbj3n751uJTJJ7Cj0Hyo93CLy7 sAeVtfrsg8A4cgx8vwoHHeEObokX0lhVpLT+XsQkuUQtPP2cannUvZ8JyXK2XT4ow2zY MZUMUuITmvYrlcKJXeNGB4/X57AhdGn/BN+KYzgvxx+go8iiWjIYBFeq6WBc/Cb/N6Zf LZVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711436784; x=1712041584; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DNigJVMEM/G32eNpTO/zjZwr8b6nrSX1V3Mhhj6KXeE=; b=NpzaUHWpTGiKG9d0wMUPUvvdyrEEAt3pPH1zl65pwJWGYhjT0ys6Ryub2Frpq5Xu9F n04a70jB+GDIvbe+o40niETIv6RmsKbKCGMyKojm/KUCjgtTJRsd/iNnHApE5WIoTOHc 0FLaWcsKfGQgY13ImCn2rnopkVm4h1qPxx3qKtZOpVZnt9QEEggYyNUq76dJydA03mbt pKvvF+DiYDI2xWZiggDy32WobzThasWvBdwJ9lqIEYhqaWgTSo5u6Qrb5A67oR1PTvZJ xnVZZhZxPTJDOhG8SpRYtqOB0ojVUYThJFayjlmhcFGYEcN4orU48wXrY+BQZP+xsD4c bAIQ== X-Forwarded-Encrypted: i=1; AJvYcCVcqd4nerXM2WYyq/rLSrHl4s1H1vnyH3AjnfMoYz6PZ1aACgyjlKHJnlXrmNPwZ7iY+mB/9LmIQCZ364GPL3KCcF9lAXSb+Q== X-Gm-Message-State: AOJu0YxYoyt56DaAudplWSJgVm1B6d6Byiw0Ri+G1ty5clls3a0PbPdZ s2xFKcZ0OgtN0eeIegTxgF2NmSgXByGEOYynW/qVDM/bgcSII5hNs+13W/sjAQ== X-Google-Smtp-Source: AGHT+IFNR/sLTT5lrFyche5x5BlRtfPRzSHfb+yNhSzfL05JuJVJXnrS2HVdRpzmck1EfIkvXm3Iag== X-Received: by 2002:a17:907:868a:b0:a4d:f773:19f9 with SMTP id qa10-20020a170907868a00b00a4df77319f9mr238470ejc.60.1711436784006; Tue, 26 Mar 2024 00:06:24 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id t21-20020a170906179500b00a468bf8586bsm3938392eje.174.2024.03.26.00.06.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 00:06:23 -0700 (PDT) Message-ID: <833fc131-ad7c-4add-9b99-ce37a49f50e6@suse.com> Date: Tue, 26 Mar 2024 08:06:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/9] Support APX NDD Content-Language: en-US To: "Cui, Lili" Cc: "Kong, Lingling" , "binutils@sourceware.org" , "Lu, Hongjiu" References: <20231124070213.3886483-1-lili.cui@intel.com> <20231124070213.3886483-6-lili.cui@intel.com> <8077dbe0-4519-4438-a943-5a310ff5f523@suse.com> <7882e22d-3375-427e-8964-cab847ba2c50@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26.03.2024 03:04, Cui, Lili wrote: > > >> -----Original Message----- >> From: Jan Beulich >> Sent: Friday, March 22, 2024 6:31 PM >> To: Cui, Lili ; Lu, Hongjiu >> Cc: Kong, Lingling ; binutils@sourceware.org >> Subject: Re: [PATCH v3 6/9] Support APX NDD >> >> On 22.03.2024 11:02, Jan Beulich wrote: >>> On 08.12.2023 15:12, Jan Beulich wrote: >>>> On 24.11.2023 08:02, Cui, Lili wrote: >>>>> +rol, 0xd0/0, APX_F, >>>>> >> +W|Modrm|No_sSuf|CheckOperandSize|DstVVVV|EVex128|EVexMap4|NF, { >>>>> +Imm1, >>>>> >> +Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseInd >> ex, >>>>> +Reg8|Reg16|Reg32|Reg64 } >>>>> rol, 0xd0/0, 0, W|Modrm|No_sSuf, { Imm1, >>>>> >> Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex >> } >>>>> +rol, 0xc0/0, APX_F, >>>>> >> +W|Modrm|No_sSuf|CheckOperandSize|DstVVVV|EVex128|EVexMap4|NF, { >>>>> +Imm8|Imm8S, >>>>> >> +Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseInd >> ex, >>>>> +Reg8|Reg16|Reg32|Reg64 } >>>>> rol, 0xc0/0, i186, W|Modrm|No_sSuf, { Imm8|Imm8S, >>>>> >> Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex >> } >>>>> +rol, 0xd2/0, APX_F, >>>>> >> +W|Modrm|No_sSuf|CheckOperandSize|DstVVVV|EVex128|EVexMap4|NF, { >>>>> +ShiftCount, >>>>> >> +Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseInd >> ex, >>>>> +Reg8|Reg16|Reg32|Reg64 } >>>>> rol, 0xd2/0, 0, W|Modrm|No_sSuf, { ShiftCount, >>>>> >> Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex >> } >>>>> +rol, 0xd0/0, APX_F, >>>>> >> +W|Modrm|No_sSuf|CheckOperandSize|DstVVVV|EVex128|EVexMap4|NF, { >>>>> >> +Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseInd >> ex, >>>>> +Reg8|Reg16|Reg32|Reg64 } >>>> >>>> Didn't we agree to avoid adding this (and its sibling) template, for >>>> the omitted shift count being ambiguous? Consider >>>> >>>> rol %cl, %al >>>> >>>> Is this a rotate by %cl, or a 1-bit NDD rotate? >>> >>> Btw, while this comment was taken into account for the "normal" shifts >>> and rotates, SHLD / SHRD still have this odd extra form. There's not >>> as much of an ambiguity there, but I think we should demand %cl to be >>> specified consistently across all respective APX insn forms. >> >> Actually the overall situation (for legacy shift insns) is even worse: For "normal" >> shifts / rotates, omitting the shift count means "$1", whereas for SHLD/SHRD it >> means "%cl". Prior to Lili's recent disassembler change it was also the case that >> only the "$1" would be omitted from output, but not the "%cl" (at least the >> disassembler is consistent now). >> > > I'm really confused about SHLD / SHRD, I think there is some problem with the legacy format. Normally we will omit $1, but we will not omit %cl. Should the opcode of the third item be 0fac? I don't think so, but I have no idea what the origin of this omitted operand form is. At least if you look at the APX spec, it (imo wrongly) omits %cl as an operand, too. "Wrongly" not the least because that's not in line with the SDM. Jan > shrd, 0xfac, i386, Modrm|CheckOperandSize|No_bSuf|No_sSuf, { Imm8, Reg16|Reg32|Reg64, Reg16|Reg32|Reg64|Unspecified|BaseIndex } > shrd, 0xfad, i386, Modrm|CheckOperandSize|No_bSuf|No_sSuf, { ShiftCount, Reg16|Reg32|Reg64, Reg16|Reg32|Reg64|Unspecified|BaseIndex } > shrd, 0xfad, i386, Modrm|CheckOperandSize|No_bSuf|No_sSuf, { Reg16|Reg32|Reg64, Reg16|Reg32|Reg64|Unspecified|BaseIndex } > > > Thanks, > Lili.