From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id A285D38A8166 for ; Mon, 5 Dec 2022 13:46:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A285D38A8166 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E10E21FEB0; Mon, 5 Dec 2022 13:46:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1670247986; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ceXqC6XPscRO01rWuJmTKdfnvTAbVI2iz2SMsMFA4FE=; b=cqF/KUldq5kUE4+ZJsFGG4hynztwXshcy/k9bQI2w3fTuGgM6uuQxRJSOOLblBxGmwttvX 6ObT/mTHJrbFbtwzC54qYBKi1loB1Z+dG0bHcvTXIprLQxPB197udhKRq2EW3gmhA3uP1y u7+Ew++Ten+gZRWv6Xtxl8yNWvRDCd4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1670247986; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ceXqC6XPscRO01rWuJmTKdfnvTAbVI2iz2SMsMFA4FE=; b=uG2m/KwulJazcFbgeJqhuRpYqGrk/TAbKlhHCjPhM3BKF+Q4YL6nn/NVjOMVrTTKT5KZWB L/A5xqh7zkUczABA== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id CAD2813326; Mon, 5 Dec 2022 13:46:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id VoJuMDL2jWNxeQAAGKfGzw (envelope-from ); Mon, 05 Dec 2022 13:46:26 +0000 Message-ID: <83618407-1683-8805-58d9-c7ac27263ddc@suse.cz> Date: Mon, 5 Dec 2022 14:46:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] testsuite: support mold linker Content-Language: en-US To: Jan Beulich Cc: binutils@sourceware.org References: <76253e84-a7c3-5d09-c6a7-422573ca2d37@suse.cz> <390e89b4-f7ca-8147-60df-fa1094ded1eb@suse.com> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: <390e89b4-f7ca-8147-60df-fa1094ded1eb@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/5/22 13:22, Jan Beulich wrote: > On 05.12.2022 13:10, Martin Liška wrote: >> --- a/binutils/testsuite/binutils-all/objcopy.exp >> +++ b/binutils/testsuite/binutils-all/objcopy.exp >> @@ -652,8 +652,8 @@ proc strip_test_with_saving_a_symbol { } { >> >> set exec_output [binutils_run $NM "$NMFLAGS $objfile"] >> set exec_output [prune_warnings $exec_output] >> - if {![regexp {^([0-9a-fA-F]+)?[ ]+[TD] main} $exec_output] \ >> - && ![regexp {^([0-9a-fA-F]+)?[ ]+T _main} $exec_output]} { >> + if {![regexp {^([0-9a-fA-F]+)?[ ]+[tTD] main} $exec_output] \ > > Further below, for libbacktrace, you also include 'd' in the check (and 't' > was already there). Could you clarify why 't' alone isn't sufficient there, > but is sufficient here? Yeah, it is sufficient. > >> + && ![regexp {^([0-9a-fA-F]+)?[ ]+[tT] _main} $exec_output]} { > > While orthogonal to the purpose of the patch I still wonder whether you > wouldn't better take the opportunity and fold the two regexp-s (also > elsewhere): > > if {![regexp {^[0-9a-fA-F]*[ ]+[tTD] _?main} $exec_output]} { Yep, works for me. > > (with a simplification to the earlier part also included). Looking at > strip_executable_with_saving_a_symbol, which you also adjust, the [TtD] > vs [tT] difference looks to be accidental rather than deliberate. Correct, D is really accidental value here. Lemme send V2. Martin > > Jan