From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: Using the vcs_to_changelog.py script
Date: Sat, 15 Feb 2020 07:26:00 -0000 [thread overview]
Message-ID: <83o8u0nwet.fsf@gnu.org> (raw)
In-Reply-To: <3dc19ede-66d8-e329-3fc8-e0e88c25ef93@polymtl.ca> (message from Simon Marchi on Fri, 14 Feb 2020 16:07:59 -0500)
> Cc: binutils@sourceware.org, gdb-patches@sourceware.org
> From: Simon Marchi <simon.marchi@polymtl.ca>
> Date: Fri, 14 Feb 2020 16:07:59 -0500
>
> >> - What's the problem you're trying to fix (compilation error? if so please
> >> paste it in the commit log?)
> >> - Why is this the right way to fix it?
> >
> > Something like that, yes. I'm saying that we should have this on the
> > wiki.
>
> I think it's already quite well addressed by this section in the contribution
> checklist:
>
> https://sourceware.org/gdb/wiki/ContributionChecklist#Detailed_Explanation_of_the_Patch
That says the ChangeLog must be part of the patch, and the text
doesn't specifically address the lack of detailed information about
what was changed where. So I think the text may need to be amended to
address the issue at hand, especially since most veteran contributors
came to rely on the ChangeLog-formatted part.
prev parent reply other threads:[~2020-02-15 7:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 23:33 Simon Marchi
2020-02-13 1:03 ` Alan Modra
2020-02-13 2:29 ` Jeff Law
2020-02-13 3:13 ` Simon Marchi
2020-02-13 14:13 ` Eli Zaretskii
2020-02-13 3:37 ` Eli Zaretskii
2020-02-13 14:19 ` Simon Marchi
2020-02-13 15:42 ` Eli Zaretskii
2020-02-13 16:26 ` Simon Marchi
2020-02-13 18:58 ` Eli Zaretskii
2020-02-13 19:09 ` Philippe Waroquiers
2020-02-13 19:29 ` Eli Zaretskii
2020-02-13 20:56 ` Simon Marchi
2020-02-13 21:07 ` Simon Marchi
2020-02-14 9:45 ` Eli Zaretskii
2020-02-14 19:31 ` Simon Marchi
2020-02-14 20:16 ` Eli Zaretskii
2020-02-14 21:08 ` Simon Marchi
2020-02-15 7:26 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o8u0nwet.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).