From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130108 invoked by alias); 15 Feb 2020 07:26:34 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 130086 invoked by uid 89); 15 Feb 2020 07:26:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:940, H*MI:sk:3dc19ed, H*f:sk:3dc19ed X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 15 Feb 2020 07:26:31 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j2rqO-0003E2-V1; Sat, 15 Feb 2020 02:26:29 -0500 Received: from [176.228.60.248] (port=1741 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j2rqO-0003f3-7C; Sat, 15 Feb 2020 02:26:28 -0500 Date: Sat, 15 Feb 2020 07:26:00 -0000 Message-Id: <83o8u0nwet.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: binutils@sourceware.org, gdb-patches@sourceware.org In-reply-to: <3dc19ede-66d8-e329-3fc8-e0e88c25ef93@polymtl.ca> (message from Simon Marchi on Fri, 14 Feb 2020 16:07:59 -0500) Subject: Re: Using the vcs_to_changelog.py script References: <83imkbqhry.fsf@gnu.org> <83a75mqyry.fsf@gnu.org> <675991ee-28c0-ce5a-6327-c6ad80ccb1c3@polymtl.ca> <837e0qqpps.fsf@gnu.org> <83blq1pknp.fsf@gnu.org> <83pnehncwe.fsf@gnu.org> <3dc19ede-66d8-e329-3fc8-e0e88c25ef93@polymtl.ca> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-SW-Source: 2020-02/txt/msg00374.txt.bz2 > Cc: binutils@sourceware.org, gdb-patches@sourceware.org > From: Simon Marchi > Date: Fri, 14 Feb 2020 16:07:59 -0500 > > >> - What's the problem you're trying to fix (compilation error? if so please > >> paste it in the commit log?) > >> - Why is this the right way to fix it? > > > > Something like that, yes. I'm saying that we should have this on the > > wiki. > > I think it's already quite well addressed by this section in the contribution > checklist: > > https://sourceware.org/gdb/wiki/ContributionChecklist#Detailed_Explanation_of_the_Patch That says the ChangeLog must be part of the patch, and the text doesn't specifically address the lack of detailed information about what was changed where. So I think the text may need to be amended to address the issue at hand, especially since most veteran contributors came to rely on the ChangeLog-formatted part.