From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id B4FFC3858421 for ; Tue, 20 Dec 2022 12:59:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B4FFC3858421 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=harmstone.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x433.google.com with SMTP id a17so10491422wrt.11 for ; Tue, 20 Dec 2022 04:59:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=jx5w/9Eayh+Mz1e+SLB87AP6BlKAO6eioCymUnNlYWA=; b=H9hkyhGkNQgZinZeKbtMsKlfhQN1P0gUpp6l0or1WTAHKM00V+BkrHq3gi+kHOS/Eb 5COpnIPDAIm0KpPFerClZYO2dmCkSM59JkIky5gm1DdvXe3wvfw9eIHjYXug0f0T8J2B PocDfz4ICdYINiZ3vEgAv67xGhc2YlStetkSyub9gfKppphMfR1xI8C6NAdMJcnSr2wK jk9moiSosn4ZOG8zgHUbxj7qgZz4qPtTM04VGx7FZVcLhJ5dnEUDBgncyzd0ArHWEiTO zYUnBhNwgrUJUBqZTJL4SmUdfc+L5F2RLBRVCkAvWikEMNDrRkRYKujNNAZw00XGc1Jn nSRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jx5w/9Eayh+Mz1e+SLB87AP6BlKAO6eioCymUnNlYWA=; b=Qy/2ybvdlYMPC9q2HuZSlgHCrWLmpx/bn0OCCNeTxUK1FTugsJxA3TiuzBX5pkbhcr fkdPangC/81KnBC6XxgPPM+rHTu1nwvyfuBzSTqAfd2yPBPGnKEI5ZFuQ+s1PwmQ2EUc 5UU+VzbzdpclIMyORnbb09ZyxuuDcGYAbUX6dy6UEJlzs8bRUYKPGwkM83+AW4lQDrr0 pWIbNK5yOZRGqvlfKeDEa/5Ed2MHKRSI8TPfh0R7LN/Pjt8iHwMCq0JdUToXyXAi0fhd +p1wodVoPZqF/Fg/nhgBvfUOLdKEI/1Zq5vn3e9qiZBcMJkke4/KsEjjvrT8WxeK0kVU iP3Q== X-Gm-Message-State: ANoB5pkIw3H/annq3SFsnfxgELwcDUoxK7gCE1Zj7gNFcOCM1c1W5ihz DrhWqvnXs3NT2hc5uedjmjC77j3WHM8= X-Google-Smtp-Source: AA0mqf4MAg7It2s71KL679ZCBCu9I3mQVdBEouOGHhU3Q5SfILzWgeUE90rFC9i6sd/QRyrAZkqo8A== X-Received: by 2002:a5d:6591:0:b0:242:1ce4:bf47 with SMTP id q17-20020a5d6591000000b002421ce4bf47mr25661216wru.59.1671541156324; Tue, 20 Dec 2022 04:59:16 -0800 (PST) Received: from ?IPV6:2a02:8010:64ea:0:8eb8:7eff:fe53:9d5f? ([2a02:8010:64ea:0:8eb8:7eff:fe53:9d5f]) by smtp.googlemail.com with ESMTPSA id i13-20020adfefcd000000b0024216d2e386sm12813964wrp.16.2022.12.20.04.59.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Dec 2022 04:59:15 -0800 (PST) Sender: Mark Harmstone Message-ID: <8415bffa-94a6-9570-f0e4-ddc02906c5f8@harmstone.com> Date: Tue, 20 Dec 2022 12:59:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 1/5] Fix size of external_reloc for pe-aarch64 To: Tamar Christina , Jan Beulich Cc: "binutils@sourceware.org" , "wej22007@outlook.com" , "zac.walker@linaro.org" References: <20221216021400.22309-1-mark@harmstone.com> Content-Language: en-US From: Mark Harmstone In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 16/12/22 10:47, Tamar Christina wrote: > > The code was taken from the Arm port which weirdly had a different size > for this whether it was a WINCE target or not. For WINCE target it has 10, but for > everything else 14 (See include/coff/arm.h). Since I didn't have relocations > support anyway (the original intention was only to support objcopy workflow) > I didn't dig too deeply into why Arm has it as 14 and the extra field. > > That said 10 looks to be the correct value. > > Thanks, > Tamar Thanks Tamar. Sorry, I should have copied you in in the first place. I can't remember the specifics, but I definitely needed this patch to get EXEs working on Windows. Mark