From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id E1A7F3858015 for ; Thu, 11 Jan 2024 14:05:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E1A7F3858015 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E1A7F3858015 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::336 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704981905; cv=none; b=oMsvYzeTBMIOb5CDcBm51BaBhXrhxNvhxAJs8hhSNtuB+0VYCMu5mKLhlOFKZHEO3exLcYCsOcEDEztz8+GG8rwtyP0YqX1kTGWuA8imjolBfyvnEZNVge8oyX5F83xaKlddM04QEoxbp5TBLdsr4Pto+TFpSM8mbRUo8JRnWio= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704981905; c=relaxed/simple; bh=9TFpsCYQjACHId7DQJVfcY++pQAevf9qqt15hzOinIU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Cd/mK9pewXwhV966nGKZH5DARIBTNzzAasWPzUubkzSl7hVbKPswuKDX7+TaoXIMyCVUla27++Z1QMYTGhixjOpXFtqt5rXa8g/ulxJq92xWEWPC/B59kLrhKB9QSrHFzy+Ecr4Q7q9t73uheEGCsHFGpCA7rYnGwGtpYJxi8oQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-40e6275e897so2330935e9.3 for ; Thu, 11 Jan 2024 06:05:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704981901; x=1705586701; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=a34EsCgKcI9N8ZWmHbxgTCJ13v1UYT2+FwTUWYDF//M=; b=FQ35PStjgejE/RFX0rFMPIXjvyc0VZTAQQcWgXUFpN8W7GDCDYBh2chuvTNGmjCtZ7 F+8/yW8ryxro8wtJYOQWK+NjagfIH6M5umBavjnc4P4lDrEa92oxkaDBXDk18U+d2B78 JCMkcMvKtbZIJvKih54qg+yFHAfGMs7KKF8K1O4oFkwHcjRr0c/4lTSRDTyEIl3lkW99 Ke2iH5lYeY8dtnKTxtpCzc4sYr1EVTXEqG9/VINJ6iKi4VoKgqYzqESUBCw8ZBqcDVsw U4sfh7xGHSM19NolC8UONWWq+3ext7wrWyHeV2i9WcyXwYxVwWjCIQk+NzdU2i9uv1QR TulQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704981901; x=1705586701; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a34EsCgKcI9N8ZWmHbxgTCJ13v1UYT2+FwTUWYDF//M=; b=Txx5YMrkBOsNiREU5fXv2GiH6otJ+Hqoi7qrH/pTfdZCQnBcCX7JxOnmT234D91Y5O hekLfccMkGvL1mMGCJBaGENssU1cvfcj4sFpE3W+9ne+JIfm/Wo/ZllwAjoDYnPJLi0P 9y/2qKXERrP00xndxz1xYngG0snipMd8KAh5uesC2ulMJ4HIPplt/gaHaWd5LRFBRzAU 2ydjGhCUOCLINjR8RydMuZuFtnTn13ueOKpgoTxnKTXD7ApJksHX9GM5TcMqbyVTtaXB XMMMOgIl0olhezj795e+G3IbesU3Qkh858trT/eK2EIpOL3ANEnL8RO2JPTeS5Cajp2l Rr+A== X-Gm-Message-State: AOJu0YyWZANExqvM19PzZqWzhTYD+QpbGpCf5brlkZvStrSaTeKMyyQH A6kJsONyp2/A0poHPGJrYiI3oRTK0yJV X-Google-Smtp-Source: AGHT+IHqP9bCXEjXtPpnWul4fk8qj18641QoohlWu+qDwNqSVqo+9IcJWcEbVjh17llX02XRWqt0ng== X-Received: by 2002:a05:600c:3546:b0:40e:3d34:3eb6 with SMTP id i6-20020a05600c354600b0040e3d343eb6mr434208wmq.0.1704981901687; Thu, 11 Jan 2024 06:05:01 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id m21-20020a05600c4f5500b0040e4733aecbsm2069912wmq.15.2024.01.11.06.05.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jan 2024 06:05:01 -0800 (PST) Message-ID: <8476f39c-1a6e-44e2-a1b7-e8a0ee7b5754@suse.com> Date: Thu, 11 Jan 2024 15:05:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] opcodes: i386: fix dw2_regnum data type in reg_entry Content-Language: en-US To: "H.J. Lu" Cc: "Kong, Lingling" , "binutils@sourceware.org" , Indu Bhagat , "Cui, Lili" , "Hu, Lin1" References: <20240109011229.4191052-1-indu.bhagat@oracle.com> <1cf65034-171c-44e7-bb7d-022f35451cb0@suse.com> <341075aa-2e7b-4043-8239-fc912149b080@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3025.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11.01.2024 14:27, H.J. Lu wrote: > On Thu, Jan 11, 2024 at 12:05 AM Jan Beulich wrote: >> >> On 11.01.2024 08:59, Kong, Lingling wrote: >>> >>> >>>> -----Original Message----- >>>> From: Jan Beulich >>>> Sent: Thursday, January 11, 2024 3:43 PM >>>> To: Kong, Lingling >>>> Cc: binutils@sourceware.org; Indu Bhagat ; Cui, Lili >>>> ; H.J. Lu ; Hu, Lin1 >>>> >>>> Subject: Re: [PATCH] opcodes: i386: fix dw2_regnum data type in reg_entry >>>> >>>> On 11.01.2024 02:35, Kong, Lingling wrote: >>>>> >>>>> >>>>>> -----Original Message----- >>>>>> From: Jan Beulich >>>>>> Sent: Tuesday, January 9, 2024 4:25 PM >>>>>> To: Indu Bhagat ; Cui, Lili >>>>>> ; H.J. Lu ; Kong, Lingling >>>>>> ; Hu, Lin1 >>>>>> Cc: binutils@sourceware.org >>>>>> Subject: Re: [PATCH] opcodes: i386: fix dw2_regnum data type in >>>>>> reg_entry >>>>>> >>>>>> On 09.01.2024 02:12, Indu Bhagat wrote: >>>>>>> The DWARF register numbers for the APX EGRPs start with 130. The >>>>>>> data type holding the same currently is signed char. >>>>>>> >>>>>>> ChangeLog: >>>>>>> * opcodes/i386-opc.h (reg_entry): Bump to signed short. >>>>>> >>>>>> So yes, something needs doing. But there are further questions to be >>>>>> raised to the original authors: Was the code tested at all in this >>>>>> regard? Why do numbers start at 130, when according to i386-reg.tbl >>>>>> 128 and 129 are unused (and would hence be more natural to [also] use)? >>>>> >>>>> This is because for some historical reasons, some numbers(126-129) have been >>>> agreed to be reserved. >>>>> Details can be found in https://groups.google.com/g/x86-64- >>>> abi/c/GS8LZf5nQFk. >>>> >>>> I'm sorry, there are no details there. There's merely mention of these four being >>>> reserved, without supplying any reason (historical or not). >>> >>> Sorry, you could see https://gitlab.com/x86-psABIs/x86-64-ABI/-/commit/6207f9a2c0645f20a7ec591a09e4c382b1675784 >>> There are reserved for Intel MPX (Memory Protection Extensions) provides 4 128-bit wide bound registers (reg{bnd0} - reg{bnd3}). >> >> Then why aren't these marked that way? The commit introducing them to >> opcodes used Dw2Inval, and it was never changed from that (i.e. there >> wasn't even deliberate undoing with respective justification). > > Leave them as reserved. We have plenty. Hmm, the latter sentence doesn't fir what I meant: Why does / did i386-reg.tbl not / never have those numbers? I could have seen that they were there and then possibly have been purged, but even then I would expect there a comment to have been left. So minimally what I'd like to see / do is to add such comments. Jan