From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 77C8B3858D33 for ; Thu, 18 Jan 2024 03:52:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 77C8B3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 77C8B3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705549969; cv=none; b=nV5k/n1HW2mkaSMjNSUQGSXJ4HRCAUV7HfhUtL7zBQVvHW/v7qS2pHhpFAjIyZ2xtR6RaXgtVsnzPoj0Oa6P/eQh72PLhtqnzRoMJ3pP7puZXN5IALLHU9uz1LTkVCqm3EmleokGPkc0sjEsrdU4y7xKgRmVmr4bCj09ApMqh+Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705549969; c=relaxed/simple; bh=8/ZCPyOUImRGN8F0OST+sglSkI5FgPp/vzPx2WDkLqY=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=hgoU/giqUQRVJ6nbg58CLsmCjVCceaixrHd5qhm1lUFCVZJaDxVHbXIwzN11dH4FGxTiG0qNDIoH543f+rhVhcMKC5ZbTuhK9xrayEDRK5AdAFuwjylIZvVWdNG8qfjwwixYjfMJZQ09kkyy5dTk+W+wPJ1oyvEpc04u3+6O+Ow= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1705549966; bh=8/ZCPyOUImRGN8F0OST+sglSkI5FgPp/vzPx2WDkLqY=; h=Subject:From:To:Date:In-Reply-To:References:From; b=DMx/2m+L0a+uzcW24C4QDbhtm2EoKFmTI0rOo4wyB+bLOjUPHRUL9kSn9/JIOvNm0 praub2wKDBFwCrAJXZ6fNtj5AG9tWUqYVRMI44KheLSmuRcpqhK4sJGOxJrBRJm7mn 1KvnbX+6+dTrL6mTJKbGfwbLi2Ci2dBOaT9vdffk= Received: from [127.0.0.1] (unknown [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 0D05266F1D; Wed, 17 Jan 2024 22:52:45 -0500 (EST) Message-ID: <84ec27c38c341281007925ccb1926a65bda04479.camel@xry111.site> Subject: Re: [PATCH] Fix 30808 gprofng tests failed From: Xi Ruoyao To: Vladimir Mezentsev , binutils@sourceware.org Date: Thu, 18 Jan 2024 11:52:44 +0800 In-Reply-To: <53a49f57-ca0d-40aa-4faa-bf81c22fbf89@oracle.com> References: <20230901200419.3277274-1-vladimir.mezentsev@oracle.com> <53a49f57-ca0d-40aa-4faa-bf81c22fbf89@oracle.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 MIME-Version: 1.0 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: =E5=9C=A8 2024-01-17=E6=98=9F=E6=9C=9F=E4=B8=89=E7=9A=84 16:49 -0800=EF=BC= =8CVladimir Mezentsev=E5=86=99=E9=81=93=EF=BC=9A > On 1/17/24 03:24, Xi Ruoyao wrote: > > On Fri, 2023-09-01 at 13:04 -0700, Vladimir Mezentsev via Binutils wrot= e: > >=20 > > > diff --git a/gprofng/testsuite/config/default.exp b/gprofng/testsuite= /config/default.exp > > > index 1c862d54592..c4a6588bb64 100644 > > > --- a/gprofng/testsuite/config/default.exp > > > +++ b/gprofng/testsuite/config/default.exp > > > @@ -32,17 +32,25 @@ if {![info exists CFLAGS]} { > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 set CFLAGS "-g -O2" > > > =C2=A0=C2=A0} > > > =C2=A0=20 > > > +remote_exec host "sh -c \"rm -rf tmpdir; mkdir -p tmpdir\"" > > > =C2=A0=C2=A0if { "$CHECK_TARGET" =3D=3D "check-install" } { > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 set ::env(GPROFNG) "$PREFIX/bin/gprofn= g" > > > =C2=A0=C2=A0} else { > > > -=C2=A0=C2=A0=C2=A0 set ::env(GPROFNG) "$BUILDDIR/src/gprofng" > > > +=C2=A0=C2=A0=C2=A0 # Make a temporary install dir to run gprofng fro= m, and point at it > > > +=C2=A0=C2=A0=C2=A0 remote_exec host "sh -c \"$MAKE -C .. install-gpr= ofng MAKEFLAGS=3Dprogram_transform_name=3D DESTDIR=3D$BUILDDIR/tmpdir/root\= "" > > Unfortunately this has bring back PR29107.=C2=A0 I've created PR31252. > >=20 >=20 > I cannot reproduce the problem on the master branch ( OL8 / x86_64 ). > I did: >=20 > mkdir bld_x86_64 > cd bld_x86_64 > ../configure --prefix=3D/usr --with-system-zlib --enable-shared=20 > --disable-{gdb,gdbserver,libbacktrace,libdecnumber,readline,sim} > make -j16 -O tooldir=3D/usr V=3D1 2>&1 | tee make.log > make -k -j16 -O check 2>&1 | tee make_check.log >=20 > I see errors but they are not related to 30808. But they are likely caused by the change. I think I (and Nick) have explained the issue well in https://sourceware.org/bugzilla/show_bug.cgi?id=3D29107: if you run "make install" in the test suite, libtool will relink some shared libraries and the other test suite using these shared libraries will error out with messages like "file too short" or "undefined symbol" while the shared libraries are being overwritten. So you shouldn't run "make install" in the test suite, period, no some sort of "but I need it" things. --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University