* (patch) hpjyg07: include/hp-symtab.h [not found] <Pine.LNX.4.10.9911031800380.19860-100000@hpcll168.cup.hp.com> @ 1999-11-03 18:09 ` Jimmy Guo 1999-12-15 1:05 ` Jeffrey A Law 0 siblings, 1 reply; 5+ messages in thread From: Jimmy Guo @ 1999-11-03 18:09 UTC (permalink / raw) To: gdb-patches; +Cc: binutils This patch is sent to both gdb-patches and binutils. 1999-11-03 Jimmy Guo <guo@cup.hp.com> * hp-symtab.h (HP_LANGUAGE_FORTRAN): Declare, replaces HP_LANGUAGE_F77. Index: include/hp-symtab.h /opt/gnu/bin/diff -r -c -N /view/guo.wdb.c//CLO/Components/WDB/Src/gnu/include/hp-symtab.h include/hp-symtab.h *** /view/guo.wdb.c//CLO/Components/WDB/Src/gnu/include/hp-symtab.h Wed Nov 3 13:15:36 1999 --- include/hp-symtab.h Wed Nov 3 13:16:18 1999 *************** *** 88,94 **** { HP_LANGUAGE_UNKNOWN, HP_LANGUAGE_C, ! HP_LANGUAGE_F77, HP_LANGUAGE_PASCAL, HP_LANGUAGE_MODCAL, HP_LANGUAGE_COBOL, --- 88,94 ---- { HP_LANGUAGE_UNKNOWN, HP_LANGUAGE_C, ! HP_LANGUAGE_FORTRAN, HP_LANGUAGE_PASCAL, HP_LANGUAGE_MODCAL, HP_LANGUAGE_COBOL, ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: (patch) hpjyg07: include/hp-symtab.h 1999-11-03 18:09 ` (patch) hpjyg07: include/hp-symtab.h Jimmy Guo @ 1999-12-15 1:05 ` Jeffrey A Law 1999-12-15 1:05 ` Jeffrey A Law 1999-12-15 8:42 ` Jimmy Guo 0 siblings, 2 replies; 5+ messages in thread From: Jeffrey A Law @ 1999-12-15 1:05 UTC (permalink / raw) To: Jimmy Guo; +Cc: gdb-patches, binutils In message <Pine.LNX.4.10.9911031804490.19890-100000@hpcll168.cup.hp.com>you write: > This patch is sent to both gdb-patches and binutils. > > 1999-11-03 Jimmy Guo <guo@cup.hp.com> > > * hp-symtab.h (HP_LANGUAGE_FORTRAN): Declare, replaces > HP_LANGUAGE_F77. I don't see the point behind making this change. Also note that it will break gdb unless you change hp-psymtab-read.c at the same time. Why are you making this change? jeff ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: (patch) hpjyg07: include/hp-symtab.h 1999-12-15 1:05 ` Jeffrey A Law @ 1999-12-15 1:05 ` Jeffrey A Law 1999-12-15 8:42 ` Jimmy Guo 1 sibling, 0 replies; 5+ messages in thread From: Jeffrey A Law @ 1999-12-15 1:05 UTC (permalink / raw) To: Jimmy Guo; +Cc: gdb-patches, binutils In message < Pine.LNX.4.10.9911031804490.19890-100000@hpcll168.cup.hp.com >you write: > This patch is sent to both gdb-patches and binutils. > > 1999-11-03 Jimmy Guo <guo@cup.hp.com> > > * hp-symtab.h (HP_LANGUAGE_FORTRAN): Declare, replaces > HP_LANGUAGE_F77. I don't see the point behind making this change. Also note that it will break gdb unless you change hp-psymtab-read.c at the same time. Why are you making this change? jeff ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: (patch) hpjyg07: include/hp-symtab.h 1999-12-15 1:05 ` Jeffrey A Law 1999-12-15 1:05 ` Jeffrey A Law @ 1999-12-15 8:42 ` Jimmy Guo 1999-12-15 10:41 ` Jeffrey A Law 1 sibling, 1 reply; 5+ messages in thread From: Jimmy Guo @ 1999-12-15 8:42 UTC (permalink / raw) To: Jeffrey A Law; +Cc: gdb-patches, binutils > > 1999-11-03 Jimmy Guo <guo@cup.hp.com> > > > > * hp-symtab.h (HP_LANGUAGE_FORTRAN): Declare, replaces > > HP_LANGUAGE_F77. >I don't see the point behind making this change. Also note that it will >break gdb unless you change hp-psymtab-read.c at the same time. >Why are you making this change? We've added Fortran 90 support and this change is to cover Fortran90 as well. But it could be that hp-psymtab-read.c needs change at the same time ... I thought I tested each patch but one can never be sure. - Jimmy ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: (patch) hpjyg07: include/hp-symtab.h 1999-12-15 8:42 ` Jimmy Guo @ 1999-12-15 10:41 ` Jeffrey A Law 0 siblings, 0 replies; 5+ messages in thread From: Jeffrey A Law @ 1999-12-15 10:41 UTC (permalink / raw) To: Jimmy Guo; +Cc: gdb-patches, binutils In message < Pine.LNX.4.10.9912150840410.29519-100000@hpcll168.cup.hp.com >you write: > > > 1999-11-03 Jimmy Guo <guo@cup.hp.com> > > > > > > * hp-symtab.h (HP_LANGUAGE_FORTRAN): Declare, replaces > > > HP_LANGUAGE_F77. > >I don't see the point behind making this change. Also note that it will > >break gdb unless you change hp-psymtab-read.c at the same time. > > >Why are you making this change? > > We've added Fortran 90 support and this change is to cover Fortran90 as > well. Ah yes. That makes perfect sense. > But it could be that hp-psymtab-read.c needs change at the same > time ... I thought I tested each patch but one can never be sure. grep HP_LANGUAGE_F77 will show one use in hp-psymtab-read.c so it should be updated to the newer name. I'll take care of that. It probably does not matter for this specific patch, but in general if we can keep compatibility we should. I went ahead and updated the patch so that it provides by HP_LANGUAGE_FORTRAN and HP_LANGUAGE_F77. The changes should appear in the next gdb snapshot. Thanks, jeff ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~1999-12-15 10:41 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <Pine.LNX.4.10.9911031800380.19860-100000@hpcll168.cup.hp.com> 1999-11-03 18:09 ` (patch) hpjyg07: include/hp-symtab.h Jimmy Guo 1999-12-15 1:05 ` Jeffrey A Law 1999-12-15 1:05 ` Jeffrey A Law 1999-12-15 8:42 ` Jimmy Guo 1999-12-15 10:41 ` Jeffrey A Law
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).