From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 051EA385840D for ; Tue, 19 Dec 2023 21:02:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 051EA385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 051EA385840D Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1703019748; cv=pass; b=MtLNOo9syhpL1GtqepPAeXbLXMBJ3YGuFoe5cfMJ7l8IJ54SC69RHqQa0AstzmWypSPHDZ9igvDlcGlyW7SAT5ETQ8udHQMLkvSxnGptXq0TZfNtdvV72yWHNThWd2K60P9r0FH0YAeHNDqdrIIg5hGzOQPfOGQUqSCkHNPsGg0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1703019748; c=relaxed/simple; bh=8PoBjyt8PMlanVJ/B2i2ErrwBvowZ+Hf1UCZuOeI1rA=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=i0//8Srfa6nZCzeA74cHHWaVFZ0s3Vr/JoloemkWVLkqQYg7TIbI4pzuxPCmNTvC570Q7rBlOzWvdNAxTGZa62+0neERhDBE8/8kXQurYhFaZhrJgEIMXjeQlmPm8Tg+oATKHYHmPzJI8z3Y/v9B4aSG8ExbGKKArYb7gXksPeY= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3BJImvFL028253; Tue, 19 Dec 2023 21:02:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=Xn0ndQ9J2qVA1GF3GEWS5d2TS6u5ICBHoTg8vPL/ZlA=; b=SVtUaCJ9VmKixO8ohKfdnz+qCiXQpEz/DceChbsyb3Yk+zsgLu9LRt/0NImTQzXirFuV eywVXtnhGbsifi0HKkHXCGA3nfFPrNTnFGrzhS6kQ+ec7JEnE+i5XHUL0BrqKw/CSSbT XhUhu/RTbdsqFW09S15jJ0F1yC0lz6pUWuiZfEkNRI6HLfcETCTXMeSqi6Z9S9Ooz896 1C5lXdUjPf/7LBeRIlXDJVzCoVpk45PSeIAVaRnrJz6SEAG510R9edO0t6d7Ee3TWnff EsREiyLEKZfvwRuUkTxK0UvvJAP9LkSQragm8AbVNvst1tpwGJtRa0HljXzawd2iuWXc Hw== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3v13guey76-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Dec 2023 21:02:15 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3BJL0RnN020993; Tue, 19 Dec 2023 21:02:14 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2168.outbound.protection.outlook.com [104.47.59.168]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3v12b7ntj6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Dec 2023 21:02:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lZSHyJyZPNj2rBzOxXzN4FFeQ4yZTxd473LMpzxFUcJFKyB9nYhtopqLu3lrR1muHwQxwyA7lk8eplO3+L2Xlnz0Hx1Cl0zl4BNlb1dosQFfTUfCNIFmqbY+cglwAcfQppk2EXLY1ogXa+HvQxq19w3V7T8CuzEEY6W+ZmMUK7u842eetiWCjuvYR5PkEUoFyFhE4sYPu6aqEZOjKABv1WoUUvUvGxMmjCdM0k5E/vG1KzHbG1enQ3bUU8i22RbXG3jd77ZN+BTaNNQRzFmQ+kumsgPrPMtdPqs5Lsuw60u2rrcC8Zs9BEChLwfSgjgfufp+zJ3WVpGoIp9E134BvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xn0ndQ9J2qVA1GF3GEWS5d2TS6u5ICBHoTg8vPL/ZlA=; b=GvGR9AqHtKUFVxXXSZioiRWS20BhKXnhlhRWLETA8Zj2niPc+gzelRN4MxyDKVg7KdjZxVG+a6vNa72JG9eWLxlfdIJkyHT5/4H08e/RntiNK9pt+7wfCQ1eSEIBQxQU2I1gbhCzt6Dp/0Hk3sCpS/UaGKYZ4uN9CbCMq8IinsJOAHGiFbTCy+pqC3aHCt8cjn/1EYGgX1zi0OovNz8n9ZmidGETVRuhPdGHSWSRNpo8UzllqBXW/JD1O6i9zP++eFAV4z7PbMEctfLbEC4E80ELLXEcBT76yxS59O/e2zHvyLIwIys8Ru5kuX5cHlS3EbXRRCOD5711MXPGXvlIiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xn0ndQ9J2qVA1GF3GEWS5d2TS6u5ICBHoTg8vPL/ZlA=; b=ZWmJNWAi4Ly0rj/nVADhB2Nfuq0Hts/YZnvFgvwS+N/Mtuz+OpcY1I6wUYrar7xY7Z2c3oqlw0GNREQFp5AEZ18hE1ZkHy2C2Csef/MtG9x8j1ARZ4AMfWogFtpWs9itZC8R3PAzmQXjCF0ZBNf8YbPrgjXq84vOs8ibJ7w9VQU= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by PH0PR10MB5659.namprd10.prod.outlook.com (2603:10b6:510:fe::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Tue, 19 Dec 2023 21:02:12 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::88e2:4a2e:3111:e04]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::88e2:4a2e:3111:e04%7]) with mapi id 15.20.7091.034; Tue, 19 Dec 2023 21:02:12 +0000 Message-ID: <852395fc-2cf3-4863-953e-adedddc0c573@oracle.com> Date: Tue, 19 Dec 2023 13:02:10 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH,V3 00/13] Synthesize CFI for hand-written asm Content-Language: en-US To: Jan Beulich Cc: Nick Clifton , binutils@sourceware.org, "H.J. Lu" References: <20231211060359.3561062-1-indu.bhagat@oracle.com> <6db8b80a-ce1f-4f5d-9c3d-02ae76235903@redhat.com> From: Indu Bhagat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0143.namprd04.prod.outlook.com (2603:10b6:303:84::28) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|PH0PR10MB5659:EE_ X-MS-Office365-Filtering-Correlation-Id: ce748eb6-9d63-4b35-4b38-08dc00d5c582 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1fnCoo3IsKlEy/76vgm70dTn7HO7oRdCKUxYysrlpmxAnfvznoI2zUXp3ybOSHdHxBN+qpBSqekZ6dpiJltogVrZ4YU0T442x6Pthsmg/OyBUR2pnUi3Xxfy9E4G+ejpRdpLb1TxXJ0AvQ6Mik8Xpe1iHO/+ckhhjptAVwtesY1aHkAb83X0pHezqn440UEUaVAnPyrpntyoxRSmRny9+fkhg/VRYBSmkhQWLBRN/75OkmTriMMryZGuWG03MER0u83PKMs8bHCzq5XrgCUzHYbXrOGnkzqusAdZlQ9K5xjEC9BM23fTZf3w7Y/lkvee0pNQHyB/nd8VKMZHcghQognLAKjgt30XJL+14gNm6Wqi/8HuapllnLA/RE/VcwdeSUv2VROISkdpee8JB+oBxoN7wnsgZdlAvbmxSd+gmBkxOXwY7z42EtJiP9A3OmMplAjIRktcC+w5pR14q4+NvyaYWJK4vHhKxFlEP2TWstVh8YPxwZ1m6x0I9EnVQpWyOTYz4z0GagYrA6mZChAF74A6dFdRKoxVymv0guS3/zFJiaSmExQJeYPRLRL6jxDSAe9fuPKzsohxZYMvrGm6qT421eUjY1jgtsSijfmqanv64nQmvvLs3ue6Ugk+xr1Z2AwV6lyXVF4zE7J8wgOkEN9LCWERCiQKKknbp9+ZdSvZWIoHkIoIoNIDy0lknfi3 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(376002)(39860400002)(366004)(136003)(396003)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(31686004)(36756003)(66899024)(66556008)(2616005)(6506007)(478600001)(2906002)(53546011)(8676002)(4326008)(316002)(54906003)(8936002)(6512007)(66476007)(66946007)(6916009)(6486002)(5660300002)(41300700001)(44832011)(31696002)(38100700002)(83380400001)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDNzTW15YXJadkJZMEtqRVN0YjA0RHVqNUlmamRSVWdvYkNRNUx4TkZ4NGVG?= =?utf-8?B?YnJsNitYYlJrdm9ZUG01VlhVVkFUUnRLaUsvSVNsbW5NYmc5MFBmOWQxMUxU?= =?utf-8?B?SHhwQnBsUmlsYkttUEY5YWxUa0QrNHVvcU5OTVBVclBRU0NUOUt3RW91N0wx?= =?utf-8?B?L0JKUkJ1bFpqTko1VmwrSjlHSkZTVjYzVVdIV3I0M2VzUmFtOUZ0QjRRdHNQ?= =?utf-8?B?bXR2K1VuSjJhQnJtNzNEZlhVQUlPY001bHdYQTJ3dXU3ckxrUDRpKzg5SkpK?= =?utf-8?B?S0xjdzA5NEI5UlpaRHM0Rm5VMTQ4SElaWG5iZHZOdmx5OERCZTBUQTNxa1pN?= =?utf-8?B?MEd3KytHSHM4c0V2RFlwM3V6Lys3TG5CeTVPVE9LTC9rM01ZT1lwZFdiZFpZ?= =?utf-8?B?UGRIdkxuZ3NNd2UrNFlydUNXSXFCYmpyVlorSlFaSytFaXVTdk05QmVBenU2?= =?utf-8?B?a3N3dGVJYk0ya05TeXNLNWQ1RkdsVTZzUkd4WXNXK3lmVlY5SWNtUVNsT0hC?= =?utf-8?B?d0JIMGs1KzQwcHZhVzl2R1cwa1hKZ0xWOFpBVTExRUhkZU5PUStJQWFVTEtx?= =?utf-8?B?N3M5R0Q3TG1pd0h6SU5VMzh0MHl5QWV2M1JjNmRVMXpHREdXRm42Q0RHaHE5?= =?utf-8?B?aFVEV1VJRmVyTUtLRmFpTnh3TW95d21oVkFRck5FSjNJajlqMkExOG1RSmhE?= =?utf-8?B?T3JTYjhSbGZGcFdwZVpGamlOZ3BKWjM4azBFTWRleEcxaTF2UmszeHdDVjJF?= =?utf-8?B?RlQ2clZ5S1pyNUFzRkFWUVQzTGZRYXZhQkw5cmgrK2xKSW9XRDNSSThDWU9z?= =?utf-8?B?NXI3MkpnVDZEdjBHY05QQWZmRU9BVWJhWlZNUW1NanBuak56WHRKNXFUTkEz?= =?utf-8?B?WjVtWDBaRldDRGl1c0M3TGJiMEx3OEpnVVhwT3VCMEpmQ2RqREdldXIxT21o?= =?utf-8?B?Z0tZMlpiZHo2ZjRseHFPZzZhWnhzUll3WVNySjV3dHFmZWNucXVmSGtYQThJ?= =?utf-8?B?NXRpd2dyQ3VsbmptS2RTVXZxaW5UYlVLZVhDZlhzcW1QZ3lPZ2ZrUXBjR3NY?= =?utf-8?B?WElEcFlwbHJpa2lTOC9Ta1h3ZE92Rnd6cUE2SFJzT3BjbloyazNqM21iSnYy?= =?utf-8?B?bHV5OFVIY1laemdXbE9YQjVtZFZHcDdPTUtPNFp2Qkc5akZFVThMUXFNR3Vl?= =?utf-8?B?dTY3RS82UUdveThLdFYrODhDVFd4NUg3VUlpaG90ZEtTVnI3d2VGOW5RTE8y?= =?utf-8?B?bnBwaWZmVUpQNENRNkRqRGRXaVRWV0ZqUnhDcTNVeFhVZFRFbjJUNlZWUC9m?= =?utf-8?B?NHkyUEFTOUxOc25mNlJxSklYTEU2YWE0Qy9GOHMyUm5RTktIN0tYT2JlWGpR?= =?utf-8?B?WUw3b1RnT09JbDhveTRmcVQrMVI5N3A3WjNLTmkraDZocG9PVnNlczdCS2RV?= =?utf-8?B?TUZyenF6K3N1Qk9tZXRLaTBmTHFIZXhTNmdITUpZWU5ISE82dTJLenBnZUJW?= =?utf-8?B?UlNUN2c0U2h5Z3JXa2R4VithSWxvczVpcW1obWFOdkhoeHB5YlFicjgvbHgr?= =?utf-8?B?alQ2ZVZpd094V0tYdFFCK2xyeHlyVkE0Y2h3bHRya2dPK0RGQzdxSE5EenZY?= =?utf-8?B?d3hzSlQ1QmFpQ1djQ0srU0dydnYzQnF0Z2RmRUM4bFFaTUJueW5CQkxlQkRy?= =?utf-8?B?eDlpb2dMeFBtU3FacThUY0FqaWtqL0ZuNHh0SVBBZGVkNGs3RVg3UkZYK2FE?= =?utf-8?B?Unc3MjRicHRJV09jRzVFQVBmT1dkeVUrdThxQThkSWVES21ScTFscUc4SWc2?= =?utf-8?B?eUlzRGJxY0t4SDA0a25WVUhVUlF0bnc4QnBXSmszc29WNTY1MnNJS1crZUth?= =?utf-8?B?MzFZTFBqU2pFREg4Z3VsWlVqZFNad2ZKeGZpN3JLY1UzcXM2SllFR2N3SEJJ?= =?utf-8?B?dHJQT2daNFlWeXFObUV0RUNEZENCVmgvSnE1cDYwSEJ5T2tpejV1YlUweTJO?= =?utf-8?B?YlRlT3NIUTdudEZHNm9KUWh1TGhjbjNFRkdmN1dWU0NDNFRpalJYY2F1RDNF?= =?utf-8?B?QWYwRFlrSE1DakRySitYMlhCbmFDdUxrajY5S0RCVXhkWnArSE1TOEM2K1ph?= =?utf-8?B?STVhWGRCTWtHcm1UTVh4TnZUeHBkRWN2RHlJWHlrZWFhMFlUYnZtbHRrVzVk?= =?utf-8?Q?IHKF49FokmoEpWE82jW1Q5Y=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: gEbwoHKS9VKLVz/tgeC6ct7ZMphV8PmDPuMC/JI8In8x9xR7XKNiIsy8iOzzEp+g5w9mS8tdjtWoYYT9ObSm3Z5jaWy1kg0dXpBgWViWi7AsYJGAmzeI6bRJtTxUi29+7ZPejNcLhqJnS2YqeWwZqlqkJT9s61nbKgIZ9Qw7ltBHkVuVlrbuMbvI1tyz76b8urzEHOTzsJHGHQ7RiJRrdILVoJRa/8kEc2QHv8hEyZMB/ilwg6AnCIgFDu2mRe+bOvoIdC3oGb2SqWLH01Oo+Ifc47ft8E4UMMc+ta2U7LithlPcSPBOLNy1rWHiFuDWIufjqgszrHKgXJAuUMCGLFh6QMCVsVUeT6OXaAeDlHbfpCV6cZcPeiWZRDmpjRNUgSeWiTbJxCE9olOcFuXIsWGCdjrOOPZk4nFG5MVI5yXAdIsxvDMoHhIazofkwhrtReySnIpPEGLk7GtcBDIlwOMJwR6E9i/eMklRUJFanSZscePLSHnEYPXtZlxd1C/aBFNhIKBHIAuYxRQk5ujnMJY9WrNAGF2PTmGfv/JytOmjC4nnDdGBkr8k7Qc0WhI3zIu7BViH5J19ykDTm+TeNXbkNkXIfXgX/x6v5PVGNpc= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce748eb6-9d63-4b35-4b38-08dc00d5c582 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 21:02:12.3541 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FPPX3/uRFmObZkMmp2AVwKzZyaoXMZ62fclJRGnneOTqoUpiO0kZ6p4Pzmh8VT+/X+ZImK+biJzVRr3wScT+/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5659 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-19_12,2023-12-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 mlxscore=0 mlxlogscore=718 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312190155 X-Proofpoint-ORIG-GUID: 1jQ7vNJoQ9q-wo4g-HLlJSA5WhJjRrNw X-Proofpoint-GUID: 1jQ7vNJoQ9q-wo4g-HLlJSA5WhJjRrNw X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/18/23 00:47, Jan Beulich wrote: > On 15.12.2023 10:13, Nick Clifton wrote: >>> This patch series adds support in GAS to synthesize CFI for hand-written >>> asm, acronym'd as SCFI. >>> >>> Previous postings: >>> - RFC patch series (https://sourceware.org/pipermail/binutils/2023-September/129560.html). >>> - V1 (https://sourceware.org/pipermail/binutils/2023-October/130163.html) >>> - V2 (https://sourceware.org/pipermail/binutils/2023-October/130210.html) >>> >> The patch series looks great to me. Series approved - please apply (with a >> small update to the 09 patch as already mentioned). > > Please can you hold off committing the x86 part(s) of this, until I got a > chance to look over them again? Furthermore, as expressed before, I'm wary > of these additions going stale the minute the APX patches are committed on > top, if your changes went in first. Despite APX work still being in flight, > I would much prefer if that went in first, and then you re-based your work > on top, such that the new MOV and ALU insns are covered right away. > There will still remain handling the newly added APX Push/Pop instructions as well. > While this is an unusual situation - new very general purpose insns aren't > introduced frequently -, I'd also like to see more formally addressed the > idea of ongoing support: From the original review I recall that you need > to minimally track insns altering GPRs, in order to avoid silently > generating bad CFI. Remember that I haven't looked at v3 yet, but as long > as that tracking is based on specific insns rather than a generalized > pattern, any ISA addition allowing GPRs to be altered would be at risk of > rendering the CFI generator code stale. Yet people, once they've started > to detect availability of this functionality, may validly expect that > their use of the functionality won't silently break behind their backs. In > this respect, did you consider constraining under what conditions the > generator code may actually come into play (at least for the time being)? > (Step 1) I propose that, for now, we add a check such that if any APX insn is seen for --scfi invocation, we bail out. IIUC, we could check using the is_any_apx_rex2_encoding (). (Step 2a) We can remove this check once there is support for all APX instructions for SCFI. I can add support for ginsns for APX instructions once the APX work is pushed. (Step 2b) Orthogonal to supporting the APX instruction set: For SCFI, it is ideal to add a way to raise alert if new instructions are added in the three categories (For APX, I see we have additions in #2, and #3): 1. Control flow instructions We can detect them by checking for insn.tm.opcode_modifier.jump. 2. Operations altering GPRs We can detect them by checking for: if (insn.operands && insn.reg_operands) { reg_op = i.op[insn.operands - 1].regs; if (reg_op) check if destination reg is REG_SP/REG_FP } 3. Operations with implicit update to stack pointer. Currently we have no marker, but how about adding something like unsigned int implicitstackop:1 in i386_opcode_modifier ? We will also need to ensure this property is correctly conveyed for all existing instructions in i386-opc.tbl. When new instructions are added, the SCFI machinery will be able to warn the user of missing functionality (and not generate wrong CFI). After this support for #3 is added to the backend, we will be in good stead for future ISA additions wrt SCFI. I can _try_ to accommodate 2b before the 2.42 release is cut. However, I think its best to plan for both 2a and 2b for 2.43 release (given the 2.42 is around the corner), if there is agreement. What do you think about this plan ? Thanks