From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id A44F73858D28 for ; Wed, 2 Nov 2022 06:24:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A44F73858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2A25ZR2C016271; Wed, 2 Nov 2022 06:23:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : references : from : cc : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=JjPsdTF8kpiTFCj5xnUvaHAXz8aZogPoIE6ykZLzgmE=; b=qOMG+YrP2t8f+H5ZOldWI6EWP3bTIYS+BcJaAwlB38V1ThR3s/fV7qx0Oldwsx4iOzb3 FFg6/wuGHy4ili/nizLFM8u/abARw9PZUEeOtXgUbLjPYFi+FMLYkaFOci0fmhoRzeLu 11JZckzTBZUy8Dxi5ejJofMfh+k+AMY0WlrKY+GrrJp5qCOtSu8TBNwDS2KpFGdwFLcf opdyPkYFtvA15OcDBSJRe5CXyXqK+qPeaGG33YvJkC+SjB8hLD6dyA76YeleI9KUL3yb d+nn0cQa1NledTyv1dzO5w8LI1JeVqB5irChDfvXefEf1QAebhZLI1UNcsfvbARxgc92 OA== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3kgussrkhp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Nov 2022 06:23:53 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2A257Hgn014245; Wed, 2 Nov 2022 06:23:52 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2177.outbound.protection.outlook.com [104.47.57.177]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3kgtmb7y4e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Nov 2022 06:23:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ks3YBuuOnOUOG3JXrwhXdMqfTe9l0xaSmm8kBH6PwzOf8XE82SzS3muVCx7gVqyOXBHFPPH44KQaGyOAAH2pOcixmkzT4Yq67Kmng6/YKPocCkUUdEtcBtwS87FYorQHih0KRT6oUWKLhmZ6m/tcTk6yl+T6jItSddyH640uQ+m/k2UjwJtoy0dPVHhSco27+lYfYK1+QMIcYXrrv8jc4gHqJaqzadB8fq4+7j4Od7m6wF4dn9ZErGYvK79Y5VRaC2ZJCgT/DDuhz2rJx970VkYkBlbXlLtawOEC/5pSd+fdns7e3EXgUy9fMm9sJSkJJIMp9qjHkXQ3/7sIDvC33A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JjPsdTF8kpiTFCj5xnUvaHAXz8aZogPoIE6ykZLzgmE=; b=S5Zm5Qny/GRWUs2hhHohotpvWHaOzkvE8q4nQLAsVhx2wkrG4OcgQWBBarl59e5oFURZMsqXEO/scc9QMX6rLdJPu1k395PeSNh9ZBMxAncFm3c6iQs1vJ9wdwYhOXqRK+mcoS8eMyt8AZqx/We38Gvl1lIrcDdq7Zezv0a034iwzqd1r6k9uZ6+zlqzJmGbBGmwSht2z9gkfZ/cH1ehjqQlu0kyQGg6weMN7rXcH/WUZRoBS2euqTlQbwWi4RjXcybPSduCR7yuVJjyyoxaQgu4K11I6iSGd1nYMd6xf6zFYeIo2rqy35Nd2xa46lJ4Bg6zVncHXquMQYQ8XfUnDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JjPsdTF8kpiTFCj5xnUvaHAXz8aZogPoIE6ykZLzgmE=; b=blb3Nv5fUjpEyb9kfjHnvjsIg77HnJ7vMM7RQcz/llLMjnwAZXrPxC6ggym0ND7PnwK0ekx/s8x8j7kh8Tz4qqBC51zI5NtZQcU0HtB8CiVFUjBElGEi3cFVWdpQrEraLLZKNqH/bucqjsObEJshjBLwK/7KyaeJ0biQh3k69N0= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by SJ0PR10MB5406.namprd10.prod.outlook.com (2603:10b6:a03:305::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 2 Nov 2022 06:23:50 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::a505:15c2:a248:efa2]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::a505:15c2:a248:efa2%7]) with mapi id 15.20.5723.033; Wed, 2 Nov 2022 06:23:50 +0000 Message-ID: <853cbf91-b2f1-d2b3-8f13-66a8d2e83a6a@oracle.com> Date: Tue, 1 Nov 2022 23:23:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH,V3 08/15] unwinder: generate backtrace using SFrame format To: binutils@sourceware.org, Mike Frysinger References: <20221030074450.1956074-1-indu.bhagat@oracle.com> <20221030074450.1956074-9-indu.bhagat@oracle.com> Content-Language: en-US From: Indu Bhagat Cc: "weimin.pan@oracle.com" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR02CA0001.namprd02.prod.outlook.com (2603:10b6:303:16d::21) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|SJ0PR10MB5406:EE_ X-MS-Office365-Filtering-Correlation-Id: bec737a8-b360-4dbb-5437-08dabc9ace70 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aa70ctihbPbZVj/r2gCDimfEa2FqvZus5nVsH+rsGFq9tmFieJsSa8IZirh9QLdOZBqgc6hLUqokvrJ5HKQI/k/eSvxCflrtMPXr/u9sLsvMnH/GeWILBJcnjxYGbP7mv8U/KfZiSd+8f16QN8nRQKEd/lO9uhvPddwLkaLrPbVeOehoCOJXSq4OCNvk8TaUl7nTDMJ5dIQ4zUZWagkL8dqZUHzE8b9s/2/4iwLvYe2gM7KjKIZN+3nQ7Z3ubP/J1fhhGo2c4j9ghWxuo0jDrHTz0rDsIE5OV9qX0OOYod6FE0ruO92+a/Ls3YIGEl7t2UB+rgQGUFk11MMtMEaHtU2Y4DS3rfk/q9vC0W6TmVtVDdaPG5WglkHkfI+GkwMEzDd1dH+41vduJbJo/lHOWdG9LVQQRIpQX7FNEz2mc4qhEVuVMRyTYm3NUrzGEvbehrfSKKN8QuHYanQKVXLSydeHjkEEn19Z7ve3886n9coqqlAmHR0q+5ESLDtCLJBM2ddnBP5V42V8Gnn3vFSyoYO30qJRuzQxJgaLYu3ZnKDVcP4KYX1PLTyhjAQHAvRZgA0crOARa9mFx+C9YMeZ4VurN6D+bE8Iiu1SnofefePX9PLgbQuyRoYkhwZ7/G33cZXuUBA8lMZjiETq1TNIyAoSrh9oSHLkYmOr9C1+A8B1rGv1TMc4etkqcZ/tZfLMQNWRwQPbNthJ05BoDI4ac+hw32wRqj2iQ52WVg6s3xc926Po9ZzYVvXZgpvvFxgYfIxOerTdyfovPVcfMk6ay3vlmBa3F5mzZ6UN333GV5s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(396003)(39860400002)(346002)(366004)(451199015)(186003)(2616005)(6486002)(478600001)(6512007)(86362001)(44832011)(36756003)(31696002)(107886003)(8936002)(2906002)(38100700002)(6506007)(53546011)(5660300002)(31686004)(41300700001)(316002)(6916009)(66476007)(66946007)(4326008)(8676002)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjZVK2dzL1I4L0Q3dGdaNm1vRXBPTXZqMkxrNEM3c0dFakxjcWc0Qnl6SXUr?= =?utf-8?B?R3hxNXNucDdLVG1LTlB5T2FYUVRiNU0yc0t1amxnL0hpRUJIdjUySVBOSHVw?= =?utf-8?B?eCtTMXoxU3ZXTWNrOEtnV0V3bUMxdFlPdVZwVThpR20vdTJZUnBIZjI2aXBh?= =?utf-8?B?RDlibE5MNmthdkNueW9pWFVKODF5VkJLbFQzODR4TUlVQ2d0eDRFZWxtYTda?= =?utf-8?B?YlFWcW45a1lpdHdOc0taa0JmcUFVMk84UjNlNlpPYUQrOXdSYUtUL0VIVGNP?= =?utf-8?B?MVdGNW9GanpqWnRxaHNIVFk5RFlqLzBzWDA4Q1VJeWYySHo5RHlqUjFsZGVR?= =?utf-8?B?TjZTNERJOGpKUWgrRDRVVC9XMkNTcTZwdXRyeHhCc0d3SVBSbHNueWlCQ1Zp?= =?utf-8?B?M3J0b0dOOHFRSm1WOEpGVklGTGdMV2d4TjgrbGh3OENVRm1WYzBvY0s1NlpZ?= =?utf-8?B?aHdoTnZrOTdkMFluQkFQSU1SQXM1dVRNbHJVMDl5NFZEWmNZWDRLV051WXFU?= =?utf-8?B?OHRxN3Fudlh4SEpES2c5UTc1aUVITnBTTEZyc21jN2xYaWswVTFzS2VBeUNy?= =?utf-8?B?aXRhYWJBbGFzbGpta2JUY0c4MVRmN3ByMnhUOERZM0pRNU9QbVdjOGdMK3Bi?= =?utf-8?B?VWNtTGt0NWxJVTllcXJlQms1NTNRTk01TldCc0g0WTIrS3NXcmtKd1JPWHpE?= =?utf-8?B?WjhsOUNueC8vYk16UHlBcTFMWHhqUWpxbFBFVDJYMGdBZE8yZVlyb2ttL1VP?= =?utf-8?B?dmNQUFJrUmt5SWpsTXUyT2xhSkZMVUpBTmdNVE9tWE9ZNWZtdHB2MnVJWjE1?= =?utf-8?B?ZHUzSzVuSnNNK3BxbTNWYzA3Tm00ek1LUEZmdnBWZE9zbVE0M1VIV3VCd1JM?= =?utf-8?B?MnhqWFd4OWNRZW1DWjN1VjkweHZiSnA3eHVVTlVQaEVOeEFMUXZpK3NRWGxG?= =?utf-8?B?bFZhMVgvR3lxQ0xPSjVVbEF3Z0p2V1JwRWU2UGJhV25Sb0hEOFdLNzMyeTNa?= =?utf-8?B?cFRpYmdOdFJTbTJTMjFGcno2NzMxVVhCaVE0ZjZ4WXVFazlDRGlpQkViN2ND?= =?utf-8?B?MS8vR0R4MEFoRlh1RlNZWUpMa0ptVWFhTzRPbjRjUmh2dlNLcFN4TnFUR0xm?= =?utf-8?B?RXdyZFp2T29VZnlxbnFhQUxDdml3emsreXhSUkh2QWllYWdOTFp3akVrZXAz?= =?utf-8?B?aGtIcTBnbXRpZ1pDTWNRNFdUSS9XdjBCL0JSR1FrNzBHMFBDdWxQK0FQWDFP?= =?utf-8?B?elBsZkRNNmhkT2tJVklYRXd4MWdUWUhPZUZRQlBhSUNBRFFJMzlXa1dUczd4?= =?utf-8?B?QTF6UTFDZFducU4wRExJS1RxNlY0MEtMa2FJMTQ2SVdRSzVqczMzd1UwbndE?= =?utf-8?B?b3NMM3h0aEM3WklFZ3lzR2pVUkk5UlBpeG0vYnRNcGJ1aXpWclB5R1VBSlNi?= =?utf-8?B?cmIydlFhM1pHOUtDNE1nTHdFQmJ2Q0VNSHc1UVN3R0E5YnFSZDBYTThsZ2Nq?= =?utf-8?B?eVR2SGQ3dnZwd3hiblJHd3hxMnZxSjFuNXNCWkptYXgvUFhXWkR0a0tjMGlD?= =?utf-8?B?djRmUFVCWHZwT0Vpb2lHeXlDaUlUZmZnMmdtMlJ3Nm01bUM3UDhIdjYrWGhw?= =?utf-8?B?RmRUY09UQTZmd0hUbjV3V2g1bnBERXRWZXdzRzRqMUtUQmFSUUsyVjhQR2NF?= =?utf-8?B?VEZrMjVVdE5xbXhiMTFFbVFVc3ZIUVBiYWRuOW41VDYyWDN5blFFYUJOVmJP?= =?utf-8?B?YmFCV1ZxUXJ2UFE3eFNOZTNjQlBiUE5VK0FUbEVhUFUvbmI2VVh2SHplc0Iv?= =?utf-8?B?YkZGR21pOWNhc3FLOFk2R3AzRlFBQXBUVXhPa25VUVF4WVhuK3J0bnhtR0lT?= =?utf-8?B?eHFWeXZFY0ZyS0tQd3VuWkJTTEN3cTVIY0dnMWlHZ0l3UWpHODJBSTd6VERN?= =?utf-8?B?N3FqRm9EZHJQcHEvLzVkUy9yNEJ6eXdqb2RGVUg3TkZVd1FKSjJvRXRZWU82?= =?utf-8?B?Zk5LYkRuVno5RjhNT0pSNjE2TGpKMFRKeVA5TmV6QXBlYmtqSngvS25TVExH?= =?utf-8?B?REdKQkptY3J4Q1RQdnZvNlpBREJ3cU1VSWpLT0RNVlpUSlgycXRIL1hwMW8v?= =?utf-8?B?RG9weXpYTkhYY3hzWTlHaDFNcTM5clhYQVQ5ZTJieC9WNSt5VjdNVzNxMTRH?= =?utf-8?Q?wClPdXoS2OSz7eAoQtNGwwY=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: bec737a8-b360-4dbb-5437-08dabc9ace70 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 06:23:50.2518 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2PB9eORC+c03rBjMNX9V6RttaJZvESSN5AJG7BLspVEQloe7M7HOHCEVsaVv47RqNZaqzmQBm8sgjT+PNiuObQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5406 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-02_03,2022-11-01_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211020038 X-Proofpoint-ORIG-GUID: hwxGcwTbnUepycyABShJY0K6TIcizsvR X-Proofpoint-GUID: hwxGcwTbnUepycyABShJY0K6TIcizsvR X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: (Adding Weimin Pan who is the author of the patch) On 10/30/22 07:03, Mike Frysinger wrote: > On 30 Oct 2022 00:44, Indu Bhagat via Binutils wrote: >> --- /dev/null >> +++ b/config/sframe.m4 >> @@ -0,0 +1,16 @@ >> +# SFRAME_CHECK_AS_SFRAME >> +# ---------------------- >> +# Check whether the assembler supports generation of SFrame >> +# unwind information. >> +# >> +# Defines: >> +# ac_cv_have_sframe >> + > you should be using `dnl` for comments in m4 files so they aren't copied > into the generated output. > >> +AC_DEFUN([SFRAME_CHECK_AS_SFRAME],[ > space after the , > >> + ac_save_CFLAGS="$CFLAGS" >> + CFLAGS="$CFLAGS -Wa,--gsframe" >> + AC_MSG_CHECKING([for as that supports --gsframe]) >> + AC_TRY_COMPILE([], [return 0;], [ac_cv_have_sframe=yes], [ac_cv_have_sframe=no]) >> + AC_MSG_RESULT($ac_cv_have_sframe) >> + CFLAGS="$ac_save_CFLAGS" >> +]) > you call it "ac_cv_have_sframe" which implies it's an autoconf cached var, > but you aren't actually using the AC_CACHE_CHECK macro. > I will use the AC_CACHE_CHECK macro in V4. Also changed the prefix to "sframe_cv_" instead. > i'm guessing this isn't actually coming from autoconf, or will be merged > there, so shouldn't this be using a "gcc_cv_" prefix instead ? i'm not > sure what the policy is on config/ when it comes to home-grown cache vars. > > similarly, should the macro name lacks scoping ... > Can you please clarify what is meant by "should the macro name lack scoping.." in the current context ? >> --- a/libsframe/configure.ac >> +++ b/libsframe/configure.ac >> >> COMPAT_DEJAGNU=$ac_cv_dejagnu_compat >> AC_SUBST(COMPAT_DEJAGNU) >> >> +dnl The libsframebt library needs to be built with SFrame info. >> +dnl If the build assembler is not capable of generate SFrame then >> +dnl the library is not built. >> + >> +SFRAME_CHECK_AS_SFRAME >> +AM_CONDITIONAL([HAVE_SFRAME_AS], [test "x$ac_cv_have_sframe" = "xyes"]) > hmm, is this macro only used by libsframe/ ? if no one else is going to use > this macro, config/ isn't the right place for it. you should put it into > libsframe/acinclude.m4 instead. > Yes, at this time the macro is only being used in libsframe. OK, I will move it to libsframe/acinclude.m4 in V4. Thanks