From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 48524385840D for ; Wed, 24 Apr 2024 08:07:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 48524385840D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 48524385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713946072; cv=none; b=wnP3zYRmueDDjhnsFPU1xawAEik1KomhohTYjuK1Fck/6gG7URpAUJSvndZwoVfkvXJv+zq6JT0X3lBi/yXaY1dLe/4QFRuPpjDfX/oyZaJpSggg4E2rK1yr+k6S/oUAC1RBZ5l6r97JjjJ8HALUcLcEEA7XD6/51g7AtHPAzU4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713946072; c=relaxed/simple; bh=PNv2X1JJWWWMUVQMuaDiCLoKRRl/jFCXK9waV1NTFVY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=hU/TxAbpyHIiCPs/FUVr7EmAG3mfloTLV2Ve6Qnm1PkOAV38ASvUHs+0y3cPZer6fZfFT4qWTpk9/+JXxRRmtMCWxAvsWr5juqAZRbAvEGokMGIcR3of5iQpFfFAutqG3FEO1a5yOIGAfnPj+Q9bYK5/OiT4TNqYKyQbUiA9Pos= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-346b96f1483so310455f8f.1 for ; Wed, 24 Apr 2024 01:07:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1713946061; x=1714550861; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Msl5QILrI6vmHrbB+gtoNM5NeBuO/PYV5JOvanRh3jg=; b=O/nIAaU8yQh7+G/9t4LphnYwF+NIH5pWBjZKbWzERXK42vWYzyUxCFnwQJm9913MjY B0dXN470Z6mRIPXQsjL0IbBaH32J3FbIlvZyhMwSVezYCK0oqtqmnCgUIv1tysexipoy YxNSqy6x37OJWIaofuR3CG+lLjMEYo5Vb7JWWc3sqJgoO1qHOdxgn3eU3Nw4+mxIYICL nuUs2xfQ/CjMwBj+d/B/TIYF3xNArQK6g2aCpnLKIFmSKWyTAS1f/Bx8gFHAUo6MA9AE g6ESjuHEZVSfolS7XvJ3hO6fq5PfKba86OAiA/V6I0VRkd6LJG5aMxAJfW64qfIVnpfX 7ZQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713946061; x=1714550861; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Msl5QILrI6vmHrbB+gtoNM5NeBuO/PYV5JOvanRh3jg=; b=Iy8+AoRLs1zcxBg0xlakF1c9Wq3ZrJfOzQciFrxdSOvmK4eepdagHSWhs+DTZ9TBaK dkl72ROEC34Ii4y0ZIf9Hl0CuIlKCCEkeV1AoJEGBquC2/S00KVKG6dCLrMUJ4sEi7hQ s0vzarzz4y/eXLiUtqYi8q1VILZmkv/YIyFWOXT7Tol/7qfdFvWki42ugbnbHdknimE0 5lMHIzkHA3d1o8G+rcZLLtB3G6YGRrWs1QtNLkf075dAyBDsA0DPjPbNvMYo4JPDfI9h E1soRGcD19AnCdLAtQsl9nPhuSTJhU+3tvVi8V8LGG4NZCw71mTon4NOTA2BVak5naL8 OcmQ== X-Forwarded-Encrypted: i=1; AJvYcCWZxBpmisZpMDuNqsR0NBqALVHJMfoifhR8LocrvsTvzTbZia6d9PByYpNBlPkazvoGFx83n0BjAcaaDfNrOke/Mi3ckrBIbw== X-Gm-Message-State: AOJu0YyWi5zt0ldEftY5chsaes4MJ1J+zQNk6Zqp65XVGpDQnRYXFoaV vL2HT5DywT8Glg1RBcLE1BcvWBfuAjdYW3xAmFBYEYBqz9hWe1rjEZj+SaF5x0VIyHMHQOCT0m0 = X-Google-Smtp-Source: AGHT+IEJIqOMSGrW0auFlTlOFOFyBh+l+FuRy7NJRsWU9BHlCoOlUMAxonZGZB9/ID4xvDzlm+imSA== X-Received: by 2002:a05:6000:4c6:b0:347:e616:c7bf with SMTP id h6-20020a05600004c600b00347e616c7bfmr972602wri.35.1713946060789; Wed, 24 Apr 2024 01:07:40 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id o12-20020a5d62cc000000b00349c42f2559sm16472102wrv.11.2024.04.24.01.07.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 01:07:40 -0700 (PDT) Message-ID: <8549a5b2-d8b1-451e-90c1-74ee29dadf3a@suse.com> Date: Wed, 24 Apr 2024 10:07:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] x86: Drop SwapSources Content-Language: en-US To: "Cui, Lili" Cc: hjl.tools@gmail.com, binutils@sourceware.org References: <20240424072356.2433122-1-lili.cui@intel.com> <20240424072356.2433122-3-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240424072356.2433122-3-lili.cui@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24.04.2024 09:23, Cui, Lili wrote: > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -10434,6 +10434,14 @@ build_modrm_byte (void) > > switch (i.tm.opcode_modifier.vexvvvv) > { > + case VexVVVV_SRC2: > + if (source != op) > + { > + v = source++; > + break; > + } > + /* For XOP: vpshl* and vpsha*. */ > + /* Fall through. */ > case VexVVVV_SRC1: This falling-through is odd and hence needs a better comment (then also covering vprot*, which afaict is similarly affected). The reason for this is the XOP.W-controlled operand swapping, if I'm not mistaken? In which case perhaps instead of the fall-through here the logic swapping the operands should replace VexVVVV_SRC2 by VexVVVV_SRC1? Jan