From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2057.outbound.protection.outlook.com [40.107.20.57]) by sourceware.org (Postfix) with ESMTPS id 565133858D37 for ; Tue, 23 May 2023 06:27:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 565133858D37 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RUepJ1h1hxH+njGzutzUW/QBNmAXdEk5M/WgYdc5UesNT4kH0gvSqi2HecOaBH+jIr8WLEzszkxqBeSYYbPZzxK8iXlqubR5y7Quqe7sGwJYg6F81e5SQj4jZmWl33WWjcnOoACn0O/bZM6GrCU8jHtz83hduqn3Q5ADNApiWtP0PAClnt8vpU75ek0vh9OSAS7qVeiAWHHr/oarBQQssLxsVKXsg2WP8eUKEERZRA1an2hxUgYpTIsrBkUjDy/KBURM8yxrA/GiYUnIYx1ipCsWRDBiK6kKyyRZwke5gUNPvmA6j3CrqBwXyKpW2AkeHVMhk3cT477hAMdsIO1W4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a9FJmNpOoXpQPbyVirCVP3C9ufPItnUCUAY/QsxrVco=; b=XZFwZUsVYX6UgcdpPrVA/8ySElktvij404L97m7jyTOjAusRnWEkFeD3ATgG/G2HX4ybC3GLbN0ZriHo4XmEUDYbKIDyq237W171Qp7rVy+ZVe88JfhJwfbL99ZIp1OOGMxE2GhvYQp2LvwW+qKhIQqwFoxAWOUzgJcv0uMVEyEk8xDM/6D7QAZYDKSkn5hZzmfk/1bipsVf2cY57BPV8HEPFcFx5ZKsyYanRnlunhz5BnrDJ+tolxj3tg+ejEk9VpVx49Djn6AFxjtqgu1jrJ3B6G3rk3gaCgFqiV21QEYaCAd/scYYD03S90s6sHkm01Q53y87j8chLxkTwp5l2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a9FJmNpOoXpQPbyVirCVP3C9ufPItnUCUAY/QsxrVco=; b=NkF2YJmoSaC3QFi6SUaqEZwGfNuzrAQxAsiafywhNkUBbRC7O17MrXYbd1ODihteh6Rh9eUBgdYlPbP8ml1KQxKQx9uamwthjUVvXPOUzuqWNmuipN4yADT7ZELMMtj5nw7cBP3NDgBQn8xsBrK867t7fAThVcw/zlv6miz2U02pP8YGce577WeLBnrfVihlzAUdwcM4iVkH85/IXXQ8Hbrcm6RhIF7DQQ9xuRRoVlgI02mLi3Aa1CXG+6NqZ1s8eA8NDHVJjaPzFIpLJ21rSeHE8Q3aP9yDkZcgYAujjAJnIQVKb8OUZjWk90Ltcse6Jvh8i7Zvz3j6WO3/zol0RQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6786.eurprd04.prod.outlook.com (2603:10a6:208:184::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29; Tue, 23 May 2023 06:27:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6411.029; Tue, 23 May 2023 06:27:00 +0000 Message-ID: <8571942b-3cc7-077f-4b41-bec547ab2dfd@suse.com> Date: Tue, 23 May 2023 08:26:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3] Support Intel FRED LKGS Content-Language: en-US To: Hongtao Liu Cc: "Zhang, Jun" , hjl.tools@gmail.com, binutils@sourceware.org References: <20230522142036.199490-1-jun.zhang@intel.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6786:EE_ X-MS-Office365-Filtering-Correlation-Id: ca1c9a4d-61a9-4114-9a34-08db5b56b6fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NxnYF2ovFTcmg5l2E8Bnv8uexhcZtVUXkqCP0aGIvK/V/stsl4mwmE5v4W/3huS7RRdZnbYM0zXU8kybWTtlqxP19evAhPN8RlWV3BVJ8HL5KUeU4u13zgfOA9zw3spntTrJur2S1L+PhfIHUkbb1PQnkGqpmAUlfXaKpecDU1Kq8YuoqIpUSlPEC9xAuBccMcghFWX8HMey81tfQUpIDimFvJIm/EGusUx5tkCEMSgBRHuYrNZgP8uRSIxylccgJwA9f4PR1q8jX1r9wRRSkWC7yMocFfOd1AHNYJ3nKP2k5H3BwETqzwnpNBL7tVmZa6M+sYwcfu/QF0BMs6GBO+OnRQqIijBiziG+yZBb6kHjwwpXQIJ5fZMz3LNX3XOOzK4p8e2WkkxIEqbxd2p6SHLmmqo9A5+a4TMytxABu/vWCN4yvI25VRi/Vc7KAGc1mCjKhq69VS0a5QgGeo2eObBSOtw+MwTthG4GwVV0EuZgCkGnSp0y+BY/7EDrPVZoIfyJkJy6kZBvco3cAQpSu0wwQVAegGP4cMn7Tl+ucW9ntfgcVGAg9dXDsWtzYOdAWkmioyvXoNCaRwodzoO52HBUy3SOkfQLWBDuk/yKvBD3fCA2Vl3w3rW1JKgbXhS9qam0/XkD0A0k9+/2Vo782Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(39860400002)(396003)(366004)(376002)(346002)(451199021)(2906002)(41300700001)(4326008)(6916009)(316002)(66946007)(66556008)(66476007)(66899021)(8676002)(8936002)(5660300002)(36756003)(86362001)(31696002)(38100700002)(2616005)(6506007)(6512007)(26005)(186003)(6486002)(53546011)(83380400001)(31686004)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVpqWitvcFhpSlNpbi9lODRvNDhWMkFrbXNTa0w1WFJCczJPa2VRaWFDa3R3?= =?utf-8?B?eWpXVkdZL1FUeHJaZUJGWVpNS01wNGJNVURsbzdRdCtXNURQbkJWemphRXNI?= =?utf-8?B?VmQyMytSWStBVHp2aHRTK0NVUlpmVmI2NTNlbEttUEZMM2RSOEhEM2lLNVF2?= =?utf-8?B?NWx4SFhKMzhmNVppekpKYjNXdzBiSm05L3gzaVFvZng1TnMyN1A1UHVGLzhE?= =?utf-8?B?TmJPSnhCcVdlaGpaRHh5V0tXU21FRDRYM1lDdXZSNTNTSGFVUFNjdjdpRUxP?= =?utf-8?B?NkZFcGpuWlB1NkhOSEZEODk2c0NkMVZ0SEpWdHRCSktIbml1RWF6NWJwYjhP?= =?utf-8?B?cmJOdUZEbjk1WUk2K3ZtNmlIODJNb0xTdXRRMm05dHZzTUdUck5lWWx5d1hw?= =?utf-8?B?bVhVZFU2S3duOXVTRDJ2KzdZWmRCa2NUc1FHOVhIVWoyUVNnMTczaHNHZlh0?= =?utf-8?B?Q2V4aUFrTUl2eUNZU3VvZHFsRjhScGZqUzZORXNtSCtSS0VqczRzeHpHSDNa?= =?utf-8?B?RkVKN3hDNnlvSmNFY3AvNFFMejdQTTF4U3JtMUk0eVlYUENuTVdvUkxpeHpX?= =?utf-8?B?cnFnS2VXVHU3QXhhRWVVNDlrZXNQY1phYXdPTmFIMG1UL2xLajFCMllxb0NH?= =?utf-8?B?b1hkRk1ya2tEUjl4c0xycFpESTRBWkNjb2pjWlZJZDBFdGZiaUtFbFBUaDFV?= =?utf-8?B?eWVzYW4za0lEUW1xL0ZzMmVDSnZOdGowbEZ2ZzNkbjcycWM0aVFLbkdFNkdj?= =?utf-8?B?bk85ZmdCb1QxTFVqNU4yM1hwS0RTbllhNWprMXVSY3VzOXRaSGh3QkhpWHlt?= =?utf-8?B?M3g4YkdsTWNnMFdXMUdZM2s1Yzl5bFVVNEY3dnJYdTBOTW85MWVna0NKRWVE?= =?utf-8?B?SGo4N0c3VmlxZTczOExoTzUwcTdJZWtCZDhzdGJXTUpPL1drSGNDcWZvYkN2?= =?utf-8?B?TnNsYi9Qbi9GekdlOHIwR3ZWVkZOYW1jQmdnb2RySnAvYm5DdXNobkNnanJu?= =?utf-8?B?NXkzWTlGenVvK3luTlZLUFNSWS9lS3ZOSUF3S09rRGFjRHJ3dHJjRk9idkJI?= =?utf-8?B?R1c1OXdpRFdUU05aKzVLS3VDV3g1ZXhxbXpIbXRhcTc5OC9SQldKRDlJMXZz?= =?utf-8?B?aGhrWEZ1WStLS2ljK3RlTFprNzlCRllLSy9jMTlpYnR2Q0dyV3c1NHgxdUJs?= =?utf-8?B?eFA0RGx1bUZYNmtKbTNnMTc4MWhHM0tuSFJJaWN4SGc1bFBXQ1d5cXBYRkw4?= =?utf-8?B?NU5iSHA2VHNMdkdaOGVkU2E4NXlwWkxmams1Um13OHlDS1lvbkh4NFowRGxM?= =?utf-8?B?SHNMMnhvdTJROGhqQlU5TTJKa2N1Z2lqaHRkVVBRZU1RaU1xUTFTb1BLdyty?= =?utf-8?B?NTF6eXd3aVk5M0c5d3JSR2RIcytXb0pHMm8xMHhpcTRscVNZSW5uaTVmVzk2?= =?utf-8?B?SkYrR1B4eGZYUmc4eFFRUUV1dGgvQWQ2K0lRMmhrREpPYkZFZFpHaTVvNUx6?= =?utf-8?B?UW02RGtJMmlKS3lLTDBBbkZNZ3lCVXB6Q0o0bzNNN0tXaFNQaHErWDhIMytB?= =?utf-8?B?ejZoNmFwTmhodzFoU1F5R2hPTTJOdThtbEZHbGUzVkpwREtuclRlcFFNaXdI?= =?utf-8?B?c2hjUUhkaVlaZWhJYnZiSjRqaHdrMitES1hrV1BxbW56L3IxTzQ5endtTUx1?= =?utf-8?B?RmxBbHRmUzNtNCtJTHdJdDNSVFIwWU1LWEFtVW9EdU5FR2NaUUF6c0prUE1U?= =?utf-8?B?M2ZYRnBHSWhWZ2ZtR3l1WEREOUEwdUJJNWtuVTlaR1I3dkdZSWlVOGJEbmw3?= =?utf-8?B?UUZ5T2U3d0V4TmxTaFIxOW9DRng2MCtkRUNtb2tHY2tqNTdsUjFtMHUwbk5K?= =?utf-8?B?MVlLQ2FoOW9yeEgwMVlGZmNtbGcxOHhjUmllSzZMVmpmSHd1L0NOQjh0N05P?= =?utf-8?B?OGJqQVRiYTgwSHowR251d1hoUEh5RW90eW1IYmk0TUFjWkZ6U08wNkVFVUhV?= =?utf-8?B?K29XOTRlQy9oeERLYWl1NDJhQ1JCVG1kNkNLeGZLUkhDQXh0UEsrMWhnNWZT?= =?utf-8?B?am5BenJOY2ExK0xTWGQ4TktSaVMxTVN4ZlIzM2x3aHFhaDlyaUl3Z2MzZXNl?= =?utf-8?Q?U3yyULfLJylG9MDQU04kEKjE+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca1c9a4d-61a9-4114-9a34-08db5b56b6fe X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 06:27:00.4218 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GT0Uhimzg31VO5l/QXDFApWPEGNCs8/g/X8abqztHJRTchLIaOORSY8Ce80ERke8If9yuoTvJwymMhLb8qJohg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6786 X-Spam-Status: No, score=-3027.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 23.05.2023 07:52, Hongtao Liu wrote: > On Mon, May 22, 2023 at 10:47 PM Jan Beulich via Binutils > wrote: >> >> On 22.05.2023 16:20, Zhang, Jun wrote: >>> This patch is the third version about Intel FRED and LKGS instructions. >>> please help to review. >>> >>> Jan,I am new comer, this is my first patch for binutils. >>> Maybe we need senior engineer to fix Ew. >> >> Well, okay, I'll try to deal with that myself then. What I'm puzzled by >> though is what this v3 is intended to change / correct comparing to v2. >> The one small request about ... >> >>> --- a/opcodes/i386-opc.tbl >>> +++ b/opcodes/i386-opc.tbl >>> @@ -3351,3 +3351,17 @@ aor, 0xf20f38fc, RAO_INT, Modrm|IgnoreSize|CheckOperandSize|NoSuf, { Reg32|Reg64 >>> axor, 0xf30f38fc, RAO_INT, Modrm|IgnoreSize|CheckOperandSize|NoSuf, { Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex } >>> >>> // RAO-INT instructions end. >>> + >>> +// LKGS instructions. >> >> ... using singular here and ... >> >>> +lkgs, 0xf20f00/6, LKGS|x64, Modrm|IgnoreSize|No_bSuf|No_sSuf|NoRex64, { Reg16|Reg32|Reg64 } >>> +lkgs, 0xf20f00/6, LKGS|x64, Modrm|IgnoreSize|No_bSuf|No_lSuf|No_sSuf|No_qSuf, { Word|Unspecified|BaseIndex } >>> + >>> +// LKGS instructions end. >> >> ... here was not fulfilled, in any event. Plus that wouldn't require >> re-posting, but simply correcting before/while committing. In case >> you don't have commit access (you didn't say so, though) I'm sure >> H.J. or I could make this small adjustment while committing for you. >> But you'd need to let us know ... > Push to trunk on behalf of jun. As said on the build failure thread: The three generated headers also need updating. Jan