From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3BDAA3858C52 for ; Mon, 14 Nov 2022 13:43:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3BDAA3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668433408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qVzu0mPNqn8mS6mTEwW9ONmCdLARMrq6nwbTQAKFqUg=; b=AdJPpgOECJKTskttuzX7uHqjEP6phP0nI2jzDWEUiWx0cHu4WZsyt25b4IjFicMuqsZFzF aipneOhi21+g3JnfB4vd5RaAafeBdm7VsFV5TpRcycWKaRcrTI63i1CJHda58Wnb3k9cya Eb7MNi9MbcrOfnn1iRTB/LdE6W43KFA= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-474-aYWt7RYSMaKQx5RghzNDww-1; Mon, 14 Nov 2022 08:43:27 -0500 X-MC-Unique: aYWt7RYSMaKQx5RghzNDww-1 Received: by mail-qv1-f70.google.com with SMTP id z18-20020a0cfed2000000b004bc28af6f7dso8411513qvs.4 for ; Mon, 14 Nov 2022 05:43:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qVzu0mPNqn8mS6mTEwW9ONmCdLARMrq6nwbTQAKFqUg=; b=bm9/czuaQzvWFvT9TZ9Kluapv9c10FJkr/+4uPMdV6pzXaY1nIo/bSZKzdZH3CjJSU 7a23R2Ixzl4DuCjmpdHEg8xvOw2vVbgjTYHMDIhZkIJ9cqMdb8VxS3vMPy+j1w8+0pTt w0AnEC358plx+xg6ZMOMoR1lpl6TsZvWR0m2FTvu3nLZiZD3ubnaxkxrzG8/Zk0FUbEa ROwSu8ZtnmTPTr9Q4okE28+hA3wcNzUCDmrPa6jjnL6VX6mgn0lsuK1wF51RqF2nFudB KuGXhfu5liUBUzme74rb05Q8P59AUtwFEermGXHDgPfdC9p4gYwQyW8N4vzbsu/NQT8F fr1Q== X-Gm-Message-State: ANoB5pmmCxF9LHx+eC/Z0azTAr7akylM8VAIXBV4rO/qWF+dFM4UFqTL pMUs3rjF2RIwCNXCUDciLgMjLijguQ3wJz92k8equbUv2Mp24w2JF8AVEpmHGENT+bK0WK3rbmA SbVb/7g5v+T/CdPW3eQ== X-Received: by 2002:a05:620a:12c9:b0:6f9:f3f0:61c2 with SMTP id e9-20020a05620a12c900b006f9f3f061c2mr11084012qkl.289.1668433407188; Mon, 14 Nov 2022 05:43:27 -0800 (PST) X-Google-Smtp-Source: AA0mqf5JChyqAN1aHO8EUKrB1FMAhqFdNoP/9vSrr6aRm4L1Xufk34DZw+ZJWc8hiF6UEpz3EJyb2Q== X-Received: by 2002:a05:620a:12c9:b0:6f9:f3f0:61c2 with SMTP id e9-20020a05620a12c900b006f9f3f061c2mr11083999qkl.289.1668433406960; Mon, 14 Nov 2022 05:43:26 -0800 (PST) Received: from [192.168.1.18] (adsl-164-85.freeuk.com. [80.168.164.85]) by smtp.gmail.com with ESMTPSA id e8-20020ac86708000000b003431446588fsm5644019qtp.5.2022.11.14.05.43.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Nov 2022 05:43:26 -0800 (PST) Message-ID: <8587d119-b296-57b5-d99f-d30f3ec7c846@redhat.com> Date: Mon, 14 Nov 2022 13:43:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Jan Beulich , Binutils References: <40e89395-1438-6cbe-aa37-1a04a724c8c7@suse.com> From: Nick Clifton Subject: Re: [PATCH] gas: accept custom ".linefile ." In-Reply-To: <40e89395-1438-6cbe-aa37-1a04a724c8c7@suse.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jan, > While .linefile is generally intended for gas internal use only, its use > in a source file would better not result in an internal error. Agreed. > Give use > of it outside of any macro(-like) construct the meaning of restoring the > original (physical) input file name. We should document this behaviour in the as.texi file then, so that it is "official"... > --- a/gas/input-scrub.c > +++ b/gas/input-scrub.c > @@ -469,13 +469,15 @@ new_logical_line_flags (const char *fnam > /* FIXME: we could check that include nesting is correct. */ > break; > case 1 << 3: > - if (line_number < 0 || fname != NULL || next_saved_file == NULL) > + if (line_number < 0 || fname != NULL) > abort (); I still hate having calls to abort() in code. Much better to have a helpful error message IMHO. Not important for this patch though. Cheers Nick