From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70045.outbound.protection.outlook.com [40.107.7.45]) by sourceware.org (Postfix) with ESMTPS id 0965F3858D32 for ; Wed, 21 Sep 2022 06:15:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0965F3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RdzfWoQgT3xnepvOLaHUc7/o327SReNZCJAcZ2wanIWnGPWhXDfCRryyUDD4joqdSouezgNz7mKzZ0AnoMOx+Hq/cUMBC6SlkZpclRsfjTWmtltZqnaULawEOTqxS4PXvfx/XU7IsDt3XCEXLtn5+zvXyz87u/FmGfhgIlBGVuI3NaiPbP9C8/M1MGVE/Gp4YJFJrdY6Pvdlkc0VReokosWMwBIjur74GMBpyFRq3sDdaieb+9M7SHYbX71Mqi48mS9S3UfYaEKsSYCkmEEmcRSCzNeCa9wyI5an5FlE3jqQZxhv5KY0vtIlER0+eAtWJdBe6tvsUqxo/1tr0HffBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VtoFwtE+8fhw/iWHRiXRdAoMbLsrVMma9Xzab6ionRk=; b=nld75HNSfGd42UVfaMGwUqyg8Bfq0tBvsN7i6wMXB+G4bToQqxCfofdJrlh1yQwW9QGrHNQ9ZaxxFlbTEXqj3k7eg7l/HpV4B0w16jXa5HstyPceSM15eyCase+vSD87dChoB/BajhEEHWwlormfc4Uo44woYUii+u2cTac6qCz4x0LRv2qpiQumu8osQfwjHjpqS5DCriJGZ3iPYB5O5vl/kG02g/c8KJ1vNBpeUYZtjwDBoaGC102ebmzRyQ/hOj+hkQueEnz5YmIHSTmuyvio6O69eOLRLit9ls0xGto5vf0Tv4fxSnTnysrAVAj1JdSMdPtMIH8XMYDhNZCKAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VtoFwtE+8fhw/iWHRiXRdAoMbLsrVMma9Xzab6ionRk=; b=oc4fR5yCx8PzBzH10jvEzzhhuBlgD0jXejbGOhgBhhbpokao+81Ae8sNC6UujwtCy6RyOSbDfAFyxsBa4MWu1ka2tR62QiF1FZnagqfpTVQXceJGxcMBb48epNKJ67CHgHuLUIFs+Q+hV6fY71KgrVCvbdVX8eEHtq0q50DuRzAFiMkbgJ/tQCZ9gvlj16GgqgbKqM/Ru9Iu/jJ/ZHCCceqMvDp4viBbiopLhZRa0QEzq0T2XbEzZfBxCYxZjRVCGV8tUQiA3i81Q2caPspAZiC63vbu8QlXkakpPf09EC1boTkgsbKVUXhj26re9WHt6KdczYrQZI4MbecTKvPyXQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7492.eurprd04.prod.outlook.com (2603:10a6:20b:282::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Wed, 21 Sep 2022 06:15:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Wed, 21 Sep 2022 06:15:23 +0000 Message-ID: <85d0ee12-c509-25ac-af34-fca8dc0644ef@suse.com> Date: Wed, 21 Sep 2022 08:15:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3 1/1] bfd, binutils, gas: Remove/mark unused variables To: Tsukasa OI Cc: binutils@sourceware.org, Nick Clifton References: <1ae9efe3-f890-ee6e-11ad-f5045616f253@redhat.com> Content-Language: en-US From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0058.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7492:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a5c5686-a587-4e00-a922-08da9b98ab14 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RcSSjppikJzpzumRFU06EYWN8tn7W1+MPakILOZX4FUvIXPtANXM2jh9RRDIjG4KN04ZL56iofcM5BtoUf+UJdppYj9308hZ+sRdCfy8ltwWs9171Jv8vjv5dbT5Wx0FeuEPWy2dHRMes8bBxcGqxjr2DiwrpmQ780X/L9RN+Bl/ct1BLptRQkt08CaJNOU2o/pFnhFQpfnzRZmsZUYmkDSfjXsNXTZWVQUOTmijAyw5gQuMjIkO+3qNFsUjL2fHbtXIyeC/Jbt4QZE5ckiirF8x5uzSRMSs4fRBaZl1lbB2/ifvpLLgZxdfHaJGG6PUb2VUcv9Ibx6uOfvn3Y1Q+ZKWYABzM5PQnV1pSx4utdtlOeM9XZKrpLuYCLM/qDtBMkOfcEkckX8V66a/H02zIB/fMDE/Q9wClx46X7ad5Su3F8Y31N8aVO9DegQlpQAwxJpGhIops4Zh0ffnpE8i24ITGDEJoSFb5Cc/mOXctiykvpt0ECpG9WtFF1+HOEUMebxb9Hb3epn9byLCogc4jrmXZ0wXSIxEUhcV/aeO1vTvJir+vOi7Um0V0rfBmccuwskiFKPmgQ8W35+EgsdmZcg95mospCUFUpUl/n4sIlkTFtFIWiKN3LGRu+2PwTrtQSzmUTs6Le4O+Fguh2XxIeBk8PELnHcwic9GVkN5rVowbhQMIGKdLWVKDMffSLXRrPLp8refYtsO6og2ehMxgLer4uudZHLeGtrtHHeHbKaMiaC6HHHIqU713IAMJOMG556c/JGfI0IGDQmSta75EaqpvWBVKEhDOjldcaMwRbRAJBD9BArlqcPZ8YR3OojG X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(366004)(136003)(39860400002)(376002)(451199015)(8936002)(2906002)(5660300002)(4326008)(8676002)(66476007)(66556008)(36756003)(66946007)(41300700001)(31696002)(6916009)(6486002)(478600001)(26005)(6512007)(86362001)(316002)(53546011)(6506007)(31686004)(38100700002)(2616005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0cwdTNpMC9KdzRvWGRGUHNmNy94cktiZFNpdmxWQUFpV1JObDk3ellWTHEr?= =?utf-8?B?Qjd0Zk93YVYzc2NGQjF1ZjJiU2t2Mmo5VXBSeEI1ZEkxbENhMmpqaVJVMk1F?= =?utf-8?B?SDdFUkZZQ3cwSjVjR2lnbUdoV0hZbHRHbHZIUXVMRk9NcjRsekRUOGI4aVlw?= =?utf-8?B?c2UwZDJzTzlDMUZlNTFKNWdRSTVWUUVkVE9xeVRPRWU4QWh2ZnluaWs2UkJm?= =?utf-8?B?amVPUXNtcGhCNVVIY0tZbHdRbkRGTUl1VjN0bFNRQWVSWnFZaUY1SHVhTWJR?= =?utf-8?B?ZWU1N21nRW9QZGJEd0o0WVhsNkd4WEc2L2JuNzJ6cTlWL1UrZWFDVTNiQTQv?= =?utf-8?B?dWl4NFUzMitUWEZjZVcxMHQ2TkQ2OTd2UGZaUldzVUNsbFVRa0hqdFpXUUkx?= =?utf-8?B?ZCtsWFB5bXVLUEhyeWNkQUpWcXRkZFRsLzE1RTl1WHNvbEx4ZnZVQ3UzZTA4?= =?utf-8?B?WlBwNWdzbGp5T1dIUituckptdGlUOEJlNm12QmhVbVIwUGhoSDgvRzdIamxJ?= =?utf-8?B?UUNzSWp2UGo3UEg4UHN1OXhkY3diemsrdEc4S29qU1RWaGQrTzJHcWp5WERq?= =?utf-8?B?OENkNjZ0TllDWS9vYktlNVZCYVNRUkpmeTNrRW90S1FvMlpNMHUzaVNRc0V6?= =?utf-8?B?RnR2T3owcUNCYjU3SnpNVXZqalpTR2VvZTZMWXhYRXplSE9DaGFKMlpZOHdE?= =?utf-8?B?OC82eHlQMmY4ZDhGUHFBems0RlVoOFR5bWo5bTBnY2JLcjAyUUZ2TEJZbGV3?= =?utf-8?B?U3FtRjZhZi9sSXZtdUZwT3VpQmdIOTdsRGcycTdzVk9aYm5OTTl3OW8rN1dX?= =?utf-8?B?VFE4UjdHWU9CZmhERlNVRVhwbXBFL3k2OGVGS3U1cGVBa2ZUZ1dUdGM2emlT?= =?utf-8?B?WUsyNTJnSnBGR0NaMmtkaDcrUDNCOURaUnVBcVd6ancrUjQxT2xjVzhpazJG?= =?utf-8?B?YmJCOUtVU2IxSXlHdWZETW5qNFdxQ1UxaEhHVjFMOXdzT2VZM1VsVyszTXNz?= =?utf-8?B?NDh5STJWRXQ3QmNRYzVMUFVMeTFkRHhUMllRNEFDQUpna2tDQjBsYXhXVEpk?= =?utf-8?B?RUlCeFhFdlpWeWdsWkVuYWNXamlIMUY4Q3lUQXU4bEhPN1JhWGFDYVIrS0xa?= =?utf-8?B?Q2JlcWJMd2xiTFBydEkraHBMZzY3YjBpaVl5TmU5K2NibnNKcXJzS3lCaXdo?= =?utf-8?B?L1ZsVWtlVVVHL3F5TkllQ3FjNnI3WHZXc1VaSVVRaGtOVHU3d2hWaG4xWjhr?= =?utf-8?B?VEdRKzMxZlNGRFpWekxDczgxRWF3VVh4UWtoTm1aWHVCVnZSQXpwQzd2MmJX?= =?utf-8?B?VDdXUm1jc2N5ZE5TUnl4S01aSnpaV3hncFNqTHFMQXRRYnpGdzN4RGJLZG5R?= =?utf-8?B?bTk2V3FROVJnU2VHQVpscy9PVTVOZWxCSmRKVUg0MmU2dEVOYWlGMFRHM3pR?= =?utf-8?B?eVJVaEhjWVkxZGF5ZVRJN1N2QnBNSHhpc0ROMW9NaDJFYnkwcW0za1hxb0tY?= =?utf-8?B?eWRXL2JuV2NYTXRrQ3FaYnhvc3F6eHRxM012aFc0dHZGczY2NjdTdHpkM25E?= =?utf-8?B?bmxoR2VnNEo0MXgyUElVYW1kYndWenJlVjJ3QVVWWlVUaVBKQUo5UWNud1JV?= =?utf-8?B?SHovTGg3Q2RXZlFvOE1uaVI3M1V3R3pveTJGaWlPN3d4MkpCRnNmSDlUR1ND?= =?utf-8?B?OXNiM2U4KzIvVS85WUVMUS93dzRTSUR0U1RDOGxGaHA0MzN0ZVgrdmt6akpw?= =?utf-8?B?NXM2b1RhUkZ4Z2Z4OEZEMHE4bXlnNXh2UC9NKzJjWDA3ckRuTEg5Zi9pdFdG?= =?utf-8?B?Tzl4Y1RCUUNITDJOV0xLTkpnZGRLNEgzazQvNmxoa1dVM3NhamdYY2FWdTVK?= =?utf-8?B?MUJTSnBtUXEyWXBQOXRmcExWelI4b2dBdVNxSXNtMDJ6SFBJTFc0ZkxlQjcw?= =?utf-8?B?YjJnL3BjQVBoZ2F4bVFPSEFFdURLekVjQmVDM0srVlFTNndHcDhwWW5wQUU2?= =?utf-8?B?elNRRVFnTHNMeXpOYUY3QVEvNmIxRjZyOWt3eVBQTlVFWWVJbmplem81RkFu?= =?utf-8?B?eVZia0lOM1I3dXZYOUVJenU1NzVVeFhlTm42cUEwRmJVNkVFVTZqS3BpM2l2?= =?utf-8?Q?OMvB40QI+Je7lXGmbkEtdX1No?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a5c5686-a587-4e00-a922-08da9b98ab14 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 06:15:23.5969 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /DSKhXl6xldI6/au3bmNBnZGo4BWUgoau9aMHWuopUh8Byx65IU48+KvGvzd/0ez7uQ4xblon5Xjv8nrjU3K/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7492 X-Spam-Status: No, score=-3030.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21.09.2022 07:54, Tsukasa OI wrote: > On 2022/09/20 21:50, Nick Clifton wrote: >> Hi Tsukasa, >> >>> bfd/ChangeLog: >>> >>>     * elf32-lm32.c (lm32_elf_size_dynamic_sections): Mark unused >>>     rgot_count variable. >>>     * elf32-nds32.c (elf32_nds32_unify_relax_group): Remove unused >>>     count variable. >>>     * mmo.c (mmo_scan): Mark unused lineno variable. >>> >>> binutils/ChangeLog: >>> >>>     * windmc.c (write_rc): Remove unused i variable. >>> >>> gas/ChangeLog: >>> >>>     * config/tc-riscv.c (riscv_ip): Remove unused argnum variable. >>> >>> ld/ChangeLog: >>> >>>     * pe-dll.c (generate_reloc): Remove unused bi and page_count >>>     variables. >> >> Patch approved - please apply. >> >> Cheers >>   Nick >> > > Nick and Jan, > > I sincerely apologize that I thought previous "okay" mail from Jan, a > maintainer: > > as an "approval" and applied this patch already. No, you were right in doing so and - Nick, please correct me if I'm wrong - I might guess that Nick simply overlooked that I did give an okay already. > I will not merge the patch again unless the word "approve" is used > explicitly. I am really sorry. Hence also no need for this. Jan