public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>,
	Binutils <binutils@sourceware.org>, Alan Modra <amodra@gmail.com>
Subject: Re: V2 [PATCH] gas: Generate a new section for SHF_GNU_RETAIN
Date: Tue, 8 Dec 2020 17:08:34 +0000	[thread overview]
Message-ID: <865690a0-b109-5b40-b0d6-0e3ddfecf77b@redhat.com> (raw)
In-Reply-To: <CAMe9rOr7F7tunwUhj9XNy4ruteFQ6rA5pZCVoaBxFwA39jhjHQ@mail.gmail.com>

  Hi H.J.

> Can you take a look at this
> 
> https://sourceware.org/pipermail/binutils/2020-December/114407.html

I am tending towards approving this patch, although I would like to
see if Alan has any comments.

I did notice however that the patch does introduce some new failures:

   GAS REGRESSION: SHF_GNU_RETAIN sections 27

This was for:
  m32r-elf
  mipsisa32el-linux
  tx39-elf
  mips64el-openbsd
  mipsel-linux-gnu
  mips-sgi-irix6
  mips64-linux
  rx-elf .
  s390-linux
  score-elf
  mips-elf
  mips64-openbsd
  nds32le-elf

The mips failures appear to be because of MIPS special sections,  eg:

   regexp_diff match failure
   regexp "^  \[..\] .bss[ 	]+NOBITS[ 	]+[0-9a-f]+ [0-9a-f]+ [0-9a-f]+ 00 WAR.*$"
line   "  [ 4] .reginfo          MIPS_REGINFO    00000000 00003c 000018 01      0   0  4"
   regexp_diff match failure

I have not checked the others, but I suspect that they will be similar.

Cheers
   Nick



  reply	other threads:[~2020-12-08 17:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04 13:52 H.J. Lu
2020-12-04 15:29 ` Jozef Lawrynowicz
2020-12-04 16:43   ` V2 " H.J. Lu
2020-12-08 12:33     ` H.J. Lu
2020-12-08 17:08       ` Nick Clifton [this message]
2020-12-09  0:05         ` V3 " H.J. Lu
2020-12-09  0:37           ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865690a0-b109-5b40-b0d6-0e3ddfecf77b@redhat.com \
    --to=nickc@redhat.com \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).