From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id A02EF3857815 for ; Mon, 25 Apr 2022 12:56:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A02EF3857815 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-32-iPrzyFqEOVKDprtUF1qVrg-1; Mon, 25 Apr 2022 14:56:44 +0200 X-MC-Unique: iPrzyFqEOVKDprtUF1qVrg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VAcqZzbcLGlTg+aYFB9PwLNzC+9TqH1DJWjoLH19pszeOUQM+TRQB+OUr0PJ0Djeq5/hnJiasZypvGLBRon6qpaYC59rUcA/T8BvYJ7P/J9kyeh9LH6+XorRChvsOkudxatHIRNudUkVw+3ZDtfoAkjP9wpjDCKcoJ7e+2gk2vT/910Uouo5Lr/PXgQaMa/1cVILTRZof3jMaSGGQGCYwFmke2kSsVDumdUATuhN/RbxctQlImVaDnDkIr/qWC6XtLYR4ygIHHr/uVEJWf4R5Lk4XH0jLhWUCyS/XouNWIzr47mIWETH+X5XEZVnhXBbm8ihqUq6j9lo12QbeQIVdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ttf1rfg7x48A8llKAf0rnaIFkUplDmZnmLiAVNEqdKo=; b=nl9Ein/MUDmF590NraCneYXRDE+NGBXOWknMSZq+0NXa7Lc4+Tt5fBet/sxVatwR/+KBPivNNeLgZRS9aDc89qkCCPBEtnqKlSMKL+iElzxnuie/H4WBQYUsjOQXukfB8Vgij4C4C52E+Aqsk02gMpsHZOwI0f95JCbwrOS/2SfXmZCbWgIViMr6+d2t5ykk3ZlEiG9dUvXyFdTOiR7qM1w6aCspyML7zCtJL3jSSz08VA8cm8gIEWBPObSBfSSMPbzNRDpKM3Ux1FMXoxK43DMC3JO6/VGSRq4xeBPJ181XQsIDv1GPBZdcanfebHRwEBDScMGJDsxilli4wmfPKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM9PR04MB8306.eurprd04.prod.outlook.com (2603:10a6:20b:3e4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 25 Apr 2022 12:56:42 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%9]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022 12:56:42 +0000 Message-ID: <868fc919-c81c-3724-cec0-9d85983439f8@suse.com> Date: Mon, 25 Apr 2022 14:56:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] bfd: Add Support for DW_FORM_strx* and DW_FORM_addrx*. Content-Language: en-US To: "Potharla, Rupesh" Cc: "George, Jini Susan" , "Parasuraman, Hariharan" , "Natarajan, Kavitha" , "binutils@sourceware.org" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0084.eurprd04.prod.outlook.com (2603:10a6:20b:48b::26) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 134cb9d6-daea-4810-014f-08da26bb0b90 X-MS-TrafficTypeDiagnostic: AM9PR04MB8306:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Cxj8FlkvvfjssHHsJqjkEjvQ6cAzHGhXWdg/HnKZ15J+9HdMreG/7BFVmBcT/hj2UthEWHg89jPVgumeOm0xaeZ6LkNAJF5pKzn5N4n9uXKGGcV+FvBLwM4c0ImiDmOsEcoy50WZBQKQkdOEqxU8EVmCwGfUbiL3ucWFnVQN/Kx1fFmdE2xzQ8E4/P52Z60tBqi7a/1hHK5cX3rY9HwW15C/9C5vXYyNnMNcmS7i82n8fJZftLkEq3YCdokKdAjLIE7YZ40a4vbe6LGyhnWe7aULvkEt7/e9X5GNeFArttX6CBoC58Acsy9Oq1e2i/vLNUicBuDf1Q+2x8DWNrdXsdBuGabFd37YFFawhcRTMr0O+XZupEoCMkoiALVXKWF9njr+8+RmLNT+CGmraPHsAG9eZkR31JPP72xSSLj5jMQwNn+GxgUDwX/eo0ot87HT09O1+OXPjxXGShsgJeS05Po13LBgh7FGLi40pV2ZV6Asghm+DjP+jb7G5rAz0BH78JqnLJ/sJRQzLvlu2Ii9SjSyUL8Iv8/SZpr+8+d/WwDJyvRMoHiDLW+zGfGvyNF2wq7TDpklSNpTJkb3TwxCB5jI2Zz0IPgcWxhdnjNP/i/qRx4eycrvV4L0f7hcq+wWmN5WBRzmDbP/q/utno+oiznknj8TIIfB8esqUA2nBizMAYaL7+aGGiv38opkKXINwi4ebxSD8Cmr5zN/gYGV9f88dZe5uDXqM7oJ33/BNxc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8616.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6506007)(66946007)(8936002)(86362001)(26005)(36756003)(66556008)(6512007)(54906003)(316002)(31696002)(6916009)(8676002)(5660300002)(4326008)(6486002)(66476007)(31686004)(2906002)(508600001)(186003)(38100700002)(83380400001)(53546011)(2616005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3J4TzYxYnUvWDBsMHNDeWZ3cGxKZ2xWcFUzV0NqSDNWV3Bibk10RjdUTTJM?= =?utf-8?B?U1Noa1FPZkQ4MUt2aGJzdDhZUFN3R3ErWHd5RGdkeHZYNUkxN2lFSktJSDhG?= =?utf-8?B?NUFSVDFReEJXTE1wdFdMWlowNlZTNWsxUWtEVUswdytvMEtFZVN3SmdKRUlE?= =?utf-8?B?UkNrYkRlWmpWa3RSbzBvWWpWSnZ5ZE5Sek8rVllMcExCVGRvTTJFeUtSVGt1?= =?utf-8?B?K0IxdGNBN2lpcE1tSlhudGtoRFNteENQT0lsVWttWGw1d0Z6ZDZLWUxhQ1JK?= =?utf-8?B?S1poc1g2VFB6cklzQnpxdFBVb1cxVnN1RUQ5TjhiOWJ2VW41ZmZMTEMrQWhQ?= =?utf-8?B?dEJpQmxWYUNoeHhBelZZR2lvMG5JSVFyNUhYcm1pYXFxLzF0UU1scVpDNHlC?= =?utf-8?B?dSsrVkxxUEs5VFlxa3FiM1Z2aDA3OWpJa0V1ZHl4U3JvTmdLSkRMUUUzd3BR?= =?utf-8?B?d1lMMG1nV3F3elZUc3hTMDh6dHE2bmZvaWFUR0Z1UllHdEdXQlVvUVpqZTFS?= =?utf-8?B?a3NDLzhZcFpuVUtyS1JKZ3Q3d3N4YXJjY1N6Sk9RcTkvWjFQMmVYTE5abnBQ?= =?utf-8?B?M3NFTEJnY2VSRXMyVXNTSHVEcXRGRUJQSEt3V2YrWWI5QVI0S2JJOWtWNFJT?= =?utf-8?B?Z3B3bG1PSXp5S0ZqdFhzeGZNYy9rK2pmdFB1RUVUSWFZRkRvUWhIRG1LRk5W?= =?utf-8?B?ZllDNG1ZZ2l0eGhBdi90RnpWdXZkOU1FUzVxVmMyVUVISXRYK0ZUUnJURzN3?= =?utf-8?B?TDFSS2VRWjZoSWVHajlOT3dST1JPR0crWVVZOElTRTgyTGhHQ0hSRWo4d3VI?= =?utf-8?B?Y25VNWY3NEVkMlh2a3gwYnBMUUV4c2s2RCs1QXVUR0NIMmtnQVpDNFVlbUhi?= =?utf-8?B?VmpPZlp2TFBXRFFMT3ltWkE1TUpLL2JTT3liWThPQ3JqdGh1MEs4SXZhZmxM?= =?utf-8?B?RDdnUzhKT2VsYTNoTnFON09xdldWUXJJak16NzMwY2M4QW1hZExjUjhqMDN2?= =?utf-8?B?ZENDWUxKMHhuMUQrSkxVdFdIQWdrTUlXcENzWVlyWFhtaEtpNmVOVW45ZnJY?= =?utf-8?B?SFJ3UDl3ZjQ2bzhPako4VDRFb0ExM3ZSeStpRW5ZTTRSZkkyQmhBdlpCbmRq?= =?utf-8?B?eU94KzR2SFhFL3V4ZjRCRnFJUWxSR0FMUVVQMWJzRm9HVXlUR1hCN2ZVWFow?= =?utf-8?B?M2FZUkQ3T0NPQ1JuU1hHMzhoSGE3aUFpOFUwUmpYdWE0d1g2Nk5aTVdqUWNt?= =?utf-8?B?RDFZNG9wWG9FTFV3dzVUdEJQYmNOdHpwYXZQNElUVW5IZHJqbGVkazNFOGJt?= =?utf-8?B?ZWdKL2VhbGxWdWc1bnMvR21IT0thRWM5RFJWU1dkUWt2bnV4dFNqMFd4Q3Qv?= =?utf-8?B?cW90alk3MFFjSDNRZUJoNUZNMnJ4L3kxbDdncFoyRWlxMzlGS3g2YUR0TnRM?= =?utf-8?B?bjVJcVRaL041Sk5UTTlLZmFxNkoySFgwYlBvTjB2NkNiaGQ5U1p2QjRPR2hp?= =?utf-8?B?WkQrZ3pxWE9RQ1pSeW5wSHgwL2hYR3FYQlVkN3lYOUpBMXdmOXg3VVUvL09G?= =?utf-8?B?UHB2c3dybFpqZXJXQ21vZ250ZGIyY1UrWGFmcllPcG5uNDlhdit6RnBjOW9K?= =?utf-8?B?cFNzTmYycGp2THpZWmZnZ2NLRVpwZzV4QUo2cmpVVER2L3Jzd0J0U2d5Ymo2?= =?utf-8?B?QWFxK1ptVjlVREhXWmtaSkUvUVY0MGozYk9KdDA5R05tVkI0dEpxdHQ5NG5V?= =?utf-8?B?aUNadDlWRUxYV0luMjJjYnlRSXAxZU9TeWo0Ly9wR3RBdVgzdG1FcDVqQmZp?= =?utf-8?B?Mk94eTB6Wnh0M3dSRzVQaGlFbE9WN0lLZWlBRlQ0b3JQZnBFRXprZzFNL3BZ?= =?utf-8?B?Sm5mdUdzbkxBeXp4cUd4NEV0eXpzNE8zejRzTlNyRnVwMHFobzlFTFc1VkNQ?= =?utf-8?B?YlhweWZOU3pURS92MU9qb0RheDByWWEveWhTNzFaSVBCUFdERGVjQTJNTlRP?= =?utf-8?B?ZFZyNUExNEluQTlUdXpWeVAzYkRnSnhHN21rRlkrK3RqQktPaGk0SUV4d2FQ?= =?utf-8?B?eVNQcEU0NFBTVytQV3hySGY5blJCNkJ6Uk1vWWF5U1JYWTlhZXVxbHp6ZUlQ?= =?utf-8?B?VC84WUFyd1c5dVpWYjllZEFhdWttM2trbWNFWkdubWVaY2lYTGFhek9xaDhy?= =?utf-8?B?OXVqcDFwYTJ2NFoyVy9wL0xmRW9XUWpSZ3ZkSFBhSGxFcitOdHBtSU9RdDdE?= =?utf-8?B?eFJjRE9NOWlkTUdvYlh5bW0veFVLcFRjV3RncndWeWRTT0poNXpCRXRYUnhY?= =?utf-8?B?K3pvTk1GUzlDSFVDWHJSWHVuVmx5UUFaMUNmeldJVkxEekxTd0hPUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 134cb9d6-daea-4810-014f-08da26bb0b90 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 12:56:42.2635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OuGtb524nHDRUEVDFn8mvBs9i+gSvx33y2YlpI64dqUN60+OkEKNuQkvt0K1mbdqc8eC82yY3TYajYq7qC7DlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8306 X-Spam-Status: No, score=-3032.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2022 12:56:48 -0000 On 22.04.2022 08:36, Potharla, Rupesh via Binutils wrote: > Requesting to review the attached patch. The patch provides support for strx* and addrx* forms to the bfd library. There's a change to decode_line_info() which looks unrelated. If it's related, you will want to explain this in the description. If it's not related, you will want to split this into a separate patch with its own justification. The same looks to repeat in find_abstract_instance() and yet more places. There's a use of bfd_realloc() where you forgot to check for failure. I consider it at least risky to open-code the conversion from index to actual value into various callers of read_attribute(), instead of keeping it in read_attribute_value(), as was clearly originally intended. In read_indexed_string(), besides swapping the parameter order for no apparent reason, you go from a 64-bit type to "unsigned long". Are you sure this is going to be sufficient on 32-bit architectures? I'd rather see read_indexed_address() use bfd_uint64_t as well ... Furthermore read_indexed_address() has a return type of "int", but you mean to return addresses there. Quite likely this wants to at least be bfd_vma, if not bfd_uint64_t. There are also quite a few indentation and padding issues, which you will want to take care of. To aid reviewers, please try to supply patches inline rather than as attachment. Jan