From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 3C42938582AC for ; Mon, 8 Jan 2024 08:11:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3C42938582AC Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3C42938582AC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::231 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704701477; cv=none; b=S2Pqrq9pSP9qk5NjCZShDcKf65HrlIMeF2C2SLcLvRvtzSbfdy+UY32ubPzNWujaKsvDqxRELmW1PaLZWjKWgGM/St3sbuhaGJu2IXQjgD+Vlxz2Czlc9L2o7afP8hdPnb3IOkwaA6x44j6TG8KWLCb7gEMyTMqzRLh7nhBG8RE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704701477; c=relaxed/simple; bh=RqwayAFkP8TU4hcuN4R6N57QRHgrGh8i50MiXj96wgg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=vOz3qgyRuq4q+hpYN7ymJUYy5KWEVGaAjxxZlt13IFdqh3SpL60NRgrbwDYxZSUDzzq1dipK3YndvQrXvPY9PS4gZhFNZUNvGqzE8h82sekr8Hr9MJGuwSv4X4lbSbQG0fVMt2T2lMSS11ziQbl6djoIT6Hbk04RA0/pnK7t09Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2cd2f472665so14793571fa.2 for ; Mon, 08 Jan 2024 00:11:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704701473; x=1705306273; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CYb25hsYwiAzCzLQnVxcWhVhdJ6wdx0x3RpSFtOTvR0=; b=QkOwGHeZ9L67qxH/qpW2P8TyVtMGQWpXRiMGKGigLMEmefG716eiSY48U/WoVaJGsz EpELqqZoNQt1IgDM1a/McQPuD2k97HniUltrRXMmH5yE0f124r9vAwsG91uLyL9X2iQH uQGp7sHhUvQZ39k6FZFKX9U/e8IdgZdP0Hjd5Ga2isuLR7N73P0zYprHIXDKPA5jk1Nl Qp0aY84qDrvuhD0ryUdkLlv9mafwkVi5+vOZ66dC9GrTGsPk0r7MDb2zyixo64xWK+i0 Y7jfKVH+NSxr2bZFo1qloj7Q9EHR3wnQaULJW7o/i5wWhg/gf3iM+y6YzXTMAacHEVDh eKDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704701473; x=1705306273; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CYb25hsYwiAzCzLQnVxcWhVhdJ6wdx0x3RpSFtOTvR0=; b=t/jcvkhmAldZr6GEDVlvoSVVPXTBevIHT4y/RuOLi4zsXkxpOz4Lmw6k9riPq3VwF6 Kem5heJLNCOn8OTUPCLSHhtHuH1OGkdlWHPXT4XgLjIKcSsAUa3qotT7FQaeiK+lj6uZ ZW76lAVXX9J3hk3gFZDzFUuJ3xaiQU1pKVHEP26qEvONnyN+BvuVTli6mfbYsjbsZbDP RvqcyV6Aut+CxUauCDstw/UOswJxTiK9EKWqpUILpKxug95ujVdrSKDlortg14rxwXL9 qVlNAYw1T7G8pYwvdSMC6dzcOjSlkq1IKZmT7+SqupQRScTsk3IohPgpC1l4QcgaYLmP rdRg== X-Gm-Message-State: AOJu0Yyc23LKqdp7q1gL4v5JTNd7gZy5hz9pgtCgV7BslDHd4x8VL21J WisEkelKxBCRVLlL2CPJU5Xfy6/3V9QE X-Google-Smtp-Source: AGHT+IHnRxQKd1sISKdHMfbMl76fEMXk2HxeYxczQHFDTDjEU+3/9lhNj57HlNSm0474ItyrsEBDNQ== X-Received: by 2002:a2e:a9a8:0:b0:2cc:c7ef:924d with SMTP id x40-20020a2ea9a8000000b002ccc7ef924dmr1262444ljq.29.1704701472767; Mon, 08 Jan 2024 00:11:12 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id y20-20020a6bd814000000b007bb3c9b3187sm2110112iob.4.2024.01.08.00.11.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jan 2024 00:11:12 -0800 (PST) Message-ID: <86da4ac5-bae0-488e-9644-b9ddbfdac04f@suse.com> Date: Mon, 8 Jan 2024 09:11:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH,V4 13/14] gas: testsuite: add a x86_64 testsuite for SCFI Content-Language: en-US To: Indu Bhagat Cc: binutils@sourceware.org References: <20240103071526.3846985-1-indu.bhagat@oracle.com> <20240103071526.3846985-14-indu.bhagat@oracle.com> <1c9e7d28-1bef-4d1d-9b51-b1725c8b2f07@suse.com> <238fa812-8a31-4fe8-b12b-2f7a55220352@oracle.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <238fa812-8a31-4fe8-b12b-2f7a55220352@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05.01.2024 23:29, Indu Bhagat wrote: > On 1/5/24 06:22, Jan Beulich wrote: >> On 03.01.2024 08:15, Indu Bhagat wrote: >>> +# common tests >>> +if { ([istarget "x86_64-*-*"]) } then { >>> + >>> + global ASFLAGS >>> + set old_ASFLAGS "$ASFLAGS" >>> + >>> + run_list_test "ginsn-dw2-regnum-1" "--scfi -ali" >>> + run_list_test "ginsn-add-1" "--scfi -ali" >>> + run_list_test "ginsn-pop-1" "--scfi -ali" >>> + run_list_test "ginsn-push-1" "--scfi -ali" >>> + >>> + run_dump_test "scfi-cfi-label-1" >>> + run_list_test "scfi-cfi-label-1" "--scfi --warn" >> >> Starting here, where is it that you also check CFI generated from >> the directives? Also, why does each source need assembling twice? >> Can't you check for the diagnostics right in the "dump" tests? >> > > Its the run_dump_test which runs each test with and without --scfi. > E.g., in scfi-selfalign-func-1.d, we see: > > #as: --scfi -W > #as: > #objdump: --sframe > > Checking for warning in dump tests does not look possible as there will > be warning (Warning: --scfi=all ignores most user-specified CFI > directives) in only one case (#as: --scfi) and not the other (#as: ). Oh, I see, I'm sorry for not paying enough attention. One could probably trick things, but quite likely that's not worth it. > I thought checking for warnings explicitly may help in catching problems > as the implementation evolves. Maybe, yes. Jan