From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [IPv6:2001:67c:2050:0:465::102]) by sourceware.org (Postfix) with ESMTPS id 70B463858412 for ; Tue, 26 Sep 2023 14:44:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 70B463858412 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=aarsen.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aarsen.me Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4Rw2Zg2Y3Yz9skh; Tue, 26 Sep 2023 16:44:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; t=1695739483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D06shhDuui8NLUauYelz3XhsTpak3XvRjtMC2jYyL9w=; b=VY+BgrYjHnJ6MHLpbj9XRKZnUxky3ZAfDZmaAgLhMr1CG4iviCVviSTEH4kVAZP6PTRXEj Vibkdw03sVzBGP0mkG+/LNGX3fFSJ4012EWLMEo6c2FaWqF81A5zYaE+rnktDi/CqI1LDE tpVEJzNoBxSoab/Syp9YmdIr3sTm4cAH4Ttf7CMyN6COgg7jgxrcPBP+JlY83Hq20q+yQz l0KlsIquyw4eh6rEqNq7j78ZzKYYQTHaGHYK4KJrEPZF0y6d1kF1FFl3gsFYYZ3KTkqGtU TvTdl1kO/IMhKzgSFf9b6AJdXurtKLWN07WvViUY0QRp1TyC0VcKuAFh8ZslVQ== References: <20230926004300.1716711-2-arsen@aarsen.me> <20230926004300.1716711-3-arsen@aarsen.me> <0e53cbd9-d430-4c29-8fcd-638613f013d9@irq.a4lg.com> From: Arsen =?utf-8?Q?Arsenovi=C4=87?= To: Tsukasa OI Cc: Nick Clifton , Binutils Subject: Re: [PATCH v2 1/2] *: add modern gettext support Date: Tue, 26 Sep 2023 15:55:28 +0200 In-reply-to: <0e53cbd9-d430-4c29-8fcd-638613f013d9@irq.a4lg.com> Message-ID: <86ediluh7r.fsf@aarsen.me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Rspamd-Queue-Id: 4Rw2Zg2Y3Yz9skh X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tsukasa OI writes: > Hi, > > While not mandatory, I recommend that checking that the maintainer mode > works if you update gettext to 0.22.2 and update the > README-maintainer-mode file if it does. > > Nick, if modern gettext should (and can) be supported, is updating the > base maintainer mode gettext package to 0.22.2 (or something relatively > decent) okay? This change only affects the runtime library, so it should not impact maintainer-mode. I haven't tested maintainer mode thoroughly, because my system has (patched) Autoconf 2.71, and getting Autoconf 2.69 et al can be finnicky, but I do recall running a build with --enable-maintainer-mode, which had .pot files get rebuilt just fine using my usual gettext install. The change in this patchset should effectively just replace intl/ with gettext-runtime from 'gettext/' in the source tree, if provided, failing back to searching the system via AM_GNU_GETTEXT otherwise. Note that gettext-runtime also first tries probing the system unless =2D-with-included-gettext is provided. I've just reconfigured and rebuilt binutils and GDB with maintainer mode enabled, and it seems that .pot files got rebuilt as expected, as well as some config.h.in files. It seems that I forgot to run autoheader. Building that copy on FreeBSD also seems to result in no issues. Is there anything specific I should check for when looking at maintainer mode? Have a lovely day! =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZRLuWF8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy c2VuLm1lAAoJEFLClDAeosSTsaEA/iYgex9FKE5sMGflgDiHnLtMEvJvjlbmQqsu K75+i7lTAQDWU/DO7H4D2DwVLIIiK77KieE0j0nZpCQhBivzKvdSAA== =39ny -----END PGP SIGNATURE----- --=-=-=--