From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [IPv6:2001:67c:2050:0:465::101]) by sourceware.org (Postfix) with ESMTPS id A8EF13858D20; Thu, 10 Aug 2023 09:21:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A8EF13858D20 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=aarsen.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aarsen.me Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4RM1dG3m5Bz9tqT; Thu, 10 Aug 2023 11:21:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; t=1691659282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G9Nfg2kVYd+agCrJo+zi3fSOASMYStcZvQnEfVAX/2s=; b=iHiKzMkd22PZbu1EOv5C1RN/mSR2mqaJugapTl3BDvBlQ/pYcHGkKLF1Rm3C1CM1Rk+RT0 UAt9NIRty6vC2/7WvLajgPOkhhsAD+o5o7BmoLCgEnk1upV54jRtDeetkeILze8GsSqvGi LkNIzsYpSgeOKFt3uVmRB/hDSmk0aWoyBtwda1kkRi7Ioq7DSGYFrGsS/Quq0/vST0G2lB rYjEHdv5HX9g98aV0AWHBYumryPRYxkIp7rgVKbVsFQcaBiPWjFWeKv+y+Rw0NvifOlWwD GYr7GesasT6Psc4em5HBxWqGObVRZlaUd/NYv4Cv0kL0WGbs31orcb+CQzyDPw== References: <20230807111029.2320238-1-arsen@aarsen.me> <20230807111029.2320238-2-arsen@aarsen.me> From: Arsen =?utf-8?Q?Arsenovi=C4=87?= To: Alan Modra Cc: gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: [PATCH 01/45] *: Regenerate autoconf and aclocal files Date: Thu, 10 Aug 2023 11:13:22 +0200 In-reply-to: Message-ID: <86il9nb6d2.fsf@aarsen.me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alan Modra writes: > On Mon, Aug 07, 2023 at 01:07:04PM +0200, Arsen Arsenovi=C4=87 via Binuti= ls wrote: >> bfd/ChangeLog: >>=20 >> * aclocal.m4: Regenerate. >>=20 >> gold/ChangeLog: >>=20 >> * aclocal.m4: Regenerate. >>=20 >> intl/ChangeLog: >>=20 >> * aclocal.m4: Regenerate. > > Hmm, these three and the gprofng changes are *not* regeneration, > because the files don't need regenerating at the start of a patch > series. Without this base commit, this diff would be inadvertently merged into subsequent patches, so I decided to separate it out at the start to get more self-contained patches. > What's more, if I apply your patch series then when I regenerate at > the end I get different generated files.. Yes, I also found this odd. I couldn't find the cause at the time of writing. > Maybe it would be better if changes to generated files are left to a > final patch that does a bulk regeneration. It would certainly be > easier to review. Hmm, my impression is that it'd be easier to handle these patches if each commit had accurate generated files. I can switch to a regeneration after the fact if so desired. =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZNSsCV8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy c2VuLm1lAAoJEFLClDAeosST5fIA/jE4Ls/BAJpS4J6Fo+5wxRvS+kP8Vl1Vow4Y fTwIJsa1AP4wnaAi59SxvTHk++9U5a/7aeVuinVM4I1q5O0GM9PeCQ== =zMfX -----END PGP SIGNATURE----- --=-=-=--