From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 3FCF83858C53 for ; Mon, 15 Apr 2024 18:14:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3FCF83858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3FCF83858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713204882; cv=none; b=dlW3yQICzDmEmgiI4vyiojZFFxHhhSEbJZvy3NH3FIJ9HHo/1lG8WEh3yIf0GKNcKrvxCPPoPX+cNiyiY+N/jsTvNtfzpcz9GOttcMnxhrGUy///l7YoKOg6RdZtpx2WuRZSK7i6O0lVJ9XgDqtwH/Aw0F0P6YLbrtN5UAhhJyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713204882; c=relaxed/simple; bh=5XOFqDDsYhvwj/tMWu8l36hw2CmKf18NYYOobyC/r10=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bjN7CleickOcC5Rtzfe7H2Wbv/QKaTXONggO+kBWo8Nz2bt6829F4WbnmkvYud9/BNi3gFOein3mdf4qmFd9SsyKR2PUrvv9QwFDP65piDx4A0gRr/O4DoYUar8jPPy7r80P7eVhrhaslQFfkI6kpfUfnLbNV4pDS68nJFd2j10= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5010a.ext.cloudfilter.net ([10.0.29.199]) by cmsmtp with ESMTPS id wDI8r4Sxel9dRwQqlrlxNB; Mon, 15 Apr 2024 18:14:39 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id wQqkrifmxo82kwQqlr1Lob; Mon, 15 Apr 2024 18:14:39 +0000 X-Authority-Analysis: v=2.4 cv=WOB5XGsR c=1 sm=1 tr=0 ts=661d6e8f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=pGLkceISAAAA:8 a=0DLgbt8f0xDGEW86WRcA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1w/Jg0K6yWx4PrrsQGvfYIrgQLv90MdPmV8CkP20d2g=; b=IRAh72hops3aPfchixR8cWATf3 ekLBHiojwnXlaC2bscahesbRNrXNuwyabqrzcuDtI6ZuKLcYLJ+/w9fWbqUykUri57k7fhobjH1DY bJyiYG3Zo04Z+CaNgMejt3ZHf; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:45740 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rwQqk-000ZXU-1s; Mon, 15 Apr 2024 12:14:38 -0600 From: Tom Tromey To: Alan Modra Cc: Tom Tromey , binutils@sourceware.org Subject: Re: [PATCH 1/2] Thread-safety improvements for bfd_check_format_matches References: <20240324211229.1444550-1-tom@tromey.com> <20240324211229.1444550-2-tom@tromey.com> X-Attribution: Tom Date: Mon, 15 Apr 2024 12:14:37 -0600 In-Reply-To: (Alan Modra's message of "Wed, 10 Apr 2024 13:09:08 +0930") Message-ID: <871q76333m.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rwQqk-000ZXU-1s X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:45740 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLUMH7+NtiNQMr71mI6pJDqRLCQohe2wbIMN8y5je3IxzFoZjBgyCnfPIp3ds/UAanZGSSpmx4cSlhUCSb3Wl6/JBiNdCu57yZrlMRh2mHursGXDRe36 e5RaWlAnpNgeg7oBD5IuFWhv3AjLR6XztqRZJVnDovgeLTpyvRlxkfiXQfdWq0AiBv2BfH6SuYQCpYTwV+T1ZuhbIEhbcWL71+s= X-Spam-Status: No, score=-3015.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Alan" == Alan Modra writes: Alan> I suspect you have changed things a little. The curent per_xvec_warn Alan> array has an extra element to cache messages emitted when xvec is Alan> NULL. I added that just in case such a thing ever happened. I don't Alan> think it does, so I'm not at all concerned about a change in behaviour Alan> when xvec is NULL. Alan> However, the new _bfd_per_xvec_warn does seem to be a little weird Alan> should messages->abfd-xvec ever be NULL. It seems it will create a Alan> new entry in the list for a NULL targ that then might be reused for a Alan> later non-NULL targ message. Also, the description for the new Alan> _bfd_per_xvec_warn needs updating and maybe the function should be Alan> made static and moved from targets.c to bfd.c. Thanks for the review. I've made these changes, and since I was already in there I went ahead and fixed the NULL xvec issue as well. I'll send v2 momentarily. Tom