From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Alan Modra <amodra@gmail.com>, binutils@sourceware.org
Subject: Re: [PATCH 1/3] Make several more BFD globals thread-local
Date: Tue, 19 Mar 2024 14:17:58 -0600 [thread overview]
Message-ID: <871q86gemh.fsf@tromey.com> (raw)
In-Reply-To: <87v85ouzdo.fsf@tromey.com> (Tom Tromey's message of "Thu, 14 Mar 2024 18:12:19 -0600")
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Alan> Oops, sorry. I didn't see any uses of bfd_print_error in the sources
Alan> and didn't check its history.
Tom> Thanks, I appreciate the update. I sent the rewrite of gdb's error
Tom> handler to gdb-patches today.
Tom> I also have a patch to handle thread-safety with the per-xvec messages.
Tom> I'm going test that with the bug you mentioned before submitting it.
Quick update on this...
I sent another note about my inability to access the test.
While looking into this, though, I couldn't reproduce the exact race
mentioned in the bug. However, I still believe it is there. And, my
testing shows another race, this time between a call to
bfd_cache_close_all on one thread, and bfd_check_format_matches on
another. I plan to rework my patch to account for this as well, I think
by having bfd_cache_close_all skip any BFDs currently being
format-matched.
Tom
next prev parent reply other threads:[~2024-03-19 20:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 1:03 [PATCH 0/3] Fix some error-printing issues Tom Tromey
2024-01-30 1:03 ` [PATCH 1/3] Make several more BFD globals thread-local Tom Tromey
2024-02-12 15:28 ` Nick Clifton
2024-02-12 23:52 ` Tom Tromey
2024-02-13 0:35 ` Tom Tromey
2024-02-13 1:20 ` Tom Tromey
2024-03-09 1:12 ` Tom Tromey
2024-03-09 4:11 ` Alan Modra
2024-03-09 10:31 ` Alan Modra
2024-03-15 0:12 ` Tom Tromey
2024-03-19 20:17 ` Tom Tromey [this message]
2024-03-15 1:15 ` Tom Tromey
2024-01-30 1:03 ` [PATCH 2/3] Do not call fputc from _bfd_doprnt Tom Tromey
2024-02-12 15:04 ` Nick Clifton
2024-01-30 1:03 ` [PATCH 3/3] Introduce bfd_print_error function Tom Tromey
2024-02-12 15:04 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q86gemh.fsf@tromey.com \
--to=tom@tromey.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).