From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 3DD363858C5F for ; Sat, 22 Jul 2023 06:54:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3DD363858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36M5pRrk031812; Sat, 22 Jul 2023 06:54:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2023-03-30; bh=hBw+y48I/4ttW9D7KyJzegbBtM577POu76Cl1VzMJh4=; b=pve2/piTRVQUr1JNxFAbTSZ9pt1OCgSj1f2l1uta1T3CqDTKsAT4BE1IN4thUD1cuenj Sf9JTVspfNG9ve1lY6UKhNs6tvx8RKD0NcbFfsMcSNUfBvVlL577iFn2729Yzwqu7f7C p1Od3/rKJDjISrxUH4kxLESxFfm20Y0E4vhGVJveIANGZZMRVq/7CeLIXmMdRI8Win1O GpfdCmLYAmX+x/1Pl6/Fp82rSnbMWQOvoiXQyEWRvAdzwwj3kAYClEfhSb8EM6lliP47 Dh0+QnjKA6fmqS6wLTtjuP4XFdrki08Zr0hvaO5hpP15w2z53IEl3KrFzDqhDX3o4/GE jg== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3s05hdr6by-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 22 Jul 2023 06:54:01 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 36M5p1dI029069; Sat, 22 Jul 2023 06:54:00 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2176.outbound.protection.outlook.com [104.47.59.176]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3s05j7w9pb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 22 Jul 2023 06:54:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZLgG2W2JjhnyFenAMNLPRk0ymVMZ4tYwc5VBf7TpYz2twVKxzztpMAY5R/vDw3HQt+2PIAjfD/wFNhQBbvn2B9cNHUXI3consYIRK478KSGEQota69736+OZBDrODP+psMWovS39dZKtmNizOk1WHUjKDAZ/xSNigi68X/52BebQHGi4K8LaE0trwy23J0HQaMjBL6Fy8BeX4uBdGJw9f/kxydheTLVQZrHJzr5bWk6pZ0S1okKSUhQrnE7OpHRus/i4qsHoushv9cy9ZAOCseBOR2TQMp06VWhEofGhmsMwL2t6n8Dyf+aYDGEEmumLLA1MI7XP6wjo6wiciXUXYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hBw+y48I/4ttW9D7KyJzegbBtM577POu76Cl1VzMJh4=; b=jLQhZOsa6deQI46djJHggQJvz43VCc4N3C/LaQfiOuHjUmCj/YynzZMLgAFQIevOo1q1+POt+aP1xKWSn0DGbtMO7EOOrOFdXoyEFQOyHStzGtatU4EX7rNrtUbYBhXkjR0zZu3zwlU5PhiKXsQMeFJZ6htiwKy6urTf5gWKe/Wpo03boNet2jwSeawsk85Wa1T2rv0LjrsRuXw+kMf9TZYPno4mfPHV8EyWdWHc34fHuhUX3E6X5zDLhzC9kjPCuxG16A0RPPw3HKZ//4ZKIOJsqdLDHnieEd6PXhYefsxv1GFAkShN/SaVZnjdWQAf6TJZbexexc7enEiDKtjn9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hBw+y48I/4ttW9D7KyJzegbBtM577POu76Cl1VzMJh4=; b=Nwhw+jfJY9Ijcbhbw7tdREYmVp6FEskmMyl4tZjtm+AuznPs1+0kPFbfiHeg93bsLTPL/j1Nja8vM2lS4EhVcpaD6NMuKUCjUPcWbUZWcOj6bcBBxgJqVg82JZyeEtVn/H0U46qOFOWVukS1mhgGaKkDqJc7wMVSzzxABlGSzIQ= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by MW5PR10MB5716.namprd10.prod.outlook.com (2603:10b6:303:1a3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.25; Sat, 22 Jul 2023 06:53:58 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::4d0c:9857:9b42:2f6c]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::4d0c:9857:9b42:2f6c%4]) with mapi id 15.20.6609.026; Sat, 22 Jul 2023 06:53:58 +0000 From: "Jose E. Marchesi" To: David Faust Cc: binutils@sourceware.org, Jan Beulich , Nick Clifton Subject: Re: [PATCH 1/4] opcodes: use CGEN_INSN_LGUINT for base instructions In-Reply-To: <5f2744d4-11a7-fc07-a0d4-0b360e72b7c1@oracle.com> (David Faust's message of "Fri, 21 Jul 2023 15:34:51 -0700") References: <20230511141351.18886-1-jose.marchesi@oracle.com> <20230511141351.18886-2-jose.marchesi@oracle.com> <874jobm4x6.fsf@oracle.com> <5f2744d4-11a7-fc07-a0d4-0b360e72b7c1@oracle.com> Date: Sat, 22 Jul 2023 08:53:48 +0200 Message-ID: <871qh04etf.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-ClientProxiedBy: FR2P281CA0133.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::17) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|MW5PR10MB5716:EE_ X-MS-Office365-Filtering-Correlation-Id: 955cc609-af65-4fb4-e0df-08db8a806c20 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X6osg72uq6pRFPFcrk4qTya/Uv3pGWdKO4BNQ4Q1yANEe0Rzt4XqJWQOG2TNKmMmPimFMkVzfVjmokq4H1N4m51WO6g5HdK2DruxhkalOwPLJYUhBn4lsJogjKeBRmAbTLJ2VxC4L8/XRPGyDrUhAV2wywdxLhEsOtQuhJcGdZuFpDWgnPE0nOApX471VVldnulnbvktnGqGujSzgTwmvAzs9uie1GYUSnafBcRqcxSiSjt8ktfP6QfWwyIspqAyN58iSkDM9fPtlP3j4BDbSnzTmQGbZYPb6XlljRixO5jXaCp+TkDkMsdITkER19rGD0uT163FpuB1DxYxIr2k2QSMH0csD1i7EmGojqyAOABR7hNwmnK1NpfkREVqUl0s2Fe7fpKCoVkIPq/K+aFK8hxqQjbmI+emIlB8pzEcVQUON5RJnLEmcXQtFkUo8HUCsHv8ASoM14SmspsGJhveNYpxRreYjwG/jn5tceAR1SbZuxsIes9mubtR4stuYTnw/L9SOLLt2cZoM76zZMyfDAeErB313n4f4TNqlMHWNOHIk0TykjfASNsyd0XgfjAL X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(346002)(39860400002)(376002)(366004)(451199021)(2906002)(66476007)(66946007)(66556008)(4326008)(6636002)(6486002)(37006003)(54906003)(83380400001)(6666004)(478600001)(36756003)(2616005)(186003)(6512007)(86362001)(38100700002)(26005)(53546011)(6506007)(41300700001)(8936002)(8676002)(6862004)(316002)(5660300002)(66899021);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Lg42Jxxf90Moq16JXB5y7h1EtIW2vaAP7S1T3RP0jOXXRksxYX37iQ76lhvf?= =?us-ascii?Q?3L707y2TE5ux1Aofj/N3TBEJkOUHiddxRQYWI6LO+rnwcqyM7gnGnrsUKwvo?= =?us-ascii?Q?Qf+T/vrvacUowhz0yM2k/AbXU+WewWOUWMCwI7IkG1IKwvC8MRlvkgNbSqQG?= =?us-ascii?Q?qxUxxHscH5sZ/k6yugCfpkj9Xpa0LRRjj76Zz5SnHhAfpe1BEUiW4rr2FuiJ?= =?us-ascii?Q?2X3PqCd513gM/HCz5FJsxcclaEBbB9WpiVPWlHUpcvqosvDj5waX84tljY0c?= =?us-ascii?Q?sz8iCtZADtH6RR7jUugbvRu1cY8fYzE1Ntuj67oUehnzPQuQ96Hpm6Cmi/i/?= =?us-ascii?Q?AYnavNV5E+dmlbn73jMnlImXwBa7p6effPeET6YWSL1uBIhiIwDWDRyQd1lS?= =?us-ascii?Q?WthVkos19BdBICSlcS9X5LSBYS/g/2eaSCZM7/r0y2/SZd2/j5JKjmsyT8Gi?= =?us-ascii?Q?UlFwAWsxFMrxBJShlhB0hG35JrtpSOy8yECTvJ6gcev4N0EusCDzzRnttD1I?= =?us-ascii?Q?chTqf26sICjqTJMgB85j661njn8ROGcNAWJr6VnDeimYVh84LGxEmhezOXib?= =?us-ascii?Q?CNGyJO9C/qngRmnlPICpgTXlMLw1MCuXtnCf3tGCpacEM4Azduy0cwWPazON?= =?us-ascii?Q?mA9bW2JXOT8eQvBVsntnUkSZowla4A0ZwXueXrXT28sIrOtv7S+ef0UaMNzL?= =?us-ascii?Q?CKzkxrV/sMKEA2KnUJs1BWtHNRR7x3CXxICVo1zH9nbiBj58vcDrD0ApMOLh?= =?us-ascii?Q?utXlsxFyG0PSE39ZwgqdD3mxqDsX3YIMQtPWAAhEHEPZEg5LCxK4Ou/fPtY7?= =?us-ascii?Q?1RR6UijzHJz1GKxNLAFaq5AS4F7NyH5vqiiwcdJYY6zApkbLtdbQTFYanu9X?= =?us-ascii?Q?qGt4eiyquPWyhuzilVejkpHOkE42UvzsGQUKGXT53ikmVZt2T2GHMMwHgOs4?= =?us-ascii?Q?uTwg5CjrgxGbXQn7ZTuNRsYItcJGHHrkNCWCp3AzW4BsI6P42wLYzILcerGb?= =?us-ascii?Q?8WKGzD3wRZ1MIQEa8IBArkVY+N8EflirvCtHPOr+lBbzSs0Vqhpr3HmZjrgG?= =?us-ascii?Q?ZWZLniAHBR4su1UR6ihSDrM9Jd9zn2ksrH+fb4oRR+4IY4UIsS/Q/M5HnaWH?= =?us-ascii?Q?09H4wCsdXGrjz6X3Q8d7u71riilI4K022RAr3NvQePhcBwWEPTuJG6VwMYO0?= =?us-ascii?Q?8J3uxruHv83FCzsB+r8zmz7UuUcnbivTQ/P1q4vgkSkvf+orelBZjvoBk42O?= =?us-ascii?Q?ZLLLk4SJcM50MZLgUdPhD5f2mZcKRpaEFrC4ayCfL2GuHfan+H5E7cAyZ6tO?= =?us-ascii?Q?+a0bexnGqd/4RX+ux6E9qfzlwrVPedpzS8Vnn3/NO0envNlu4BBTEC/+Qn8I?= =?us-ascii?Q?Q0HtsK23+X+z+YFd8o9ZZ0eBUcKbbQYtDUgjOBwBQc1jLCO0PA1IDS9O9ZzG?= =?us-ascii?Q?rXD3fDEoT2jdXn+9nm//2pg0NPYT4OvZ07KGtx52tTSP4L1nOqDUJbM/TI2Z?= =?us-ascii?Q?qZwBbj/haa0fDItZY+c3gu+XcKD8UWBKrwaTW0KUWWBou+QK5Tltfo7IVREZ?= =?us-ascii?Q?Dl/Kfozzm4BNGlOQS9lalIvGPX3ONUocP5nz6KMUFpNbRhX2pmbI8HEGcS1S?= =?us-ascii?Q?zg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: KiLrK4brOnRVdY4KNkSuBpvkhxkkPUvBZGC9r+kVtmmixXaCxXBAT9BWJIK15E6apq0jeiH1A5QU4RmzAlHZHz1Aomi2zEXMUaYydfjMcbCfB0+XIO0wUOflOb35TdhE6es9SbT9yq6cSIy1H0k2zJFkujrtBV05oxKuwTwaGPEAE/WNw2GIz/NHpctu11mAj9QuFbe5CV3kRlVW2Dz9VofkyR61uGVOOuuzKL4k2tAVdrlyerYFWX9Uc/EDVKZsVLAjCc9zSCKP1JWcrDpRVi9sWAPT18hpjgpGWod0NvGXEroJedNKpO9d/3ZI4ImHzluX10+rudLiWJbR0kSjrfIwqh+23cg3dwzsfuJKNZ3b97nDnPSCAZH/hhWTPaSHrlAU991+tp6ZnV4eniUfig5tyjPP7EF87PGS6sAa1R+AO1YZYSyxQUQZmuBy2Fd4U6xJJtv/5y6EOpNuf0qmLGYl9yc6fA/vcmaiHjud34MOcC3XFkk/WHh+lQXu0tLmFQG2QgEBvP/K+uEqwNpM3tLAxj18qhlAIPLLxb9Vo3niShrc1mRkc5StZW9G+Iirh9zp7g0UsvxHAMjwXs3T1C6X1YHS1SOzJbJfMjE/zHGM0vRVDpuMjxY85JQNCtBHTr63sdYXRdRvustaJL7JVw37CoaEWdxGQDADN1wOYa79/Y4VCHA+Xj6LS+BtZCmm8c13/OkwawNpmi7wKGM75CME6n45CoHth7ZLAYFKNwYwVE33ydWKKyghK2Yv03yqUkECOQ7cCfXPgFv1OnMXO/tSleTT2yNUx2rhb6ws3dtNdtm7QmZvfg7xuUmbqF+J X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 955cc609-af65-4fb4-e0df-08db8a806c20 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2023 06:53:57.9064 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P+7DnNvQFJyAaEWwzFpFqh/bieRDpxpy6W2wa5HesBbQBDnTcSOftJlHsSxB7CbAjQf+zV0e1e7+5nF61jt5XkcDs/0QrYpxZK7z/JmAUOY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5716 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-22_02,2023-07-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=252 spamscore=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307220062 X-Proofpoint-ORIG-GUID: h2zmUHs1wCGDAO7DKtPFsgAkbbjMBo_J X-Proofpoint-GUID: h2zmUHs1wCGDAO7DKtPFsgAkbbjMBo_J X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 5/17/23 07:03, Jose E. Marchesi via Binutils wrote: >> >> Hi Nick. >> >>> Hi Jose, >>> >>>> This patch changes the opcodes CGEN support code in order to allow >>>> base instructions with opcodes past the least significative 32 bits. >>>> Note that the masks have been adapted in a previous patch. >>>> This patch has been regtested for all the current targets in >>>> binutils >>>> that are based on CGEN, namely: >>>> - bpf-unknown-none >>>> - lm32-elf >>>> - fr30-elf >>>> - ip2k-elf >>>> - iq2000-elf >>>> - m32c-elf >>>> - m32r-elf >>>> - mep-elf >>>> - mt-elf >>>> - or1k-elf >>>> - stormy16-elf" >>>> Also with --enable-cgen-maint and --enable-targets=all. >>>> No regressions observed. >>> >>> Patch approved - please apply. >> >> Thanks. >> >> Before pushing I am looking at the CGEN_INSN_BYTES point raised by Jan, >> which made me realize that, even when I am pretty sure the path >> introduces no regressions, it may be incomplete because it won't cover >> targets that would have opcodes past the lowest 32-bits of the base >> instruction and that also define CGEN_INT_INSN_P (even if we currently >> don't have such targets.) > > With the recent changes to the BPF port to not use CGEN, this patch > is no longer needed, right Jose? Correct. To no have to deal with these kind of tangents was a big motivation for the desCGENization of the port.